Author: Shubham Sandeep Rastogi Date: 2024-10-23T14:31:15-07:00 New Revision: c9199700b8fdde50a920857207e4387cfe69da45
URL: https://github.com/llvm/llvm-project/commit/c9199700b8fdde50a920857207e4387cfe69da45 DIFF: https://github.com/llvm/llvm-project/commit/c9199700b8fdde50a920857207e4387cfe69da45.diff LOG: Revert "[lldb] Fix crash missing MSInheritanceAttr on CXXRecordDecl with DWARF on Windows" (#113498) Reverts llvm/llvm-project#112928 This is because it broke greendragon: SymbolFile/DWARF/x86/member-pointers.cpp Added: Modified: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp Removed: lldb/test/Shell/SymbolFile/DWARF/x86/member-pointers.cpp ################################################################################ diff --git a/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp b/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp index f5063175d6e070..a57cd8efce8a11 100644 --- a/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp +++ b/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp @@ -2771,9 +2771,6 @@ static bool GetCompleteQualType(clang::ASTContext *ast, ast, llvm::cast<clang::AttributedType>(qual_type)->getModifiedType(), allow_completion); - case clang::Type::MemberPointer: - return !qual_type.getTypePtr()->isIncompleteType(); - default: break; } diff --git a/lldb/test/Shell/SymbolFile/DWARF/x86/member-pointers.cpp b/lldb/test/Shell/SymbolFile/DWARF/x86/member-pointers.cpp deleted file mode 100644 index 817833d4fa7515..00000000000000 --- a/lldb/test/Shell/SymbolFile/DWARF/x86/member-pointers.cpp +++ /dev/null @@ -1,24 +0,0 @@ -// REQUIRES: lld - -// Itanium ABI: -// RUN: %clang --target=x86_64-pc-linux -gdwarf -c -o %t_linux.o %s -// RUN: %lldb -f %t_linux.o -b -o "target variable mp" | FileCheck %s -// -// CHECK: (char SI::*) mp = 0x0000000000000000 - -// Microsoft ABI: -// RUN: %clang_cl --target=x86_64-windows-msvc -c -gdwarf %s -o %t_win.obj -// RUN: lld-link /out:%t_win.exe %t_win.obj /nodefaultlib /entry:main /debug -// RUN: %lldb -f %t_win.exe -b -o "target variable mp" | FileCheck --check-prefix=CHECK-MSVC %s -// -// DWARF has no representation of MSInheritanceAttr, so we cannot determine the size -// of member-pointers yet. For the moment, make sure we don't crash on such variables. -// CHECK-MSVC: error: Unable to determine byte size. - -struct SI { - char si; -}; - -char SI::*mp = &SI::si; - -int main() { return 0; } _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
