Michael137 wrote:
> > Skipping empty fields does seem like a better heuristic here
>
> FWIW, I (independently) came to the same conclusion when investigating the
> fallout of #76756, though it's not fully clear to me whether the PR has been
> updated to do that.
Not yet, but will have a look
labath wrote:
The implementation of Variable::IsThreadLocal is most likely a non-starter, as
it introduces a relatively expensive operation on the common variable update
path for all variables. Doing this (once) at variable creation would be better,
but I still have very big reservations about
CarlosAlbertoEnciso wrote:
On Ubuntu 22.04 with the latest official supported GCC 12.3.0, this commit
breaks the `check-lldb` due to a failed compilation:
```
llvm-project/lldb/unittests/SymbolFile/DWARF/SymbolFileDWARFTests.cpp:95:33:
error: class template placeholder 'llvm::ArrayRef' not perm
labath wrote:
> > I don't like globals
>
> Is this the only argument?
No, it's not. You can find my second reason in the full text of my previous
message. The third reason is that I think this is something that should be
handled independenly of this (already larger that I'd like) patch.
> I
https://github.com/kamleshbhalui created
https://github.com/llvm/llvm-project/pull/110822
On AArch64, TLS variables do not have DT_Location entries generated in the
debug information due to the lack of dtpoff relocation support, unlike on
x86_64. LLDB relies on this location info to calculate
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Kamlesh Kumar (kamleshbhalui)
Changes
On AArch64, TLS variables do not have DT_Location entries generated in the
debug information due to the lack of dtpoff relocation support, unlike on
x86_64. LLDB relies on this location info to calcula
@@ -6528,6 +6528,74 @@ static void AddRegion(const MemoryRegionInfo ®ion,
bool try_dirty_pages,
CreateCoreFileMemoryRange(region));
}
+static void AddRegisterSections(Process &process, ThreadSP &thread_sp,
+CoreFileMemoryRanges
@@ -108,21 +108,6 @@ void DynamicLoaderPOSIXDYLD::DidAttach() {
// if we dont have a load address we cant re-base
bool rebase_exec = load_offset != LLDB_INVALID_ADDRESS;
- // if we have a valid executable
labath wrote:
Yeah, let's go with that. Can you c
@@ -541,9 +542,18 @@ size_t ELFLinuxSigInfo::GetSize(const
lldb_private::ArchSpec &arch) {
}
}
+static bool IsSignalWithAddrValue(int signo) {
+ // SIGILL, SIGFPE, SIGSEGV, SIGBUS, SIGTRAP
+ // We can't use the enum here because it may not be available on windows or
+ //
perry-ca wrote:
> > sorry this is same as #107906 (with a bigger impact radius, as you're also
> > changing getBufferForFile) and doesn't address any of the issues mention
> > about explaining the semantics of `IsText` or justification for changing
> > the core VFS interfaces, for an operation
abhina-sree wrote:
> > sorry this is same as #107906 (with a bigger impact radius, as you're also
> > changing getBufferForFile) and doesn't address any of the issues mention
> > about explaining the semantics of `IsText` or justification for changing
> > the core VFS interfaces, for an operat
@@ -267,6 +267,21 @@ add_lit_testsuite(check-lldb "Running lldb lit test suite"
lldb-shell-test-deps
lldb-unit-test-deps)
+# This target covers all targets that are tied to implementation details
+# of libc++, intended to be run by the libc++ pre-merge CI.
+add_lit_tes
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/110856
>From ee28f91822ca449b7b4bb84293cae2aee6803da4 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Wed, 2 Oct 2024 15:44:28 +0100
Subject: [PATCH 1/2] [lldb][CMake] Add single target that runs libc++ tests
---
@@ -267,6 +267,21 @@ add_lit_testsuite(check-lldb "Running lldb lit test suite"
lldb-shell-test-deps
lldb-unit-test-deps)
+# This target covers all targets that are tied to implementation details
+# of libc++, intended to be run by the libc++ pre-merge CI.
+add_lit_tes
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/110856
>From ee28f91822ca449b7b4bb84293cae2aee6803da4 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Wed, 2 Oct 2024 15:44:28 +0100
Subject: [PATCH 1/3] [lldb][CMake] Add single target that runs libc++ tests
---
https://github.com/ldionne approved this pull request.
Libc++ changes LGTM. Thank you!
https://github.com/llvm/llvm-project/pull/110856
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commi
@@ -556,6 +566,22 @@ Status ELFLinuxSigInfo::Parse(const DataExtractor &data,
const ArchSpec &arch) {
si_signo = data.GetU32(&offset);
si_errno = data.GetU32(&offset);
si_code = data.GetU32(&offset);
+ // 64b ELF have a 4 byte pad.
+ if (data.GetAddressByteSize() == 8)
Author: dlav-sc
Date: 2024-10-02T12:08:22+03:00
New Revision: 87121403e251828ed0fee8a9c2a2993ce8f57861
URL:
https://github.com/llvm/llvm-project/commit/87121403e251828ed0fee8a9c2a2993ce8f57861
DIFF:
https://github.com/llvm/llvm-project/commit/87121403e251828ed0fee8a9c2a2993ce8f57861.diff
LOG:
https://github.com/dlav-sc closed
https://github.com/llvm/llvm-project/pull/99336
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
dlav-sc wrote:
Thank you for the review.
https://github.com/llvm/llvm-project/pull/99336
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
weliveindetail wrote:
@labath @kendalharland Here is an attempt to fix this in the bindings
themselves: https://github.com/swiftlang/llvm-project/pull/9370 What do you
think?
https://github.com/llvm/llvm-project/pull/104514
___
lldb-commits mailing l
Author: Pavel Labath
Date: 2024-10-02T11:13:43+02:00
New Revision: 15f90203bcbc685e8d63a7e52e60adff02bf5499
URL:
https://github.com/llvm/llvm-project/commit/15f90203bcbc685e8d63a7e52e60adff02bf5499
DIFF:
https://github.com/llvm/llvm-project/commit/15f90203bcbc685e8d63a7e52e60adff02bf5499.diff
https://github.com/labath closed
https://github.com/llvm/llvm-project/pull/110648
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath wrote:
> Skipping empty fields does seem like a better heuristic here
FWIW, I (independently) came to the same conclusion when investigating the
fallout of #76756, though it's not fully clear to me whether the PR has been
updated to do that.
https://github.com/llvm/llvm-project/pull/9
Author: Zequan Wu
Date: 2024-10-02T14:11:04-07:00
New Revision: e379b4b67f760e743d8bc826cc6de00a27109dbd
URL:
https://github.com/llvm/llvm-project/commit/e379b4b67f760e743d8bc826cc6de00a27109dbd
DIFF:
https://github.com/llvm/llvm-project/commit/e379b4b67f760e743d8bc826cc6de00a27109dbd.diff
LOG
ZequanWu wrote:
> On Ubuntu 22.04 with the latest official supported GCC 12.3.0, this commit
> breaks the `check-lldb` due to a failed compilation:
>
> ```
> llvm-project/lldb/unittests/SymbolFile/DWARF/SymbolFileDWARFTests.cpp:95:33:
> error: class template placeholder 'llvm::ArrayRef' not pe
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/110901
>From 262ff5a7a24403eaee1c5b9f95db118925494eb1 Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Tue, 1 Oct 2024 17:39:10 -0700
Subject: [PATCH] Support inline diagnostics in CommandReturnObject
and impl
adrian-prantl wrote:
Side note: I also think that it should be possible to change
CommandObjectExpression to just put the error into CommendReturnObject instead
of printing it to the error stream directly. But that's for a future patch.
https://github.com/llvm/llvm-project/pull/110901
https://github.com/vogelsgesang updated
https://github.com/llvm/llvm-project/pull/110784
>From 41694e6e64b3f16cc5b8e4b64c89d27f4e076573 Mon Sep 17 00:00:00 2001
From: Adrian Vogelsgesang
Date: Fri, 20 Sep 2024 20:43:11 +
Subject: [PATCH 1/3] [lldb-dap] Correct auto-completion based on ReplM
@@ -32,90 +47,146 @@ def test_completions(self):
breakpoint2_line = line_number(source, "// breakpoint 2")
self.set_source_breakpoints(source, [breakpoint1_line,
breakpoint2_line])
+
+
+def test_command_completions(self):
+"""
+Tests comple
@@ -32,90 +47,146 @@ def test_completions(self):
breakpoint2_line = line_number(source, "// breakpoint 2")
self.set_source_breakpoints(source, [breakpoint1_line,
breakpoint2_line])
+
+
+def test_command_completions(self):
+"""
+Tests comple
https://github.com/ashgti approved this pull request.
https://github.com/llvm/llvm-project/pull/110784
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/vogelsgesang updated
https://github.com/llvm/llvm-project/pull/110784
>From 41694e6e64b3f16cc5b8e4b64c89d27f4e076573 Mon Sep 17 00:00:00 2001
From: Adrian Vogelsgesang
Date: Fri, 20 Sep 2024 20:43:11 +
Subject: [PATCH 1/4] [lldb-dap] Correct auto-completion based on ReplM
https://github.com/vogelsgesang updated
https://github.com/llvm/llvm-project/pull/110784
>From 41694e6e64b3f16cc5b8e4b64c89d27f4e076573 Mon Sep 17 00:00:00 2001
From: Adrian Vogelsgesang
Date: Fri, 20 Sep 2024 20:43:11 +
Subject: [PATCH 1/5] [lldb-dap] Correct auto-completion based on ReplM
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `lld-x86_64-win` running on
`as-worker-93` while building `lldb,llvm` at step 7
"test-build-unified-tree-check-all".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/146/builds/1293
Here is the relevan
https://github.com/GeorgeHuyubo closed
https://github.com/llvm/llvm-project/pull/110066
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 616d1d2e998aa7a26059dc36fa04875c469f69cd
43230b5803d28d8f1a4b906e43d14cf4ddc2c363 --e
https://github.com/dzhidzhoev updated
https://github.com/llvm/llvm-project/pull/110837
>From 8deb61b462964d08b4cc5d7f296b44ea4197f65b Mon Sep 17 00:00:00 2001
From: Vladislav Dzhidzhoev
Date: Tue, 1 Oct 2024 13:14:25 +0200
Subject: [PATCH] [lldb][test] Provide proper path to LLVM utils in API t
@@ -2088,6 +2088,13 @@ bool RegisterContextUnwind::ReadFrameAddress(
UnwindLogMsg("No suitable CFA found");
break;
}
+ case UnwindPlan::Row::FAValue::isConstant: {
+address = fa.GetConstant();
+if (abi_sp)
+ address = abi_sp->FixCodeAddress(address);
---
https://github.com/felipepiovezan updated
https://github.com/llvm/llvm-project/pull/110726
>From a23540f5a793d7c9bb115f06a5af0266f8cfb038 Mon Sep 17 00:00:00 2001
From: Felipe de Azevedo Piovezan
Date: Tue, 24 Sep 2024 09:26:29 -0700
Subject: [PATCH 1/3] [lldb] Add isConstant mode for FA locati
https://github.com/kamleshbhalui updated
https://github.com/llvm/llvm-project/pull/110822
>From f36d8a2346be90b6bf5d68a7cec0bcf2d41cbd99 Mon Sep 17 00:00:00 2001
From: Kamlesh Kumar
Date: Thu, 19 Sep 2024 18:57:14 +0200
Subject: [PATCH] [LLDB] Enable TLS Variable Debugging Without Location Info
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/110885
>From 5ed6e20b50f70754efbaa157720a7ef120bb6b1e Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Wed, 2 Oct 2024 09:50:26 -0700
Subject: [PATCH 1/2] Remove additional logic to disable the dynamic loader
when t
@@ -327,8 +327,6 @@ def test_relative_module_name(self):
old_cwd = os.getcwd()
self.addTearDownHook(lambda: os.chdir(old_cwd))
os.chdir(self.getBuildDir())
-name = "file-with-a-name-unlikely-to-exist-in-the-current-directory.so"
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/110885
>From 5ed6e20b50f70754efbaa157720a7ef120bb6b1e Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Wed, 2 Oct 2024 09:50:26 -0700
Subject: [PATCH 1/2] Remove additional logic to disable the dynamic loader
when t
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/110885
>From 5ed6e20b50f70754efbaa157720a7ef120bb6b1e Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Wed, 2 Oct 2024 09:50:26 -0700
Subject: [PATCH 1/3] Remove additional logic to disable the dynamic loader
when t
@@ -318,75 +231,67 @@
GDBRemoteCommunicationServerPlatform::Handle_qKillSpawnedProcess(
lldb::pid_t pid = packet.GetU64(LLDB_INVALID_PROCESS_ID);
- // verify that we know anything about this pid. Scope for locker
- {
-std::lock_guard guard(m_spawned_pids_mutex);
-
@@ -318,75 +231,67 @@
GDBRemoteCommunicationServerPlatform::Handle_qKillSpawnedProcess(
lldb::pid_t pid = packet.GetU64(LLDB_INVALID_PROCESS_ID);
- // verify that we know anything about this pid. Scope for locker
- {
-std::lock_guard guard(m_spawned_pids_mutex);
-
@@ -119,20 +175,78 @@ static Status save_socket_id_to_file(const std::string
&socket_id,
return status;
}
+static Status ListenGdbConnectionsIfNeeded(
+const Socket::SocketProtocol protocol, std::unique_ptr
&gdb_sock,
+const std::string &gdb_address, uint16_t &gdbs
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/97443
>From 3a718c75d0458b7aece72f2ba8e5aa5a68815237 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Tue, 2 Jul 2024 18:43:34 +0200
Subject: [PATCH 1/6] [clang][RecordLayoutBuilder] Be stricter about inferring
pa
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
1bc9b67bd87d7ec51045951c93fd5db953faa745...2036458cada64a285e9b26b9b4c68bf799ff1532
lldb/
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/97443
>From 3a718c75d0458b7aece72f2ba8e5aa5a68815237 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Tue, 2 Jul 2024 18:43:34 +0200
Subject: [PATCH 1/2] [clang][RecordLayoutBuilder] Be stricter about inferring
pa
Michael137 wrote:
> If I'm understanding correctly, the way this currently works is that you do
> normal field layout, then if you discover that the actual offset of a field
> is less than the offset normal field layout would produce, you assume the
> struct is packed. This misses cases where
https://github.com/dzhidzhoev updated
https://github.com/llvm/llvm-project/pull/110837
>From a2c8b8b88fd47cbbdc32ca5f0f051391a9d77823 Mon Sep 17 00:00:00 2001
From: Vladislav Dzhidzhoev
Date: Tue, 1 Oct 2024 13:14:25 +0200
Subject: [PATCH] [lldb][test] Provide proper path to LLVM utils in API t
Author: Adrian Prantl
Date: 2024-10-02T09:11:47-07:00
New Revision: 8789c96698e027b0dd40b6e0475181505d6b8984
URL:
https://github.com/llvm/llvm-project/commit/8789c96698e027b0dd40b6e0475181505d6b8984
DIFF:
https://github.com/llvm/llvm-project/commit/8789c96698e027b0dd40b6e0475181505d6b8984.diff
https://github.com/adrian-prantl closed
https://github.com/llvm/llvm-project/pull/110707
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
slydiman wrote:
> I am still looking for an answer to this one. If it's only the
> Handle_qLaunchGDBServer that needs to not launch an lldb-server then I don't
> see why the check couldn't/shouldn't be performed there.
I cannot answer in the thread, no idea why. The answer is here
https://gith
cor3ntin wrote:
> sorry this is same as #107906 (with a bigger impact radius, as you're also
> changing getBufferForFile) and doesn't address any of the issues mention
> about explaining the semantics of `IsText` or justification for changing the
> core VFS interfaces, for an operation that's
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jacob Lalonde (Jlalond)
Changes
This is a part of #109477 that I'm making into it's own patch. Here we
remove logic from the DYLD that prevents it's logic from running if the main
executable already has a load address. Instead we let the D
https://github.com/Jlalond created
https://github.com/llvm/llvm-project/pull/110885
This is a part of #109477 that I'm making into it's own patch. Here we remove
logic from the DYLD that prevents it's logic from running if the main
executable already has a load address. Instead we let the DYLD
@@ -108,21 +108,6 @@ void DynamicLoaderPOSIXDYLD::DidAttach() {
// if we dont have a load address we cant re-base
bool rebase_exec = load_offset != LLDB_INVALID_ADDRESS;
- // if we have a valid executable
Jlalond wrote:
#110885
https://github.com/llvm/l
Jlalond wrote:
On Pavel's suggestion, I broke the DYLD changes into their own patch #110885
https://github.com/llvm/llvm-project/pull/109477
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-
Author: Adrian Vogelsgesang
Date: 2024-10-03T02:50:46+02:00
New Revision: a5876bef61e44453b915e1f79366ca1bbfdba371
URL:
https://github.com/llvm/llvm-project/commit/a5876bef61e44453b915e1f79366ca1bbfdba371
DIFF:
https://github.com/llvm/llvm-project/commit/a5876bef61e44453b915e1f79366ca1bbfdba371
https://github.com/vogelsgesang closed
https://github.com/llvm/llvm-project/pull/110784
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jimingham approved this pull request.
This looks good to me. In fact, it looks WAY better than the error handling
just above it where instead of logging something that we could find later in
the system logs, we fprintf to stderr - which in most cases won't get seen, and
exi
https://github.com/jasonmolenda created
https://github.com/llvm/llvm-project/pull/110943
If lldb tries to attach to a process that is marked 'Translated' with
debugserver, it will exec the Rosetta debugserver to handle the debug session
without checking if it is present. If there is a configu
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jason Molenda (jasonmolenda)
Changes
If lldb tries to attach to a process that is marked 'Translated' with
debugserver, it will exec the Rosetta debugserver to handle the debug session
without checking if it is present. If there is a conf
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/110856
We've been increasing the coverage of libc++ LLDB tests in the pre-merge CI
(see https://github.com/llvm/llvm-project/pull/110570). Unfortunately the tests
are spread across different targets. It would be gr
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
We've been increasing the coverage of libc++ LLDB tests in the pre-merge CI
(see https://github.com/llvm/llvm-project/pull/110570). Unfortunately the tests
are spread across different targets. It would be
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/97443
>From 3a718c75d0458b7aece72f2ba8e5aa5a68815237 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Tue, 2 Jul 2024 18:43:34 +0200
Subject: [PATCH 1/3] [clang][RecordLayoutBuilder] Be stricter about inferring
pa
https://github.com/kamleshbhalui updated
https://github.com/llvm/llvm-project/pull/110822
>From ba3071566ac697e750606c7fc941e5f6fc738367 Mon Sep 17 00:00:00 2001
From: Kamlesh Kumar
Date: Thu, 19 Sep 2024 18:57:14 +0200
Subject: [PATCH] [LLDB] Enable TLS Variable Debugging Without Location Info
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff e379094328e49731a606304f7e3559d4f1fa96f9
ba3071566ac697e750606c7fc941e5f6fc738367 --e
Author: Kazu Hirata
Date: 2024-10-02T19:20:38-07:00
New Revision: e7a43ca84fabeab386ba4d402167244dac27b265
URL:
https://github.com/llvm/llvm-project/commit/e7a43ca84fabeab386ba4d402167244dac27b265
DIFF:
https://github.com/llvm/llvm-project/commit/e7a43ca84fabeab386ba4d402167244dac27b265.diff
L
CarlosAlbertoEnciso wrote:
> Hope
> [e379b4b](https://github.com/llvm/llvm-project/commit/e379b4b67f760e743d8bc826cc6de00a27109dbd)
> will fix it.
@ZequanWu The problem is fixed. Thanks.
https://github.com/llvm/llvm-project/pull/110058
___
lldb-co
73 matches
Mail list logo
