https://github.com/jimingham approved this pull request.

This looks good to me.  In fact, it looks WAY better than the error handling 
just above it where instead of logging something that we could find later in 
the system logs, we fprintf to stderr - which in most cases won't get seen, and 
exit (but w/o an error?).

OTOH, that wasn't part of your patch, so...

https://github.com/llvm/llvm-project/pull/110943
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to