@@ -20,6 +20,8 @@
#include "llvm/Support/CommandLine.h"
#include "llvm/Support/TargetSelect.h"
+#include "lldb/Version/Version.h"
labath wrote:
Group this with the other lldb includes?
https://github.com/llvm/llvm-project/pull/108495
@@ -20,6 +23,53 @@
namespace lldb_private {
+/// A compiler-independent representation of a Diagnostic. Expression
+/// evaluation failures often have more than one diagnostic that a UI
+/// layer might want to render differently, for example to colorize
+/// it.
+///
+/// Ru
@@ -268,7 +243,7 @@ ErrorType Status::GetType() const {
result = eErrorTypeMachKernel;
else if (error.isA())
result = eErrorTypeWin32;
-else if (error.isA())
+else if (error.isA())
labath wrote:
I'm wondering if this would look nicer if
@@ -224,6 +224,14 @@ const char *Status::AsCString(const char
*default_error_str) const {
if (!m_string.empty() && m_string[m_string.size() - 1] == '\n')
m_string.pop_back();
+ // FIXME: Workaround for ErrorList[ExpressionError, ...].
+ if (m_error.isA()) {
+w
@@ -130,6 +168,11 @@ class DiagnosticManager {
m_diagnostics.back()->AppendMessage(str);
}
+ /// Copies the diagnostics into an llvm::Error{List}.
+ /// The first diagnostic wraps \c result.
labath wrote:
I guess this is no longer true.
https://git
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/106442
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
So does this not need new testing or did you not add that yet?
I'm not clear on what fully decode means because at least for certain signals
like a tag check fault we do have a description for live processes and core
files. Perhaps that's because I added those as special c
labath wrote:
Seems reasonable, but you'll need to use the signal constants from
`UnixSignals` (looked up by string), as macros like `SIGBUS` might not exist
(windows) or might not have the right value (macos). (NativeThreadLinux can get
away with using them as it always runs on the host.)
ht
@@ -73,6 +73,12 @@ class DWARFDebugArangeSet {
return desc_iterator_range(ArangeDescriptors.begin(),
ArangeDescriptors.end());
}
+
+ size_t getDescriptorsSize() const { return ArangeDescriptors.size(); }
+
+ const Descriptor &getDescriptio
@@ -132,34 +134,33 @@ TEST_F(SymbolFileDWARFTests,
ParseArangesWithMultipleTerminators) {
// Set the big endian length correctly.
const offset_t binary_data_size = sizeof(binary_data);
binary_data[3] = (uint8_t)binary_data_size - 4;
- DWARFDataExtractor data;
- data.Se
labath wrote:
> I'm actually surprised that lldb-dap sees the new diagnostics because I
> thought it would run the expression through a lower-level API like
> SBFrame::EvaluateExpression(). But I guess it just provides a "terminal"
> window that passes everything through HandleCommand. To supp
DavidSpickett wrote:
> Perhaps that's because I added those as special cases I don't remember the
> specifics.
I only added part of the description -
https://github.com/llvm/llvm-project/commit/85bc498826d4dac4b64f7b02659f6ec52f11c223.
Didn't add the fault address.
Happy to see improvements
https://github.com/jimingham closed
https://github.com/llvm/llvm-project/pull/110167
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ZequanWu updated
https://github.com/llvm/llvm-project/pull/110058
>From 8e1c59729905fb89a8764ace3dfa0d04119d273e Mon Sep 17 00:00:00 2001
From: Zequan Wu
Date: Wed, 25 Sep 2024 15:59:29 -0700
Subject: [PATCH 1/4] [lldb][DWARF] Replace lldb's DWARFDebugArangeSet with
llvm's
@@ -73,6 +73,12 @@ class DWARFDebugArangeSet {
return desc_iterator_range(ArangeDescriptors.begin(),
ArangeDescriptors.end());
}
+
+ size_t getDescriptorsSize() const { return ArangeDescriptors.size(); }
+
+ const Descriptor &getDescriptio
@@ -132,34 +134,33 @@ TEST_F(SymbolFileDWARFTests,
ParseArangesWithMultipleTerminators) {
// Set the big endian length correctly.
const offset_t binary_data_size = sizeof(binary_data);
binary_data[3] = (uint8_t)binary_data_size - 4;
- DWARFDataExtractor data;
- data.Se
https://github.com/DavidSpickett approved this pull request.
LGTM.
Maybe @labath would like to take a last look at it before it lands.
https://github.com/llvm/llvm-project/pull/95986
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://li
@@ -536,6 +536,33 @@ This command will run the thread in the current frame
until it reaches line 100
in this frame or stops if it leaves the current frame. This is a pretty close
equivalent to GDB's ``until`` command.
+One other useful thing to note about the lldb stepping co
Author: jimingham
Date: 2024-09-27T09:36:52-07:00
New Revision: a4197e472823f51075c837f709da05a55ebc16d0
URL:
https://github.com/llvm/llvm-project/commit/a4197e472823f51075c837f709da05a55ebc16d0
DIFF:
https://github.com/llvm/llvm-project/commit/a4197e472823f51075c837f709da05a55ebc16d0.diff
LOG
Jlalond wrote:
> Seems reasonable, but you'll need to use the signal constants from
> `UnixSignals` (looked up by string), as macros like `SIGBUS` might not exist
> (windows) or might not have the right value (macos). (NativeThreadLinux can
> get away with using them as it always runs on the h
@@ -686,16 +692,10 @@ Status MinidumpFileBuilder::AddExceptions() {
for (const ThreadSP &thread_sp : thread_list) {
StopInfoSP stop_info_sp = thread_sp->GetStopInfo();
bool add_exception = false;
-if (stop_info_sp) {
- switch (stop_info_sp->GetStopReason()) {
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/108448
>From adcc5e8065d2a1b7edf877bd74de9cebd2f84cc9 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Thu, 12 Sep 2024 13:10:58 -0700
Subject: [PATCH 1/4] Create set for the stop reasons we collect, and add
breakpo
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/108448
>From adcc5e8065d2a1b7edf877bd74de9cebd2f84cc9 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Thu, 12 Sep 2024 13:10:58 -0700
Subject: [PATCH 1/5] Create set for the stop reasons we collect, and add
breakpo
https://github.com/labath approved this pull request.
The setting might be useful as well, though I think it would be even better if
this was settable on a per-invocation basis (an argument to HandleCommand or
something) -- the reason being that someone might still want to have this
feature fo
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/106470
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -592,7 +592,18 @@ lldb::DWIMPrintVerbosity Debugger::GetDWIMPrintVerbosity()
const {
const uint32_t idx = ePropertyDWIMPrintVerbosity;
return GetPropertyAtIndexAs(
idx, static_cast(
- g_debugger_properties[idx].default_uint_value));
+ g
https://github.com/felipepiovezan edited
https://github.com/llvm/llvm-project/pull/110167
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jimingham wrote:
This is a slightly orthogonal point, but I don't think we should confine this
error visualization to just expressions. If the user passes a non-boolean
string to an option in a command, it would be helpful to point at the option
for them, much as pointing to the part of the e
https://github.com/felipepiovezan edited
https://github.com/llvm/llvm-project/pull/110167
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -536,6 +536,33 @@ This command will run the thread in the current frame
until it reaches line 100
in this frame or stops if it leaves the current frame. This is a pretty close
equivalent to GDB's ``until`` command.
+One other useful thing to note about the lldb stepping co
@@ -536,6 +536,33 @@ This command will run the thread in the current frame
until it reaches line 100
in this frame or stops if it leaves the current frame. This is a pretty close
equivalent to GDB's ``until`` command.
+One other useful thing to note about the lldb stepping co
https://github.com/felipepiovezan edited
https://github.com/llvm/llvm-project/pull/110167
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -536,6 +536,33 @@ This command will run the thread in the current frame
until it reaches line 100
in this frame or stops if it leaves the current frame. This is a pretty close
equivalent to GDB's ``until`` command.
+One other useful thing to note about the lldb stepping co
https://github.com/felipepiovezan approved this pull request.
LGTM! I learned something new reading this!
https://github.com/llvm/llvm-project/pull/110167
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/
https://github.com/felipepiovezan edited
https://github.com/llvm/llvm-project/pull/110167
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan edited
https://github.com/llvm/llvm-project/pull/110167
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -301,7 +301,8 @@ using Entry = llvm::DWARFDebugNames::Entry;
/// If any parent does not have an `IDX_parent`, or the Entry data is
corrupted,
/// nullopt is returned.
std::optional>
-getParentChain(Entry entry, uint32_t max_parents) {
+getParentChain(Entry entry,
+
labath wrote:
> This is a stack PR from #108907, so please review the new namespaces lookup
> changes and ignore the changes in #108907. Let me know if there is a way to
> only show the delta changes (not merged view).
That should be possible if you arrange the PR to only contain two commits,
Jlalond wrote:
> So does this not need new testing or did you not add that yet?
>
> I'm not clear on what fully decode means because at least for certain signals
> like a tag check fault we do have a description for live processes and core
> files. Perhaps that's because I added those as speci
@@ -536,6 +536,33 @@ This command will run the thread in the current frame
until it reaches line 100
in this frame or stops if it leaves the current frame. This is a pretty close
equivalent to GDB's ``until`` command.
+One other useful thing to note about the lldb stepping co
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/106442
>From a2728d10df151c2fd552c988827d27155b9e7055 Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Wed, 28 Aug 2024 10:04:33 -0700
Subject: [PATCH] [lldb] Store expression evaluator diagnostics in an
llvm:
Author: David Spickett
Date: 2024-09-27T13:31:58+01:00
New Revision: f6e771cfeda5527b817c80e86d2352cf1f3e5e37
URL:
https://github.com/llvm/llvm-project/commit/f6e771cfeda5527b817c80e86d2352cf1f3e5e37
DIFF:
https://github.com/llvm/llvm-project/commit/f6e771cfeda5527b817c80e86d2352cf1f3e5e37.diff
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/106470
>From 4f57669afd3d9e7475c0e44976eaa9b534883152 Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Wed, 28 Aug 2024 16:19:21 -0700
Subject: [PATCH] [lldb] Inline expression evaluator error visualization
MIM
Author: Adrian Prantl
Date: 2024-09-27T16:32:35-07:00
New Revision: 49372d1cccf50f404d52d40ae4b663db5604eb2c
URL:
https://github.com/llvm/llvm-project/commit/49372d1cccf50f404d52d40ae4b663db5604eb2c
DIFF:
https://github.com/llvm/llvm-project/commit/49372d1cccf50f404d52d40ae4b663db5604eb2c.diff
https://github.com/adrian-prantl closed
https://github.com/llvm/llvm-project/pull/106470
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Adrian Prantl
Date: 2024-09-27T16:51:24-07:00
New Revision: 8536d483d72119f9556a9d685c32d5fca0c3d9c1
URL:
https://github.com/llvm/llvm-project/commit/8536d483d72119f9556a9d685c32d5fca0c3d9c1
DIFF:
https://github.com/llvm/llvm-project/commit/8536d483d72119f9556a9d685c32d5fca0c3d9c1.diff
Author: Adrian Prantl
Date: 2024-09-27T17:05:37-07:00
New Revision: 2ddcc4e6b212bf91459689c40049ddedf360a448
URL:
https://github.com/llvm/llvm-project/commit/2ddcc4e6b212bf91459689c40049ddedf360a448
DIFF:
https://github.com/llvm/llvm-project/commit/2ddcc4e6b212bf91459689c40049ddedf360a448.diff
Author: Adrian Prantl
Date: 2024-09-27T17:05:37-07:00
New Revision: 41dca012e5d6a1f8dff640ec82245bb5152e9fb8
URL:
https://github.com/llvm/llvm-project/commit/41dca012e5d6a1f8dff640ec82245bb5152e9fb8
DIFF:
https://github.com/llvm/llvm-project/commit/41dca012e5d6a1f8dff640ec82245bb5152e9fb8.diff
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/106442
>From ab88865f07bcb711ed911ca16e8310f2e13220f6 Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Wed, 28 Aug 2024 10:04:33 -0700
Subject: [PATCH] [lldb] Store expression evaluator diagnostics in an
llvm:
Author: Adrian Prantl
Date: 2024-09-27T16:09:52-07:00
New Revision: 84fdfb9ca63ee4304b486d7e85545ee4e1a46f5d
URL:
https://github.com/llvm/llvm-project/commit/84fdfb9ca63ee4304b486d7e85545ee4e1a46f5d
DIFF:
https://github.com/llvm/llvm-project/commit/84fdfb9ca63ee4304b486d7e85545ee4e1a46f5d.diff
https://github.com/adrian-prantl closed
https://github.com/llvm/llvm-project/pull/106442
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `lldb-x86_64-debian`
running on `lldb-x86_64-debian` while building `lldb` at step 6 "test".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/162/builds/7343
Here is the relevant piece of the build log
Author: Adrian Prantl
Date: 2024-09-27T18:09:52-07:00
New Revision: d33fa70dddcb29d5fd85188e119f034e585f
URL:
https://github.com/llvm/llvm-project/commit/d33fa70dddcb29d5fd85188e119f034e585f
DIFF:
https://github.com/llvm/llvm-project/commit/d33fa70dddcb29d5fd85188e119f034e585f.diff
@@ -1887,7 +1887,8 @@ bool CommandInterpreter::HandleCommand(const char
*command_line,
CommandReturnObject &result,
bool force_repeat_command) {
std::string command_string(command_line);
- std::st
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/106470
>From a2728d10df151c2fd552c988827d27155b9e7055 Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Wed, 28 Aug 2024 10:04:33 -0700
Subject: [PATCH 1/2] [lldb] Store expression evaluator diagnostics in an
l
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `lldb-arm-ubuntu` running
on `linaro-lldb-arm-ubuntu` while building `lldb` at step 6 "test".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/18/builds/4599
Here is the relevant piece of the build log
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `lldb-aarch64-ubuntu`
running on `linaro-lldb-aarch64-ubuntu` while building `lldb` at step 6 "test".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/59/builds/5739
Here is the relevant piece of the bu
57 matches
Mail list logo
