[Lldb-commits] [lldb] [lldb] Change the implementation of Status to store an llvm::Error (NFC) (PR #106774)

2024-09-18 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/106774 >From 34a856d47322cd35a7b568a335adbcd804f2302d Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Wed, 11 Sep 2024 10:35:37 +0200 Subject: [PATCH 1/2] [lldb] Only send "posix" error codes through the gdb-r

[Lldb-commits] [lldb] [lldb/Interpreter] Add requirements to Scripted Interface abstract methods (PR #109063)

2024-09-18 Thread Alex Langford via lldb-commits
@@ -78,8 +100,11 @@ class ScriptedPythonInterface : virtual public ScriptedInterface { using namespace python; using Locker = ScriptInterpreterPythonImpl::Locker; -auto create_error = [](std::string message) { - return llvm::createStringError(llvm::inconverti

[Lldb-commits] [lldb] [lldb-dap] Implement value locations for function pointers (PR #104589)

2024-09-18 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/104589 >From 79684ccb2b6312b0938de73641e89d7cd29ce1a8 Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Mon, 12 Aug 2024 14:53:31 + Subject: [PATCH 1/3] [lldb-dap] Implement value locations for function

[Lldb-commits] [lldb] [lldb-dap] Implement value locations for function pointers (PR #104589)

2024-09-18 Thread Adrian Vogelsgesang via lldb-commits
@@ -1198,6 +1198,26 @@ std::string VariableDescription::GetResult(llvm::StringRef context) { return description.trim().str(); } +bool HasValueLocation(lldb::SBValue v) { + if (!v.GetType().IsPointerType() && !v.GetType().IsReferenceType()) { +return false; + } ---

[Lldb-commits] [lldb] Add docs and an example use of the scripted command get_flags API. (PR #109176)

2024-09-18 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang approved this pull request. https://github.com/llvm/llvm-project/pull/109176 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] c86b1b0 - [lldb] Add handling of ECError to unit test to validate a hypothesis on the bots

2024-09-18 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2024-09-18T16:39:22-07:00 New Revision: c86b1b0f44509585390c8df09b41d707e6a14011 URL: https://github.com/llvm/llvm-project/commit/c86b1b0f44509585390c8df09b41d707e6a14011 DIFF: https://github.com/llvm/llvm-project/commit/c86b1b0f44509585390c8df09b41d707e6a14011.diff

[Lldb-commits] [libcxx] [lldb] [lldb][libc++] Hide all libc++ implementation details from stacktraces (PR #108870)

2024-09-18 Thread Adrian Vogelsgesang via lldb-commits
vogelsgesang wrote: > What I could imagine is to drive this via attributes instead of a heuristic. > We could potentially mark implementation details of libc++ as such to control > what the debugging experience is like at a much finer grain if we used > attributes, but obviously this would als

[Lldb-commits] [lldb] [lldb] [debugserver] Use "full" x86_64 GPR state when available. (PR #108663)

2024-09-18 Thread Brendan Shanks via lldb-commits
mrpippy wrote: Great, no I don't think I have permissions to merge. I pushed a new version that fixed a typo in the `GetGPRState` log call, and in `SetGPRState` adds the new fields to the log call. https://github.com/llvm/llvm-project/pull/108663 ___

[Lldb-commits] [lldb] cf02d8b - [lldb] Store ECError as CloneableECError in Status

2024-09-18 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2024-09-18T16:23:29-07:00 New Revision: cf02d8bbb6dfed17081fbdbf44e2071aea1af728 URL: https://github.com/llvm/llvm-project/commit/cf02d8bbb6dfed17081fbdbf44e2071aea1af728 DIFF: https://github.com/llvm/llvm-project/commit/cf02d8bbb6dfed17081fbdbf44e2071aea1af728.diff

[Lldb-commits] [lldb] [lldb] Add support for disabling frame recognizers (PR #109219)

2024-09-18 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang created https://github.com/llvm/llvm-project/pull/109219 Sometimes you only want to temporarily disable a frame recognizer instead of deleting it. In particular, when dealing with one of the builtin frame recognizers, which cannot be restored after deletion. >F

[Lldb-commits] [lldb] [lldb] Add support for disabling frame recognizers (PR #109219)

2024-09-18 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff e0ad34e56590fa2e6ffdf617e044de7eadee2139 c471c2fe615082fb9f9c5f39466bd47ec5b86bb0 --e

[Lldb-commits] [libcxx] [lldb] [lldb][libc++] Hide all libc++ implementation details from stacktraces (PR #108870)

2024-09-18 Thread Adrian Vogelsgesang via lldb-commits
vogelsgesang wrote: > We really should add a "disable" to the frame recognizers Do you mean something like #109219? (Test cases still missing; rest should be ready for review) > Seems to me like this feature should be tuned to "users of libc++" not > "developers of libc++". Agree, I think th

[Lldb-commits] [lldb] Improve type and namespace lookup using parent chain (PR #108907)

2024-09-18 Thread via lldb-commits
jeffreytan81 wrote: Ping, anyone wants to review this? Thanks https://github.com/llvm/llvm-project/pull/108907 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 05a292c - Revert "[lldb] Add handling of ECError to unit test to validate a hypothesis on the bots"

2024-09-18 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2024-09-18T17:28:09-07:00 New Revision: 05a292caa57de13a6d0bc25dee2be25c2a0dcee3 URL: https://github.com/llvm/llvm-project/commit/05a292caa57de13a6d0bc25dee2be25c2a0dcee3 DIFF: https://github.com/llvm/llvm-project/commit/05a292caa57de13a6d0bc25dee2be25c2a0dcee3.diff

[Lldb-commits] [lldb] 79a69cb - Revert "[lldb] Store ECError as CloneableECError in Status"

2024-09-18 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2024-09-18T17:28:09-07:00 New Revision: 79a69cb06665859658677b9ade4a1a262490f8c1 URL: https://github.com/llvm/llvm-project/commit/79a69cb06665859658677b9ade4a1a262490f8c1 DIFF: https://github.com/llvm/llvm-project/commit/79a69cb06665859658677b9ade4a1a262490f8c1.diff

[Lldb-commits] [lldb] 2730373 - Revert "Add noexcept qualifier to placate g++"

2024-09-18 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2024-09-18T17:28:09-07:00 New Revision: 27303736512c32bb87b67a4ecf0b17881a8811c6 URL: https://github.com/llvm/llvm-project/commit/27303736512c32bb87b67a4ecf0b17881a8811c6 DIFF: https://github.com/llvm/llvm-project/commit/27303736512c32bb87b67a4ecf0b17881a8811c6.diff

[Lldb-commits] [lldb] 8b456b4 - Revert "[lldb] Update SocketTestUtilities.cpp to use CloneableECError"

2024-09-18 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2024-09-18T17:28:09-07:00 New Revision: 8b456b436f996b4c6dfee0abc704b9219d43f7d2 URL: https://github.com/llvm/llvm-project/commit/8b456b436f996b4c6dfee0abc704b9219d43f7d2 DIFF: https://github.com/llvm/llvm-project/commit/8b456b436f996b4c6dfee0abc704b9219d43f7d2.diff

[Lldb-commits] [lldb] cb6d531 - Revert "[lldb] Change the implementation of Status to store an llvm::Error (NFC) (#106774)"

2024-09-18 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2024-09-18T17:28:10-07:00 New Revision: cb6d53198e39838ba6f9d2974c4f4317057d1556 URL: https://github.com/llvm/llvm-project/commit/cb6d53198e39838ba6f9d2974c4f4317057d1556 DIFF: https://github.com/llvm/llvm-project/commit/cb6d53198e39838ba6f9d2974c4f4317057d1556.diff

[Lldb-commits] [lldb] 6dcde73 - Revert "[lldb] Only send "posix" error codes through the gdb-remote protocol"

2024-09-18 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2024-09-18T17:28:10-07:00 New Revision: 6dcde731eb13aeaa8296504ad8178d62c8ecd3eb URL: https://github.com/llvm/llvm-project/commit/6dcde731eb13aeaa8296504ad8178d62c8ecd3eb DIFF: https://github.com/llvm/llvm-project/commit/6dcde731eb13aeaa8296504ad8178d62c8ecd3eb.diff

[Lldb-commits] [lldb] [lldb] Change the implementation of Status to store an llvm::Error (NFC) (PR #106774)

2024-09-18 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: So I _thought_ I had understood this because I had simulated the missing ip6 support on the bots inside of Socked::CreateSocket, but I still had failing unit tests at the end of the day so I reverted this again for now. https://github.com/llvm/llvm-project/pull/106774

[Lldb-commits] [lldb] [lldb][FrameRecognizer] Display the first non-std frame on verbose_trap (PR #108825)

2024-09-18 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/108825 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Store expression evaluator diagnostics in an llvm::Error (NFC) (PR #106442)

2024-09-18 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/106442 >From 8a2af995f80cc518f4776c2236a86d0ca32abe03 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Wed, 28 Aug 2024 10:04:33 -0700 Subject: [PATCH] [lldb] Store expression evaluator diagnostics in an llvm:

[Lldb-commits] [lldb] [lldb] Change the implementation of Status to store an llvm::Error (NFC) (PR #106774)

2024-09-18 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-aarch64-ubuntu` running on `linaro-lldb-aarch64-ubuntu` while building `lldb` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/59/builds/5164 Here is the relevant piece of the bu

[Lldb-commits] [lldb] [lldb] Store expression evaluator diagnostics in an llvm::Error (NFC) (PR #106442)

2024-09-18 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/106442 >From 40d336f5ffcbf36346eb017f65c0c150fc7190d2 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Wed, 28 Aug 2024 10:04:33 -0700 Subject: [PATCH] [lldb] Store expression evaluator diagnostics in an llvm:

[Lldb-commits] [lldb] [lldb] Store expression evaluator diagnostics in an llvm::Error (NFC) (PR #106442)

2024-09-18 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/106442 >From a857ea027be6dbdc06d2834b65906a356b2a4128 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Wed, 28 Aug 2024 10:04:33 -0700 Subject: [PATCH] [lldb] Store expression evaluator diagnostics in an llvm:

[Lldb-commits] [lldb] [lldb] [debugserver] Use "full" x86_64 GPR state when available. (PR #108663)

2024-09-18 Thread Brendan Shanks via lldb-commits
https://github.com/mrpippy updated https://github.com/llvm/llvm-project/pull/108663 >From a9b19cbd20083e2b1d6c8de342206cb0ec6183b7 Mon Sep 17 00:00:00 2001 From: Brendan Shanks Date: Thu, 12 Sep 2024 16:01:30 -0700 Subject: [PATCH] [lldb] [debugserver] Use "full" x86_64 GPR state when availabl

[Lldb-commits] [lldb] 2383bc8 - [lldb] Update SocketTestUtilities.cpp to use CloneableECError

2024-09-18 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2024-09-18T15:54:24-07:00 New Revision: 2383bc8216bd7d373bb48337199c09d40922adf2 URL: https://github.com/llvm/llvm-project/commit/2383bc8216bd7d373bb48337199c09d40922adf2 DIFF: https://github.com/llvm/llvm-project/commit/2383bc8216bd7d373bb48337199c09d40922adf2.diff

[Lldb-commits] [lldb] [lldb/Interpreter] Add requirements to Scripted Interface abstract methods (PR #109063)

2024-09-18 Thread Med Ismail Bennani via lldb-commits
@@ -78,8 +100,11 @@ class ScriptedPythonInterface : virtual public ScriptedInterface { using namespace python; using Locker = ScriptInterpreterPythonImpl::Locker; -auto create_error = [](std::string message) { - return llvm::createStringError(llvm::inconverti

[Lldb-commits] [lldb] [lldb] Change the implementation of Status to store an llvm::Error (NFC) (PR #106774)

2024-09-18 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/106774 >From 34a856d47322cd35a7b568a335adbcd804f2302d Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Wed, 11 Sep 2024 10:35:37 +0200 Subject: [PATCH 1/2] [lldb] Only send "posix" error codes through the gdb-r

[Lldb-commits] [lldb] [lldb] Change the implementation of Status to store an llvm::Error (NFC) (PR #106774)

2024-09-18 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: > Actually, the CI failure appears to be relevant. The error path in the test > is `errno->std::error_code->Status->Expected` and the code in > `CheckIPSupport` expects to get a `llvm::ECError`. It looks like it gets a > different type now, and I think that's probably fine

[Lldb-commits] [lldb] Add docs and an example use of the scripted command get_flags API. (PR #109176)

2024-09-18 Thread via lldb-commits
https://github.com/jimingham created https://github.com/llvm/llvm-project/pull/109176 The API is present, and we even have a test for it, but it isn't documented so no one probably knows you can set requirements for your scripted commands. This just adds docs and uses it appropriately in the

[Lldb-commits] [lldb] Add docs and an example use of the scripted command get_flags API. (PR #109176)

2024-09-18 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (jimingham) Changes The API is present, and we even have a test for it, but it isn't documented so no one probably knows you can set requirements for your scripted commands. This just adds docs and uses it appropriately in the `frame

[Lldb-commits] [lldb] [lldb] Change the implementation of Status to store an llvm::Error (NFC) (PR #106774)

2024-09-18 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/106774 >From 34a856d47322cd35a7b568a335adbcd804f2302d Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Wed, 11 Sep 2024 10:35:37 +0200 Subject: [PATCH 1/2] [lldb] Only send "posix" error codes through the gdb-r

[Lldb-commits] [lldb] [lldb] Change the implementation of Status to store an llvm::Error (NFC) (PR #106774)

2024-09-18 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/106774 >From 6d240b3254192763f0b67b70ed36616dfcf9e565 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Wed, 4 Sep 2024 12:50:37 -0700 Subject: [PATCH] [lldb] Change the implementation of Status to store an llv

[Lldb-commits] [lldb] a7c1745 - [lldb] Only send "posix" error codes through the gdb-remote protocol

2024-09-18 Thread Adrian Prantl via lldb-commits
Author: Pavel Labath Date: 2024-09-18T14:53:42-07:00 New Revision: a7c174502aef45b2d33291129cce10c085fef944 URL: https://github.com/llvm/llvm-project/commit/a7c174502aef45b2d33291129cce10c085fef944 DIFF: https://github.com/llvm/llvm-project/commit/a7c174502aef45b2d33291129cce10c085fef944.diff

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

2024-09-18 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: > As for lldb, maybe it can be useful to obtain features flags from `ArchSpec`, > but I think this should be done in a separate PR, if you don't mind. Yes, agree with doing this separately so we can get this PR landed. https://github.com/llvm/llvm-project/pull/99336 ___

[Lldb-commits] [lldb] [lldb] Change the implementation of Status to store an llvm::Error (NFC) (PR #106774)

2024-09-18 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/106774 >From 34a856d47322cd35a7b568a335adbcd804f2302d Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Wed, 11 Sep 2024 10:35:37 +0200 Subject: [PATCH 1/2] [lldb] Only send "posix" error codes through the gdb-r

[Lldb-commits] [lldb] 06939fa - [lldb] Change the implementation of Status to store an llvm::Error (NFC) (#106774)

2024-09-18 Thread via lldb-commits
Author: Adrian Prantl Date: 2024-09-18T14:54:49-07:00 New Revision: 06939fa2e140a171132275ec0ea1857d20c5dbdd URL: https://github.com/llvm/llvm-project/commit/06939fa2e140a171132275ec0ea1857d20c5dbdd DIFF: https://github.com/llvm/llvm-project/commit/06939fa2e140a171132275ec0ea1857d20c5dbdd.diff

[Lldb-commits] [lldb] [lldb] Change the implementation of Status to store an llvm::Error (NFC) (PR #106774)

2024-09-18 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl closed https://github.com/llvm/llvm-project/pull/106774 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

2024-09-18 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda approved this pull request. I don't feel like I am an authoritative owner of the parts being modified by this PR, but I am fine with this fwiw. https://github.com/llvm/llvm-project/pull/99336 ___ lldb-commits mailing li

[Lldb-commits] [lldb] [lldb] Change the implementation of Status to store an llvm::Error (NFC) (PR #106774)

2024-09-18 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `cross-project-tests-sie-ubuntu-dwarf5` running on `doug-worker-1b` while building `lldb` at step 5 "build-unified-tree". Full details are available at: https://lab.llvm.org/buildbot/#/builders/163/builds/5687 Here is the re

[Lldb-commits] [lldb] [lldb] Change the implementation of Status to store an llvm::Error (NFC) (PR #106774)

2024-09-18 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `cross-project-tests-sie-ubuntu` running on `doug-worker-1a` while building `lldb` at step 5 "build-unified-tree". Full details are available at: https://lab.llvm.org/buildbot/#/builders/181/builds/5479 Here is the relevant

[Lldb-commits] [lldb] [lldb] Store expression evaluator diagnostics in an llvm::Error (NFC) (PR #106442)

2024-09-18 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/106442 >From 334ef4edf74541e4c67b24c7078a90c939692122 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Wed, 4 Sep 2024 12:50:37 -0700 Subject: [PATCH] [lldb] Change the implementation of Status to store an llv

[Lldb-commits] [lldb] b4a8e87 - Add noexcept qualifier to placate g++

2024-09-18 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2024-09-18T15:03:41-07:00 New Revision: b4a8e877ee3002a8cfd613f7950afcbe1d98821c URL: https://github.com/llvm/llvm-project/commit/b4a8e877ee3002a8cfd613f7950afcbe1d98821c DIFF: https://github.com/llvm/llvm-project/commit/b4a8e877ee3002a8cfd613f7950afcbe1d98821c.diff

[Lldb-commits] [lldb] 615bd9e - Add docs and an example use of the scripted command get_flags API. (#109176)

2024-09-18 Thread via lldb-commits
Author: jimingham Date: 2024-09-18T18:10:43-07:00 New Revision: 615bd9ee60ca213d0e93a7ddc5c1bf48418952e9 URL: https://github.com/llvm/llvm-project/commit/615bd9ee60ca213d0e93a7ddc5c1bf48418952e9 DIFF: https://github.com/llvm/llvm-project/commit/615bd9ee60ca213d0e93a7ddc5c1bf48418952e9.diff LOG

[Lldb-commits] [lldb] Add docs and an example use of the scripted command get_flags API. (PR #109176)

2024-09-18 Thread via lldb-commits
https://github.com/jimingham closed https://github.com/llvm/llvm-project/pull/109176 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add docs and an example use of the scripted command get_flags API. (PR #109176)

2024-09-18 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben commented: LGTM! https://github.com/llvm/llvm-project/pull/109176 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Implement value locations for function pointers (PR #104589)

2024-09-18 Thread Greg Clayton via lldb-commits
https://github.com/clayborg commented: My only question here is do we really want to do an address resolution for any pointer or reference or can we limit that for only function pointers? I worry a bit about the extra cost for any variable view that has tons of pointers or references as this w

[Lldb-commits] [lldb] [lldb-dap] Implement value locations for function pointers (PR #104589)

2024-09-18 Thread Greg Clayton via lldb-commits
https://github.com/clayborg edited https://github.com/llvm/llvm-project/pull/104589 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Implement value locations for function pointers (PR #104589)

2024-09-18 Thread Greg Clayton via lldb-commits
@@ -1198,6 +1198,26 @@ std::string VariableDescription::GetResult(llvm::StringRef context) { return description.trim().str(); } +bool HasValueLocation(lldb::SBValue v) { + if (!v.GetType().IsPointerType() && !v.GetType().IsReferenceType()) { +return false; + } ---

[Lldb-commits] [lldb] [lldb-dap] Implement value locations for function pointers (PR #104589)

2024-09-18 Thread Greg Clayton via lldb-commits
@@ -0,0 +1,11 @@ +#include + +void greet() { printf("Hello"); } + +int main(void) { + int var1 = 1; + void (*func_ptr)() = &greet; + void (&func_ref)() = greet; + __builtin_printf("break here"); clayborg wrote: We don't need the printf here right? Just put a

[Lldb-commits] [lldb] [lldb] Always emit diagnostic events to the system log (PR #90913)

2024-09-18 Thread Igor Kudrin via lldb-commits
igorkudrin wrote: Hi @JDevlieghere, This change causes diagnostic messages to be duplicated on Windows. For example: ``` > yaml2obj.exe lldb\test\Shell\ObjectFile\ELF\minidebuginfo-no-lzma.yaml -o > t.obj > lldb-new.exe (lldb) target create t.obj (x86_64) C:\tmp\t.obj No LZMA support found for

[Lldb-commits] [lldb] 620738e - [lldb-dap][test] Fix `readMemory` test (#109057)

2024-09-18 Thread via lldb-commits
Author: Adrian Vogelsgesang Date: 2024-09-18T16:16:31+02:00 New Revision: 620738e66260f00f08808b3e676a697fc32db92e URL: https://github.com/llvm/llvm-project/commit/620738e66260f00f08808b3e676a697fc32db92e DIFF: https://github.com/llvm/llvm-project/commit/620738e66260f00f08808b3e676a697fc32db92e

[Lldb-commits] [lldb] [lldb-dap][test] Fix `readMemory` test (PR #109057)

2024-09-18 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang closed https://github.com/llvm/llvm-project/pull/109057 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Implement value locations for function pointers (PR #104589)

2024-09-18 Thread Adrian Vogelsgesang via lldb-commits
@@ -1611,16 +1624,17 @@ void request_evaluate(const llvm::json::Object &request) { VariableDescription desc(value); EmplaceSafeString(body, "result", desc.GetResult(context)); EmplaceSafeString(body, "type", desc.display_type_name); - if (value.MightHave

[Lldb-commits] [lldb] [lldb-dap] Implement value locations for function pointers (PR #104589)

2024-09-18 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/104589 >From 79684ccb2b6312b0938de73641e89d7cd29ce1a8 Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Mon, 12 Aug 2024 14:53:31 + Subject: [PATCH 1/2] [lldb-dap] Implement value locations for function

[Lldb-commits] [lldb] [lldb] add a check using an MD5 hash for whether a file needs to be installed on the remote target (PR #108996)

2024-09-18 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 0f97b4824a8cf040bd3ce7b644dee9d60065ac61 5161bbab487703278a53bda03e705c5408c80cd8 --e

[Lldb-commits] [lldb] Add warning message to `session save` when transcript isn't saved. (PR #109020)

2024-09-18 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben requested changes to this pull request. https://github.com/llvm/llvm-project/pull/109020 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add warning message to `session save` when transcript isn't saved. (PR #109020)

2024-09-18 Thread Med Ismail Bennani via lldb-commits
@@ -3306,6 +3306,8 @@ bool CommandInterpreter::SaveTranscript( result.SetStatus(eReturnStatusSuccessFinishNoResult); result.AppendMessageWithFormat("Session's transcripts saved to %s\n", output_file->c_str()); + if (!GetSaveTranscript()) +

[Lldb-commits] [lldb] Add warning message to `session save` when transcript isn't saved. (PR #109020)

2024-09-18 Thread Med Ismail Bennani via lldb-commits
medismailben wrote: > Maybe `interpreter.save-transcript` could be true by default as well. Any > feedback welcome. Although that could be useful but I'm concerned of the performance aspect of it. Not everyone cares to save transcripts so I'm not sure it should be on by default. I like this p

[Lldb-commits] [lldb] [lldb-dap][test] Fix `readMemory` test (PR #109057)

2024-09-18 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. Assuming all read memory requests are generated from variables, this makes sense. They wouldn't be split across regions. https://github.com/llvm/llvm-project/pull/109057 ___ lldb-commits mai

[Lldb-commits] [lldb] [lldb] [debugserver] Use "full" x86_64 GPR state when available. (PR #108663)

2024-09-18 Thread via lldb-commits
github-actions[bot] wrote: @mrpippy Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a build,

[Lldb-commits] [lldb] [lldb] add a check using an MD5 hash for whether a file needs to be installed on the remote target (PR #108996)

2024-09-18 Thread via lldb-commits
https://github.com/dlav-sc updated https://github.com/llvm/llvm-project/pull/108996 >From 5161bbab487703278a53bda03e705c5408c80cd8 Mon Sep 17 00:00:00 2001 From: Daniil Avdeev Date: Tue, 23 Jul 2024 11:08:13 + Subject: [PATCH 1/2] [lldb] refactor Target::Install function --- lldb/source/T

[Lldb-commits] [lldb] 9690b30 - [LLDB] Fix operators <= and >= returning a wrong result when comparing to a floating point NaN (#108060)

2024-09-18 Thread via lldb-commits
Author: Ilia Kuklin Date: 2024-09-18T17:50:09+05:00 New Revision: 9690b30ba9acc3deb1068deb37f3b507826b27fe URL: https://github.com/llvm/llvm-project/commit/9690b30ba9acc3deb1068deb37f3b507826b27fe DIFF: https://github.com/llvm/llvm-project/commit/9690b30ba9acc3deb1068deb37f3b507826b27fe.diff L

[Lldb-commits] [lldb] [LLDB] Fix operators <= and >= returning a wrong result when comparing to a floating point NaN (PR #108060)

2024-09-18 Thread Ilia Kuklin via lldb-commits
https://github.com/kuilpd closed https://github.com/llvm/llvm-project/pull/108060 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] add a check using an MD5 hash for whether a file needs to be installed on the remote target (PR #108996)

2024-09-18 Thread via lldb-commits
dlav-sc wrote: > I'm surprised that #88812 did not also fix this. Perhaps putfile and install > are different code paths. Nope, I simply didn't have this commit, my bad. Maybe we can consider this PR as the refactoring one, if you don't mind. https://github.com/llvm/llvm-project/pull/108996 _

[Lldb-commits] [lldb] [lldb] [debugserver] Use "full" x86_64 GPR state when available. (PR #108663)

2024-09-18 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda closed https://github.com/llvm/llvm-project/pull/108663 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/Interpreter] Add requirements to Scripted Interface abstract methods (PR #109063)

2024-09-18 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben updated https://github.com/llvm/llvm-project/pull/109063 >From e815d5f65a23987d0f27849346610c1770094b6f Mon Sep 17 00:00:00 2001 From: Med Ismail Bennani Date: Wed, 18 Sep 2024 23:09:35 -0700 Subject: [PATCH] [lldb/Interpreter] Add requirements to Scripted Interf

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

2024-09-18 Thread via lldb-commits
dlav-sc wrote: > That code doesn't look right. Yeah, it looks really suspicious. > Shouldn't it be using eRISCV_float_abi_mask. I think you are right. https://github.com/llvm/llvm-project/pull/99336 ___ lldb-commits mailing list lldb-commits@lists.

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

2024-09-18 Thread via lldb-commits
dlav-sc wrote: > I expect these will be at risk of diverging if done separately Your concern is reasonable, I see this stuff in two places: `DisassemblerLLVMC::DisassemblerLLVMC` and `GetValObjFromFPRegs` in `ABISysV_riscv.cpp` (also `ObjectFileELF::GetSectionHeaderInfo` works with float flag

[Lldb-commits] [lldb] Add warning message to `session save` when transcript isn't saved. (PR #109020)

2024-09-18 Thread via lldb-commits
@@ -3306,6 +3306,8 @@ bool CommandInterpreter::SaveTranscript( result.SetStatus(eReturnStatusSuccessFinishNoResult); result.AppendMessageWithFormat("Session's transcripts saved to %s\n", output_file->c_str()); + if (!GetSaveTranscript()) +

[Lldb-commits] [lldb] Add warning message to `session save` when transcript isn't saved. (PR #109020)

2024-09-18 Thread via lldb-commits
https://github.com/jeffreytan81 approved this pull request. https://github.com/llvm/llvm-project/pull/109020 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] refactor Target::Install function (PR #108996)

2024-09-18 Thread via lldb-commits
https://github.com/dlav-sc edited https://github.com/llvm/llvm-project/pull/108996 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] refactor Target::Install function (PR #108996)

2024-09-18 Thread via lldb-commits
dlav-sc wrote: > Sure, please update the PR title and description to reflect that, then I'll > take a look. Thanks https://github.com/llvm/llvm-project/pull/108996 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[Lldb-commits] [lldb] [lldb] add a check using an MD5 hash for whether a file needs to be installed on the remote target (PR #108996)

2024-09-18 Thread via lldb-commits
https://github.com/dlav-sc updated https://github.com/llvm/llvm-project/pull/108996 >From 5161bbab487703278a53bda03e705c5408c80cd8 Mon Sep 17 00:00:00 2001 From: Daniil Avdeev Date: Tue, 23 Jul 2024 11:08:13 + Subject: [PATCH] [lldb] refactor Target::Install function --- lldb/source/Targe

[Lldb-commits] [lldb] [lldb] refactor Target::Install function (PR #108996)

2024-09-18 Thread via lldb-commits
https://github.com/dlav-sc edited https://github.com/llvm/llvm-project/pull/108996 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 7281e0c - [lldb] [debugserver] Use "full" x86_64 GPR state when available. (#108663)

2024-09-18 Thread via lldb-commits
Author: Brendan Shanks Date: 2024-09-18T22:57:01-07:00 New Revision: 7281e0cb3bbcce396aab8b3ea0967d7a17cd287a URL: https://github.com/llvm/llvm-project/commit/7281e0cb3bbcce396aab8b3ea0967d7a17cd287a DIFF: https://github.com/llvm/llvm-project/commit/7281e0cb3bbcce396aab8b3ea0967d7a17cd287a.diff