[Lldb-commits] [lldb] [AIX] 1. Avoid namespace collision on other platforms (PR #104679)

2024-08-18 Thread Dhruv Srivastava via lldb-commits
https://github.com/DhruvSrivastavaX closed https://github.com/llvm/llvm-project/pull/104679 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [AIX] 1. Avoid namespace collision on other platforms (PR #104679)

2024-08-18 Thread Dhruv Srivastava via lldb-commits
https://github.com/DhruvSrivastavaX reopened https://github.com/llvm/llvm-project/pull/104679 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] show dialog when executable is not found (PR #104711)

2024-08-18 Thread via lldb-commits
https://github.com/Da-Viper created https://github.com/llvm/llvm-project/pull/104711 Fixes #103043 >From 0b84d36d320a58a13ca98bd1b1c186c72bbe63e2 Mon Sep 17 00:00:00 2001 From: Ezike Ebuka Date: Sun, 18 Aug 2024 15:26:11 +0100 Subject: [PATCH] [lldb-dap] vscode now shows a dialog when the dab

[Lldb-commits] [lldb] [lldb-dap] show dialog when executable is not found (PR #104711)

2024-08-18 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (Da-Viper) Changes Fixes #103043 --- Full diff: https://github.com/llvm/llvm-project/pull/104711.diff 1 Files Affected: - (modified) lldb/tools/lldb-dap/src-ts/extension.ts (+26-3) ``diff diff --git a/lldb/tools/lldb-dap

[Lldb-commits] [lldb] Remove redundant symbol lookups in IRExecutionUnit::FindInSymbols (PR #102835)

2024-08-18 Thread Dmitrii Galimzianov via lldb-commits
https://github.com/DmT021 updated https://github.com/llvm/llvm-project/pull/102835 >From c0b9be1b4ef436bbf79bd3877a58e6b598b19940 Mon Sep 17 00:00:00 2001 From: Dmitrii Galimzianov Date: Sun, 18 Aug 2024 04:36:19 +0200 Subject: [PATCH 1/2] Remove redundant symbol lookups in IRExecutionUnit::Fi

[Lldb-commits] [lldb] Remove redundant symbol lookups in IRExecutionUnit::FindInSymbols (PR #102835)

2024-08-18 Thread Dmitrii Galimzianov via lldb-commits
https://github.com/DmT021 updated https://github.com/llvm/llvm-project/pull/102835 >From c0b9be1b4ef436bbf79bd3877a58e6b598b19940 Mon Sep 17 00:00:00 2001 From: Dmitrii Galimzianov Date: Sun, 18 Aug 2024 04:36:19 +0200 Subject: [PATCH 1/2] Remove redundant symbol lookups in IRExecutionUnit::Fi

[Lldb-commits] [lldb] Remove redundant symbol lookups in IRExecutionUnit::FindInSymbols (PR #102835)

2024-08-18 Thread Dmitrii Galimzianov via lldb-commits
https://github.com/DmT021 updated https://github.com/llvm/llvm-project/pull/102835 >From c0b9be1b4ef436bbf79bd3877a58e6b598b19940 Mon Sep 17 00:00:00 2001 From: Dmitrii Galimzianov Date: Sun, 18 Aug 2024 04:36:19 +0200 Subject: [PATCH 1/2] Remove redundant symbol lookups in IRExecutionUnit::Fi

[Lldb-commits] [lldb] Remove redundant symbol lookups in IRExecutionUnit::FindInSymbols (PR #102835)

2024-08-18 Thread Dmitrii Galimzianov via lldb-commits
https://github.com/DmT021 updated https://github.com/llvm/llvm-project/pull/102835 >From c0b9be1b4ef436bbf79bd3877a58e6b598b19940 Mon Sep 17 00:00:00 2001 From: Dmitrii Galimzianov Date: Sun, 18 Aug 2024 04:36:19 +0200 Subject: [PATCH 1/2] Remove redundant symbol lookups in IRExecutionUnit::Fi

[Lldb-commits] [lldb] Remove redundant symbol lookups in IRExecutionUnit::FindInSymbols (PR #102835)

2024-08-18 Thread Dmitrii Galimzianov via lldb-commits
https://github.com/DmT021 updated https://github.com/llvm/llvm-project/pull/102835 >From c0b9be1b4ef436bbf79bd3877a58e6b598b19940 Mon Sep 17 00:00:00 2001 From: Dmitrii Galimzianov Date: Sun, 18 Aug 2024 04:36:19 +0200 Subject: [PATCH 1/2] Remove redundant symbol lookups in IRExecutionUnit::Fi

[Lldb-commits] [lldb] [lldb-dap] show dialog when executable is not found (PR #104711)

2024-08-18 Thread Jonas Devlieghere via lldb-commits
@@ -17,10 +18,32 @@ function createDefaultLLDBDapOptions(): LLDBDapOptions { const path = vscode.workspace .getConfiguration("lldb-dap", session.workspaceFolder) .get("executable-path"); - if (path) { -return new vscode.DebugAdapterExecutable(

[Lldb-commits] [lldb] Remove redundant symbol lookups in IRExecutionUnit::FindInSymbols (PR #102835)

2024-08-18 Thread Dmitrii Galimzianov via lldb-commits
https://github.com/DmT021 updated https://github.com/llvm/llvm-project/pull/102835 >From c0b9be1b4ef436bbf79bd3877a58e6b598b19940 Mon Sep 17 00:00:00 2001 From: Dmitrii Galimzianov Date: Sun, 18 Aug 2024 04:36:19 +0200 Subject: [PATCH 1/2] Remove redundant symbol lookups in IRExecutionUnit::Fi

[Lldb-commits] [lldb] Remove redundant symbol lookups in IRExecutionUnit::FindInSymbols (PR #102835)

2024-08-18 Thread Dmitrii Galimzianov via lldb-commits
https://github.com/DmT021 updated https://github.com/llvm/llvm-project/pull/102835 >From c0b9be1b4ef436bbf79bd3877a58e6b598b19940 Mon Sep 17 00:00:00 2001 From: Dmitrii Galimzianov Date: Sun, 18 Aug 2024 04:36:19 +0200 Subject: [PATCH 1/2] Remove redundant symbol lookups in IRExecutionUnit::Fi

[Lldb-commits] [lldb] Remove redundant symbol lookups in IRExecutionUnit::FindInSymbols (PR #102835)

2024-08-18 Thread Dmitrii Galimzianov via lldb-commits
https://github.com/DmT021 updated https://github.com/llvm/llvm-project/pull/102835 >From c0b9be1b4ef436bbf79bd3877a58e6b598b19940 Mon Sep 17 00:00:00 2001 From: Dmitrii Galimzianov Date: Sun, 18 Aug 2024 04:36:19 +0200 Subject: [PATCH 1/2] Remove redundant symbol lookups in IRExecutionUnit::Fi

[Lldb-commits] [lldb] Remove redundant symbol lookups in IRExecutionUnit::FindInSymbols (PR #102835)

2024-08-18 Thread Dmitrii Galimzianov via lldb-commits
https://github.com/DmT021 updated https://github.com/llvm/llvm-project/pull/102835 >From c647b26ad534bb998063722f930ddd07162bfee7 Mon Sep 17 00:00:00 2001 From: Dmitrii Galimzianov Date: Sun, 18 Aug 2024 04:36:19 +0200 Subject: [PATCH] Remove redundant symbol lookups in IRExecutionUnit::FindIn

[Lldb-commits] [lldb] Remove redundant symbol lookups in IRExecutionUnit::FindInSymbols (PR #102835)

2024-08-18 Thread Dmitrii Galimzianov via lldb-commits
DmT021 wrote: On CI Linux builds some tests timed out. Probably deadlock, but I couldn't find where exactly. We now call an arbitrary function in Find* functions while the mutex is locked. I think LoadAddressResolver calls something that leads to deadlock. Although it's strange, because we use

[Lldb-commits] [lldb] [lldb-dap] show dialog when executable is not found (PR #104711)

2024-08-18 Thread via lldb-commits
https://github.com/Da-Viper updated https://github.com/llvm/llvm-project/pull/104711 >From 0b84d36d320a58a13ca98bd1b1c186c72bbe63e2 Mon Sep 17 00:00:00 2001 From: Ezike Ebuka Date: Sun, 18 Aug 2024 15:26:11 +0100 Subject: [PATCH 1/2] [lldb-dap] vscode now shows a dialog when the dab-executable

[Lldb-commits] [lldb] [lldb-dap] show dialog when executable is not found (PR #104711)

2024-08-18 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. I'm not a TS expert but functionally this is a great improvement. LGTM. https://github.com/llvm/llvm-project/pull/104711 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists

[Lldb-commits] [lldb] [LLDB] Add an assert to verify sign_bit_pos is within the valid range (NFC) (PR #95678)

2024-08-18 Thread Shivam Gupta via lldb-commits
https://github.com/xgupta closed https://github.com/llvm/llvm-project/pull/95678 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add an assert to verify sign_bit_pos is within the valid range (NFC) (PR #95678)

2024-08-18 Thread Shivam Gupta via lldb-commits
xgupta wrote: I think it would be fine not to merge this PR. Asserts are recommended in the LLDB source code. I will close the PR. https://github.com/llvm/llvm-project/pull/95678 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.

[Lldb-commits] [lldb] [lldb] Adjust the for loop condition to prevent unintended increments in ExpandRLE (NFC) (PR #94844)

2024-08-18 Thread Shivam Gupta via lldb-commits
xgupta wrote: ping! https://github.com/llvm/llvm-project/pull/94844 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [clang][AST] fix ast-print of extern with >=2 declarators, fixed, fixed (PR #98795)

2024-08-18 Thread via lldb-commits
temyurchenko wrote: > Ping @JDevlieghere for lldb test suite assistance. > > As for ORC JIT, [the compiler-rt project](https://compiler-rt.llvm.org/) does > not claim to support Windows to begin with, so it's unclear whether the bot > should not be testing on Windows or whether compiler-rt nee

[Lldb-commits] [lldb] Reland "[lldb] Reland 2402b3213c2f with `/H` to debug the windows build issue (PR #101672)

2024-08-18 Thread Med Ismail Bennani via lldb-commits
medismailben wrote: > Okay, that sort of makes sense. However, unless you actually want to be able > to disable each of these plugins independently (which it sounds like you > don't), then this is a very.. baroque way to achieve the desired effect (to > have multiple (plugin) classes registere