[Lldb-commits] [lldb] [lldb-dap] show dialog when executable is not found (PR #104711)

[Jonas Devlieghere via lldb-commits]

================
@@ -17,10 +18,32 @@ function createDefaultLLDBDapOptions(): LLDBDapOptions {
       const path = vscode.workspace
         .getConfiguration("lldb-dap", session.workspaceFolder)
         .get<string>("executable-path");
-      if (path) {
-        return new vscode.DebugAdapterExecutable(path, []);
+
+      if (!path) {
+        return packageJSONExecutable;
+      }
+
+      try {
+        const fileStats = await fs.stat(path);
+        if (!fileStats.isFile()) {
----------------
JDevlieghere wrote:

I assume this will fail if the file is a symlink? Should this be 

```
if (!fileStats.isFile() && !fileStats.isSymbolicLink()))
```

https://github.com/llvm/llvm-project/pull/104711
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits