[Lldb-commits] [lldb] [lldb][test][win][x86_64] Remove XFAIL from XPASS'ing API tests (PR #100477)

2024-07-25 Thread Kendal Harland via lldb-commits
@@ -52,6 +52,7 @@ def test_negative_indexing(self): self.build() self.validate_negative_indexing() +@expectedFailureAll(oslist=["windows"], archs=["x86_64"]) kendalharland wrote: I am still seeing this test fail with: ```

[Lldb-commits] [lldb] [lldb][test][win][x86_64] Remove XFAIL from XPASS'ing API tests (PR #100477)

2024-07-25 Thread Kendal Harland via lldb-commits
https://github.com/kendalharland edited https://github.com/llvm/llvm-project/pull/100477 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test][win][x86_64] FIx XFAIL and XPASS on LLDB API tests (PR #100477)

2024-07-25 Thread Kendal Harland via lldb-commits
https://github.com/kendalharland edited https://github.com/llvm/llvm-project/pull/100477 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test][win][x86_64] Fix XFAIL and XPASS on LLDB API tests (PR #100477)

2024-07-25 Thread Kendal Harland via lldb-commits
https://github.com/kendalharland edited https://github.com/llvm/llvm-project/pull/100477 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Multithreading lldb-server works on Windows now; fixed gdb port mapping (PR #100670)

2024-07-25 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman created https://github.com/llvm/llvm-project/pull/100670 Removed fork(). Used threads and the common thread-safe port map for all platform connections. Updated lldb::FileSystem to use llvm::vfs::createPhysicalFileSystem() with an own virtual working directory per t

[Lldb-commits] [lldb] [lldb] Multithreading lldb-server works on Windows now; fixed gdb port mapping (PR #100670)

2024-07-25 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dmitry Vasilyev (slydiman) Changes Removed fork(). Used threads and the common thread-safe port map for all platform connections. Updated lldb::FileSystem to use llvm::vfs::createPhysicalFileSystem() with an own virtual working directory

[Lldb-commits] [lldb] [LLDB][SBSaveCore] Implement a selectable threadlist for Core Options. (PR #100443)

2024-07-25 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/100443 >From d7940af06873cedf5976dc829dd9377b2851ae25 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Tue, 23 Jul 2024 16:50:57 -0700 Subject: [PATCH 1/7] Implemplement a thread list that is currently unused for SB

[Lldb-commits] [lldb] [LLDB][SBSaveCore] Implement a selectable threadlist for Core Options. (PR #100443)

2024-07-25 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/100443 >From d7940af06873cedf5976dc829dd9377b2851ae25 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Tue, 23 Jul 2024 16:50:57 -0700 Subject: [PATCH 1/7] Implemplement a thread list that is currently unused for SB

[Lldb-commits] [lldb] [LLDB][SBSaveCore] Implement a selectable threadlist for Core Options. (PR #100443)

2024-07-25 Thread Jacob Lalonde via lldb-commits
@@ -46,8 +46,59 @@ SaveCoreOptions::GetOutputFile() const { return m_file; } +void SaveCoreOptions::AddThread(lldb::tid_t tid) { + if (m_threads_to_save.count(tid) == 0) +m_threads_to_save.emplace(tid); +} + +bool SaveCoreOptions::RemoveThread(lldb::tid_t tid) { + if (

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

2024-07-25 Thread via lldb-commits
dlav-sc wrote: > A quick look at the RISCV ISA and it says that the JAL instruction is pc > relative and can jump +/- 1MB. JALR gets the upper 20 bits from a general > purpose register and it includes 12 low bits in its instruction encoding. I > know almost nothing about rv32, but is this what

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

2024-07-25 Thread via lldb-commits
https://github.com/dlav-sc edited https://github.com/llvm/llvm-project/pull/99336 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 0d4f948 - [lldb/Plugins] Fix build failure on windows following 2914a4b88837

2024-07-25 Thread Med Ismail Bennani via lldb-commits
Author: Med Ismail Bennani Date: 2024-07-25T16:19:34-07:00 New Revision: 0d4f9484bcd51d1ed07723c7b762e0f33d9f448f URL: https://github.com/llvm/llvm-project/commit/0d4f9484bcd51d1ed07723c7b762e0f33d9f448f DIFF: https://github.com/llvm/llvm-project/commit/0d4f9484bcd51d1ed07723c7b762e0f33d9f448f.

[Lldb-commits] [lldb] [LLDB][SBSaveCore] Implement a selectable threadlist for Core Options. (PR #100443)

2024-07-25 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/100443 >From d7940af06873cedf5976dc829dd9377b2851ae25 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Tue, 23 Jul 2024 16:50:57 -0700 Subject: [PATCH 1/8] Implemplement a thread list that is currently unused for SB

[Lldb-commits] [lldb] [LLDB][SBSaveCore] Implement a selectable threadlist for Core Options. (PR #100443)

2024-07-25 Thread Jacob Lalonde via lldb-commits
@@ -75,6 +77,18 @@ lldb::SaveCoreStyle SBSaveCoreOptions::GetStyle() const { return m_opaque_up->GetStyle(); } +SBError SBSaveCoreOptions::SetProcess(lldb::SBProcess process) { + return m_opaque_up->SetProcess(process.GetSP()); +} + +SBError SBSaveCoreOptions::AddThread(lld

[Lldb-commits] [lldb] [LLDB][SBSaveCore] Implement a selectable threadlist for Core Options. (PR #100443)

2024-07-25 Thread Jacob Lalonde via lldb-commits
Jlalond wrote: > Stepping back a bit, do we gain anything in `SaveCoreOptions` by having > `m_process_sp` be optional? Is there a distinction between an empty ProcessSP > and no ProcessSP object? No, this was mostly a mistake on my part. I wanted to describe process as optional but required f

[Lldb-commits] [lldb] [LLDB][SBSaveCore] Implement a selectable threadlist for Core Options. (PR #100443)

2024-07-25 Thread Jacob Lalonde via lldb-commits
@@ -46,8 +48,79 @@ SaveCoreOptions::GetOutputFile() const { return m_file; } +Status SaveCoreOptions::SetProcess(lldb::ProcessSP process_sp) { + Status error; + if (!process_sp) { +ClearProcessSpecificData(); +m_process_sp = std::nullopt; +return error; + } +

[Lldb-commits] [lldb] [LLDB][SBSaveCore] Implement a selectable threadlist for Core Options. (PR #100443)

2024-07-25 Thread Jacob Lalonde via lldb-commits
@@ -46,8 +48,79 @@ SaveCoreOptions::GetOutputFile() const { return m_file; } +Status SaveCoreOptions::SetProcess(lldb::ProcessSP process_sp) { + Status error; + if (!process_sp) { +ClearProcessSpecificData(); +m_process_sp = std::nullopt; +return error; + } +

[Lldb-commits] [lldb] [LLDB][SBSaveCore] Implement a selectable threadlist for Core Options. (PR #100443)

2024-07-25 Thread Jacob Lalonde via lldb-commits
@@ -46,8 +48,79 @@ SaveCoreOptions::GetOutputFile() const { return m_file; } +Status SaveCoreOptions::SetProcess(lldb::ProcessSP process_sp) { + Status error; + if (!process_sp) { +ClearProcessSpecificData(); +m_process_sp = std::nullopt; +return error; + } +

[Lldb-commits] [lldb] [LLDB][SBSaveCore] Implement a selectable threadlist for Core Options. (PR #100443)

2024-07-25 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/100443 >From d7940af06873cedf5976dc829dd9377b2851ae25 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Tue, 23 Jul 2024 16:50:57 -0700 Subject: [PATCH 1/9] Implemplement a thread list that is currently unused for SB

[Lldb-commits] [lldb] [lldb] Multithreading lldb-server works on Windows now; fixed gdb port mapping (PR #100670)

2024-07-25 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman edited https://github.com/llvm/llvm-project/pull/100670 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #99736)

2024-07-25 Thread Robert O'Callahan via lldb-commits
rocallahan wrote: > Most of the execution control logic should just know "forward" and > "backwards", but then whether those are implemented by using the reverse > debugging machinery or by allowing the program to run for realz will be know > deeper in the execution control machinery - most li

[Lldb-commits] [lldb] [lldb] Revert scripting template list patches (PR #100673)

2024-07-25 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben created https://github.com/llvm/llvm-project/pull/100673 Reverts https://github.com/llvm/llvm-project/pull/97273 since it broke the windows bot: https://lab.llvm.org/buildbot/#/builders/141/builds/1025/steps/4/logs/stdio >From 3d26d169f2db4a852f828abe87b413421f

[Lldb-commits] [lldb] e8504cb - [lldb] Revert scripting template list patches (#100673)

2024-07-25 Thread via lldb-commits
Author: Med Ismail Bennani Date: 2024-07-25T17:11:36-07:00 New Revision: e8504cb0c933b75d0e31a627d3bd4c0e37e042e1 URL: https://github.com/llvm/llvm-project/commit/e8504cb0c933b75d0e31a627d3bd4c0e37e042e1 DIFF: https://github.com/llvm/llvm-project/commit/e8504cb0c933b75d0e31a627d3bd4c0e37e042e1.

[Lldb-commits] [lldb] [lldb] Revert scripting template list patches (PR #100673)

2024-07-25 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben closed https://github.com/llvm/llvm-project/pull/100673 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Revert scripting template list patches (PR #100673)

2024-07-25 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Med Ismail Bennani (medismailben) Changes Reverts https://github.com/llvm/llvm-project/pull/97273 since it broke the windows bot: https://lab.llvm.org/buildbot/#/builders/141/builds/1025/steps/4/logs/stdio --- Patch is 49.74 KiB, truncat

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #99736)

2024-07-25 Thread via lldb-commits
jimingham wrote: > On Jul 25, 2024, at 4:58 PM, rocallahan ***@***.***> wrote: > > > Most of the execution control logic should just know "forward" and > "backwards", but then whether those are implemented by using the reverse > debugging machinery or by allowing the program to run for real

[Lldb-commits] [lldb] [lldb][TypeSystemClang][NFC] Clean up TypeSystemClang::GetBitSize (PR #100674)

2024-07-25 Thread Michael Buch via lldb-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/100674 This patch performs following NFC changes to TypeSystemClang::GetBitSize: * Factor out the Objective-C logic into a helper function. * Introduce a new case for `FunctionProto`. I don't see a good reason for s

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #99736)

2024-07-25 Thread via lldb-commits
jimingham wrote: > On Jul 25, 2024, at 3:34 PM, Greg Clayton ***@***.***> wrote: > > > @clayborg commented on this pull request. > > In lldb/include/lldb/API/SBProcess.h > : > > > - lldb::SBError Continue(); > + lldb

[Lldb-commits] [lldb] [lldb][TypeSystemClang][NFC] Clean up TypeSystemClang::GetBitSize (PR #100674)

2024-07-25 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes This patch performs following NFC changes to TypeSystemClang::GetBitSize: * Factor out the Objective-C logic into a helper function. * Introduce a new case for `FunctionProto`. I don't see a good reason for

[Lldb-commits] [lldb] [lldb][TypeSystemClang][NFC] Clean up TypeSystemClang::GetBitSize (PR #100674)

2024-07-25 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/100674 >From 0f982058ed0e8a28c4e4b440f480584fa06e80d5 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Fri, 26 Jul 2024 01:19:02 +0100 Subject: [PATCH 1/2] [lldb][TypeSystemClang][NFC] Clean up TypeSystemClang::Ge

[Lldb-commits] [lldb] [lldb][TypeSystemClang][NFC] Clean up TypeSystemClang::GetBitSize (PR #100674)

2024-07-25 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/100674 >From 0f982058ed0e8a28c4e4b440f480584fa06e80d5 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Fri, 26 Jul 2024 01:19:02 +0100 Subject: [PATCH 1/3] [lldb][TypeSystemClang][NFC] Clean up TypeSystemClang::Ge

[Lldb-commits] [lldb] [lldb] Optimized lldb-server memory usage (PR #100666)

2024-07-25 Thread Alex Langford via lldb-commits
@@ -1145,7 +1145,8 @@ Status GDBRemoteCommunication::StartDebugserverProcess( if (socket_pipe.CanWrite()) socket_pipe.CloseWriteFileDescriptor(); if (socket_pipe.CanRead()) { -char port_cstr[PATH_MAX] = {0}; +// The port number may be "1024\0

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #99736)

2024-07-25 Thread Robert O'Callahan via lldb-commits
rocallahan wrote: > First off, for systems that do past motion and forward motion, there are > things you really can't do effectively in the past, like set variable values > and have that make any difference. So we probably will need to know whether > we're executing in the immutable past or t

[Lldb-commits] [lldb] [lldb] Optimized lldb-server memory usage (PR #100666)

2024-07-25 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: Hm, I was worried that we might get the filepath of a unix socket in some use case, but we llvm::to_integer(port_cstr) shortly later, so that can't be the case. https://github.com/llvm/llvm-project/pull/100666 ___ lldb-commits mai

[Lldb-commits] [lldb] [LLDB][SBSaveCore] Implement a selectable threadlist for Core Options. (PR #100443)

2024-07-25 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/100443 >From d7940af06873cedf5976dc829dd9377b2851ae25 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Tue, 23 Jul 2024 16:50:57 -0700 Subject: [PATCH 01/10] Implemplement a thread list that is currently unused for

[Lldb-commits] [lldb] [lldb][TypeSystemClang][NFC] Clean up TypeSystemClang::GetBitSize (PR #100674)

2024-07-25 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere requested changes to this pull request. https://github.com/llvm/llvm-project/pull/100674 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][TypeSystemClang][NFC] Clean up TypeSystemClang::GetBitSize (PR #100674)

2024-07-25 Thread Jonas Devlieghere via lldb-commits
@@ -4725,67 +4725,69 @@ TypeSystemClang::GetFloatTypeSemantics(size_t byte_size) { return llvm::APFloatBase::Bogus(); } +std::optional +TypeSystemClang::GetObjCBitSize(QualType qual_type, +ExecutionContextScope *exe_scope) { + assert(qual_ty

[Lldb-commits] [lldb] [lldb][TypeSystemClang][NFC] Clean up TypeSystemClang::GetBitSize (PR #100674)

2024-07-25 Thread Jonas Devlieghere via lldb-commits
@@ -4725,67 +4725,69 @@ TypeSystemClang::GetFloatTypeSemantics(size_t byte_size) { return llvm::APFloatBase::Bogus(); } +std::optional +TypeSystemClang::GetObjCBitSize(QualType qual_type, +ExecutionContextScope *exe_scope) { + assert(qual_ty

[Lldb-commits] [lldb] [lldb][TypeSystemClang][NFC] Clean up TypeSystemClang::GetBitSize (PR #100674)

2024-07-25 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/100674 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][TypeSystemClang][NFC] Clean up TypeSystemClang::GetBitSize (PR #100674)

2024-07-25 Thread Michael Buch via lldb-commits
@@ -4725,67 +4725,69 @@ TypeSystemClang::GetFloatTypeSemantics(size_t byte_size) { return llvm::APFloatBase::Bogus(); } +std::optional +TypeSystemClang::GetObjCBitSize(QualType qual_type, +ExecutionContextScope *exe_scope) { + assert(qual_ty

[Lldb-commits] [lldb] [lldb][TypeSystemClang][NFC] Clean up TypeSystemClang::GetBitSize (PR #100674)

2024-07-25 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/100674 >From 0f982058ed0e8a28c4e4b440f480584fa06e80d5 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Fri, 26 Jul 2024 01:19:02 +0100 Subject: [PATCH 1/4] [lldb][TypeSystemClang][NFC] Clean up TypeSystemClang::Ge

[Lldb-commits] [lldb] [lldb][TypeSystemClang][NFC] Clean up TypeSystemClang::GetBitSize (PR #100674)

2024-07-25 Thread Michael Buch via lldb-commits
@@ -4725,67 +4725,69 @@ TypeSystemClang::GetFloatTypeSemantics(size_t byte_size) { return llvm::APFloatBase::Bogus(); } +std::optional +TypeSystemClang::GetObjCBitSize(QualType qual_type, +ExecutionContextScope *exe_scope) { + assert(qual_ty

[Lldb-commits] [lldb] [lldb-dap] Updated README.md for newly added attach properties. (PR #99926)

2024-07-25 Thread Santhosh Kumar Ellendula via lldb-commits
https://github.com/santhoshe447 updated https://github.com/llvm/llvm-project/pull/99926 >From 960351c9abf51f42d92604ac6297aa5b76ddfba5 Mon Sep 17 00:00:00 2001 From: Santhosh Kumar Ellendula Date: Fri, 17 Nov 2023 15:09:10 +0530 Subject: [PATCH 01/20] [lldb][test] Add the ability to extract the

<    1   2