[Lldb-commits] [lldb] [lldb/Target] Add GetStartSymbol method to DynamicLoader plugins (PR #99673)

labath wrote: I'd like to note that, at least in the ELF world, there's no guarantee that there will be an actual *symbol* at the address where the process starts executing. The convention is to call this `_start` but nothing in the system actually relies on that. The ELF header contains the a

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

dlav-sc wrote: > > Thanks for the patches (if we end up going down this route you'll probably > > want to split out the LLVM JIT changes into a separate PR). > > I know little about the JIT side but this is my first reaction too. I wonder > if that has its own tests that need adding, and it'll

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

dlav-sc wrote: > A quick look at the RISCV ISA and it says that the JAL instruction is pc > relative and can jump +/- 1MB. JALR gets the upper 20 bits from a general > purpose register and it includes 12 low bits in its instruction encoding. I > know almost nothing about rv32, but is this what

[Lldb-commits] [lldb] [LLDB][SBSaveCoreOptions] Fix TestProcessSaveCore (PR #99692)

luporl wrote: @Jlalond Thanks for the fix. https://github.com/llvm/llvm-project/pull/99692 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

dlav-sc wrote: > Thanks for the patches (if we end up going down this route you'll probably > want to split out the LLVM JIT changes into a separate PR). > > Not very familiar with RISCV. Could you elaborate on the exact failures you > were seeing and why we need the extra IR pass? > > > Also

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

@@ -0,0 +1,58 @@ +//===--- DirectToIndirectFCR.h - RISC-V specific pass -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

@@ -0,0 +1,58 @@ +//===--- DirectToIndirectFCR.h - RISC-V specific pass -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb/Target] Add GetStartSymbol method to DynamicLoader plugins (PR #99673)

jimingham wrote: I agree with Pavel, we don't for most purposes care whether there's a symbol at the start address (for instance we can use it for the "expression evaluation return breakpoint" as an address. So we shouldn't require the symbol. Jim > On Jul 22, 2024, at 12:04 AM, Pavel Labath

[Lldb-commits] [lldb] [lldb] Change GetStartSymbol to GetStartAddress in DynamicLoader (PR #99909)

https://github.com/medismailben created https://github.com/llvm/llvm-project/pull/99909 On linux, the start address doesn't necessarily have a symbol attached to it. This is why this patch replaces `DynamicLoader::GetStartSymbol` with `DynamicLoader::GetStartAddress` instead. >From f74357959a

[Lldb-commits] [lldb] [lldb] Change GetStartSymbol to GetStartAddress in DynamicLoader (PR #99909)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Med Ismail Bennani (medismailben) Changes On linux, the start address doesn't necessarily have a symbol attached to it. This is why this patch replaces `DynamicLoader::GetStartSymbol` with `DynamicLoader::GetStartAddress` instead. --- Ful

[Lldb-commits] [lldb] [lldb/Target] Add GetStartSymbol method to DynamicLoader plugins (PR #99673)

medismailben wrote: @labath @jimingham I've addressed your comment in https://github.com/llvm/llvm-project/pull/99909 https://github.com/llvm/llvm-project/pull/99673 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-

[Lldb-commits] [lldb] [lldb] Change GetStartSymbol to GetStartAddress in DynamicLoader (PR #99909)

https://github.com/medismailben edited https://github.com/llvm/llvm-project/pull/99909 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Change GetStartSymbol to GetStartAddress in DynamicLoader (PR #99909)

https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/99909 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] bb8a740 - [lldb] Change GetStartSymbol to GetStartAddress in DynamicLoader (#99909)

Author: Med Ismail Bennani Date: 2024-07-22T11:43:32-07:00 New Revision: bb8a74075b164ea0d9b3155f64d0590fc6072cdd URL: https://github.com/llvm/llvm-project/commit/bb8a74075b164ea0d9b3155f64d0590fc6072cdd DIFF: https://github.com/llvm/llvm-project/commit/bb8a74075b164ea0d9b3155f64d0590fc6072cdd.

[Lldb-commits] [lldb] [lldb] Change GetStartSymbol to GetStartAddress in DynamicLoader (PR #99909)

https://github.com/medismailben closed https://github.com/llvm/llvm-project/pull/99909 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Updated README.md for newly added attach properties. (PR #99926)

https://github.com/santhoshe447 created https://github.com/llvm/llvm-project/pull/99926 Added "gdb-remote-port" and "gdb-remote-hostname" attach properties usage in README.md. This was missed in PR https://github.com/llvm/llvm-project/pull/91570 >From 960351c9abf51f42d92604ac6297aa5b76ddfb

[Lldb-commits] [lldb] [lldb/Commands] Add `scripting template list` command with auto discovery (PR #97273)

https://github.com/bulbazord edited https://github.com/llvm/llvm-project/pull/97273 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/Commands] Add `scripting template list` command with auto discovery (PR #97273)

https://github.com/bulbazord commented: Seems alright to me, left a few minor suggestions inline. https://github.com/llvm/llvm-project/pull/97273 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[Lldb-commits] [lldb] [lldb/Commands] Add `scripting template list` command with auto discovery (PR #97273)

@@ -329,6 +330,13 @@ class DynamicLoader : public PluginInterface { /// safe to call certain APIs or SPIs. virtual bool IsFullyInitialized() { return true; } + /// Return the `start` function \b symbol in the dynamic loader module. + /// This is the symbol the process wi

[Lldb-commits] [lldb] [lldb/Commands] Add `scripting template list` command with auto discovery (PR #97273)

@@ -127,9 +129,127 @@ class CommandObjectScriptingRun : public CommandObjectRaw { CommandOptions m_options; }; -#pragma mark CommandObjectMultiwordScripting +#define LLDB_OPTIONS_scripting_template_list +#include "CommandOptions.inc" + +class CommandObjectScriptingTemplateL

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #99736)

@@ -160,6 +160,8 @@ class LLDB_API SBProcess { lldb::SBError Continue(); + lldb::SBError ReverseContinue(); jimingham wrote: For programming uses, it might be more useful to have one API with a bool or RunDirection or something? It's nicer to write: `

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #99736)

https://github.com/jimingham edited https://github.com/llvm/llvm-project/pull/99736 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #99736)

@@ -1395,6 +1395,94 @@ Status ProcessGDBRemote::DoResume() { return error; } +Status ProcessGDBRemote::DoResumeReverse() { + Status error; + Log *log = GetLog(GDBRLog::Process); + LLDB_LOGF(log, "ProcessGDBRemote::DoResumeReverse()"); + + ListenerSP listener_sp( + L

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #99736)

@@ -3264,6 +3266,11 @@ Status Process::PrivateResume() { // filters before resuming. UpdateAutomaticSignalFiltering(); + if (m_last_run_direction != direction) { jimingham wrote: It might be hard, but it would be nice if this wasn't necessary. For insta

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #99736)

@@ -3281,7 +3288,11 @@ Status Process::PrivateResume() { "Process::PrivateResume PreResumeActions failed, not resuming."); } else { m_mod_id.BumpResumeID(); -error = DoResume(); +if (direction == eRunForward) { + error = DoResu

[Lldb-commits] [lldb] lldb: android: fix missing Python import of urlparse from lldb test utilities (PR #99934)

https://github.com/andrurogerz created https://github.com/llvm/llvm-project/pull/99934 ## Issue Attempting to run the lldb API tests against a remote-android target fails with the error `NameError: name 'urlparse' is not defined`. ## Root Cause It looks the Python import of `urlparse` was remo

[Lldb-commits] [lldb] lldb: android: fix missing Python import of urlparse from lldb test utilities (PR #99934)

github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[Lldb-commits] [lldb] lldb: android: fix missing Python import of urlparse from lldb test utilities (PR #99934)

andrurogerz wrote: cc @compnerd https://github.com/llvm/llvm-project/pull/99934 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] lldb: android: fix missing Python import of urlparse from lldb test utilities (PR #99934)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Andrew Rogers (andrurogerz) Changes ## Issue Attempting to run the lldb API tests against a remote-android target fails with the error `NameError: name 'urlparse' is not defined`. ## Root Cause It looks the Python import of `urlparse` was

[Lldb-commits] [lldb] [lldb/Commands] Add `scripting template list` command with auto discovery (PR #97273)

https://github.com/medismailben updated https://github.com/llvm/llvm-project/pull/97273 >From faa1aec645e26145467b94260df7ca3abc012f62 Mon Sep 17 00:00:00 2001 From: Med Ismail Bennani Date: Wed, 17 Jul 2024 02:21:21 -0700 Subject: [PATCH] [lldb/Commands] Add `scripting template list` command w

[Lldb-commits] [lldb] lldb: android: fix missing Python import of urlparse in lldb test utilities (PR #99934)

https://github.com/andrurogerz edited https://github.com/llvm/llvm-project/pull/99934 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] lldb: android: fix missing Python import of urlparse in lldb test utilities (PR #99934)

https://github.com/andrurogerz edited https://github.com/llvm/llvm-project/pull/99934 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/Commands] Add `scripting template list` command with auto discovery (PR #97273)

https://github.com/medismailben updated https://github.com/llvm/llvm-project/pull/97273 >From d40b66db50800e83ef2d9a74471e031fae1d78ae Mon Sep 17 00:00:00 2001 From: Med Ismail Bennani Date: Mon, 22 Jul 2024 13:59:50 -0700 Subject: [PATCH] [lldb/Commands] Add `scripting template list` command w

[Lldb-commits] [lldb] [lldb/Commands] Add `scripting template list` command with auto discovery (PR #97273)

https://github.com/bulbazord approved this pull request. LGTM, you'll probably want sign off from Jonas too though since he had a ton of comments. https://github.com/llvm/llvm-project/pull/97273 ___ lldb-commits mailing list lldb-commits@lists.llvm.or

[Lldb-commits] [lldb] [lldb/Plugins] Introduce Scripted Platform Plugin (PR #99814)

@@ -299,6 +301,35 @@ SBPlatform::SBPlatform(const char *platform_name) { m_opaque_sp = Platform::Create(platform_name); } +SBPlatform::SBPlatform(const char *platform_name, const SBDebugger &debugger, + const char *script_name, const SBStructuredData &d

[Lldb-commits] [lldb] [lldb/Plugins] Introduce Scripted Platform Plugin (PR #99814)

@@ -0,0 +1,288 @@ +//===-- ScriptedPlatform.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb/Plugins] Introduce Scripted Platform Plugin (PR #99814)

@@ -0,0 +1,288 @@ +//===-- ScriptedPlatform.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb/Plugins] Introduce Scripted Platform Plugin (PR #99814)

@@ -10,6 +10,7 @@ #define LLDB_SOURCE_COMMANDS_COMMANDOBJECTPLATFORM_H #include "lldb/Interpreter/CommandObjectMultiword.h" +#include "lldb/Interpreter/OptionGroupPlatform.h" bulbazord wrote: Why do you need this include here? https://github.com/llvm/llvm-pr

[Lldb-commits] [lldb] [lldb/Plugins] Introduce Scripted Platform Plugin (PR #99814)

@@ -299,6 +301,35 @@ SBPlatform::SBPlatform(const char *platform_name) { m_opaque_sp = Platform::Create(platform_name); } +SBPlatform::SBPlatform(const char *platform_name, const SBDebugger &debugger, + const char *script_name, const SBStructuredData &d

[Lldb-commits] [lldb] [lldb/Plugins] Introduce Scripted Platform Plugin (PR #99814)

@@ -299,6 +301,35 @@ SBPlatform::SBPlatform(const char *platform_name) { m_opaque_sp = Platform::Create(platform_name); } +SBPlatform::SBPlatform(const char *platform_name, const SBDebugger &debugger, + const char *script_name, const SBStructuredData &d

[Lldb-commits] [lldb] [lldb/Plugins] Introduce Scripted Platform Plugin (PR #99814)

@@ -0,0 +1,288 @@ +//===-- ScriptedPlatform.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb/Plugins] Introduce Scripted Platform Plugin (PR #99814)

@@ -15,8 +15,8 @@ namespace lldb_private { class ScriptedMetadata { public: - ScriptedMetadata(llvm::StringRef class_name, - StructuredData::DictionarySP dict_sp) + ScriptedMetadata(const llvm::StringRef class_name, + const StructuredData::

[Lldb-commits] [lldb] [lldb/Plugins] Introduce Scripted Platform Plugin (PR #99814)

@@ -0,0 +1,288 @@ +//===-- ScriptedPlatform.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb/Plugins] Introduce Scripted Platform Plugin (PR #99814)

@@ -0,0 +1,288 @@ +//===-- ScriptedPlatform.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb/Plugins] Introduce Scripted Platform Plugin (PR #99814)

@@ -0,0 +1,288 @@ +//===-- ScriptedPlatform.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb/Plugins] Introduce Scripted Platform Plugin (PR #99814)

@@ -0,0 +1,288 @@ +//===-- ScriptedPlatform.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] lldb: android: fix missing Python import of urlparse in lldb test utilities (PR #99934)

https://github.com/compnerd approved this pull request. https://github.com/llvm/llvm-project/pull/99934 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/Plugins] Introduce Scripted Platform Plugin (PR #99814)

@@ -299,6 +301,35 @@ SBPlatform::SBPlatform(const char *platform_name) { m_opaque_sp = Platform::Create(platform_name); } +SBPlatform::SBPlatform(const char *platform_name, const SBDebugger &debugger, + const char *script_name, const SBStructuredData &d

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #99736)

@@ -160,6 +160,8 @@ class LLDB_API SBProcess { lldb::SBError Continue(); + lldb::SBError ReverseContinue(); rocallahan wrote: Yeah OK. https://github.com/llvm/llvm-project/pull/99736 ___ lldb-commits mailing li

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #99736)

@@ -1395,6 +1395,94 @@ Status ProcessGDBRemote::DoResume() { return error; } +Status ProcessGDBRemote::DoResumeReverse() { + Status error; + Log *log = GetLog(GDBRLog::Process); + LLDB_LOGF(log, "ProcessGDBRemote::DoResumeReverse()"); + + ListenerSP listener_sp( + L

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #99736)

@@ -3264,6 +3266,11 @@ Status Process::PrivateResume() { // filters before resuming. UpdateAutomaticSignalFiltering(); + if (m_last_run_direction != direction) { rocallahan wrote: TBH I don't understand thread plans very well yet so I was trying to avoid

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #99736)

@@ -3264,6 +3266,11 @@ Status Process::PrivateResume() { // filters before resuming. UpdateAutomaticSignalFiltering(); + if (m_last_run_direction != direction) { rocallahan wrote: I'm a bit worried that in general thread plans have a lot of complexity, a

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #99736)

@@ -3264,6 +3266,11 @@ Status Process::PrivateResume() { // filters before resuming. UpdateAutomaticSignalFiltering(); + if (m_last_run_direction != direction) { rocallahan wrote: If the user does "continue", hits a breakpoint, does "reverse-step", and t

[Lldb-commits] [lldb] [lldb/Plugins] Introduce Scripted Platform Plugin (PR #99814)

@@ -0,0 +1,288 @@ +//===-- ScriptedPlatform.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #99736)

https://github.com/rocallahan edited https://github.com/llvm/llvm-project/pull/99736 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [llvm] [BOLT][DWARF][NFC] Split processUnitDIE into two lambdas (PR #99957)

https://github.com/sayhaan created https://github.com/llvm/llvm-project/pull/99957 Split processUnitDIE into two lambdas to separate the processing of DWO CUs and CUs in the main binary. >From 29feff4a9abed4bacb6615232daed84269d4a699 Mon Sep 17 00:00:00 2001 From: Amir Ayupov Date: Tue, 1 Jun

[Lldb-commits] [lldb] [lldb][debugserver] Retry sleep(0.25s) when interrupted (PR #99962)

https://github.com/jasonmolenda created https://github.com/llvm/llvm-project/pull/99962 After lldb has ptrace()'ed the process, it sleeps for 0.25 seconds before trying to pause the process. We see logging that in some rare cases, this sleep is interrupted and the pause fails, the attach fail

[Lldb-commits] [lldb] [lldb][debugserver] Retry sleep(0.25s) when interrupted (PR #99962)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jason Molenda (jasonmolenda) Changes After lldb has ptrace()'ed the process, it sleeps for 0.25 seconds before trying to pause the process. We see logging that in some rare cases, this sleep is interrupted and the pause fails, the attach

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #99736)

@@ -3281,7 +3288,11 @@ Status Process::PrivateResume() { "Process::PrivateResume PreResumeActions failed, not resuming."); } else { m_mod_id.BumpResumeID(); -error = DoResume(); +if (direction == eRunForward) { + error = DoResu

[Lldb-commits] [lldb] [lldb][debugserver] Retry sleep(0.25s) when interrupted (PR #99962)

https://github.com/jasonmolenda edited https://github.com/llvm/llvm-project/pull/99962 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][debugserver] Retry sleep(0.25s) when interrupted (PR #99962)

jasonmolenda wrote: Ah, Jonas points out that I've fixed the wrong sleep. He has a patch he'll put up for the real problem. This does not fix a known problem. https://github.com/llvm/llvm-project/pull/99962 ___ lldb-commits mailing list lldb-commits

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #99736)

jimingham wrote: > On Jul 22, 2024, at 2:52 PM, rocallahan ***@***.***> wrote: > > > @rocallahan commented on this pull request. > > In lldb/source/Target/Process.cpp > : > > > @@ -3264,6 +3266,11 @@ Status Process::Pr

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #99736)

jimingham wrote: > On Jul 22, 2024, at 2:56 PM, rocallahan ***@***.***> wrote: > > > @rocallahan commented on this pull request. > > In lldb/source/Target/Process.cpp > : > > > @@ -3264,6 +3266,11 @@ Status Process::Pr

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #99736)

rocallahan wrote: > You might have to be careful in the case where someone runs a function call, > stops at a breakpoint in the function call and decides to go backwards in the > function execution (if that's possible). That is not possible in rr. During user function calls it responds to reve

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #99736)

jimingham wrote: > On Jul 22, 2024, at 2:54 PM, rocallahan ***@***.***> wrote: > > > @rocallahan commented on this pull request. > > In lldb/source/Target/Process.cpp > : > > > @@ -3264,6 +3266,11 @@ Status Process::Pr

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #99736)

jimingham wrote: > On Jul 22, 2024, at 3:44 PM, rocallahan ***@***.***> wrote: > > > You might have to be careful in the case where someone runs a function call, > stops at a breakpoint in the function call and decides to go backwards in the > function execution (if that's possible). > > T

[Lldb-commits] [lldb] [lldb][debugserver] Retry sleep(0.25s) when interrupted (PR #99962)

https://github.com/jasonmolenda closed https://github.com/llvm/llvm-project/pull/99962 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #99736)

https://github.com/rocallahan updated https://github.com/llvm/llvm-project/pull/99736 >From 5ecca71b03027e132f3b75612c0783a68eafdf4f Mon Sep 17 00:00:00 2001 From: Robert O'Callahan Date: Fri, 19 Jul 2024 22:46:42 +1200 Subject: [PATCH] [lldb] Implement basic support for reverse-continue This

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #99736)

@@ -3281,7 +3288,11 @@ Status Process::PrivateResume() { "Process::PrivateResume PreResumeActions failed, not resuming."); } else { m_mod_id.BumpResumeID(); -error = DoResume(); +if (direction == eRunForward) { + error = DoResu

[Lldb-commits] [lldb] [lldb] Unify WaitForSetEvents and WaitForEventsToReset (PR #99997)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes Unify the implementations of WaitForSetEvents and WaitForEventsToReset. The former deals with the possibility of a race between the timeout and the predicate while the latter does not. The functions

[Lldb-commits] [lldb] [lldb] Unify WaitForSetEvents and WaitForEventsToReset (PR #99997)

https://github.com/jimingham approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/7 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [llvm] [BOLT][DWARF][NFC] Split processUnitDIE into two lambdas (PR #99957)

https://github.com/sayhaan updated https://github.com/llvm/llvm-project/pull/99957 >From 11fff0b2d1868f1e8fce988b2b41a38de42dff61 Mon Sep 17 00:00:00 2001 From: Amir Ayupov Date: Tue, 1 Jun 2021 11:37:41 -0700 Subject: [PATCH 1/4] Rebase: [Facebook] Add clang driver options to test debug info

[Lldb-commits] [lldb] [lldb/Plugins] Introduce Scripted Platform Plugin (PR #99814)

@@ -299,6 +301,35 @@ SBPlatform::SBPlatform(const char *platform_name) { m_opaque_sp = Platform::Create(platform_name); } +SBPlatform::SBPlatform(const char *platform_name, const SBDebugger &debugger, + const char *script_name, const SBStructuredData &d

[Lldb-commits] [lldb] [lldb/Plugins] Introduce Scripted Platform Plugin (PR #99814)

@@ -0,0 +1,288 @@ +//===-- ScriptedPlatform.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb/Plugins] Introduce Scripted Platform Plugin (PR #99814)

@@ -0,0 +1,288 @@ +//===-- ScriptedPlatform.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb/Plugins] Introduce Scripted Platform Plugin (PR #99814)

https://github.com/medismailben edited https://github.com/llvm/llvm-project/pull/99814 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/Plugins] Introduce Scripted Platform Plugin (PR #99814)

https://github.com/medismailben updated https://github.com/llvm/llvm-project/pull/99814 >From 9b7d9a26eabce5f76a99876c14aab619aab934ac Mon Sep 17 00:00:00 2001 From: Med Ismail Bennani Date: Mon, 22 Jul 2024 21:11:48 -0700 Subject: [PATCH] [lldb/Plugins] Introduce Scripted Platform Plugin This