================
@@ -3281,7 +3288,11 @@ Status Process::PrivateResume() {
             "Process::PrivateResume PreResumeActions failed, not resuming.");
       } else {
         m_mod_id.BumpResumeID();
-        error = DoResume();
+        if (direction == eRunForward) {
+          error = DoResume();
----------------
rocallahan wrote:

The advantage of separate `DoResume()` and `DoResumeReverse()` methods is that 
`Process` subclasses that don't support reverse execution don't have to change 
at all; they inherit the default `DoResumeReverse()` that returns an error. If 
I make `DoResume()` take a direction parameter then those implementations 
(three out of four AFAICT) need to add a check of the direction parameter. It's 
not a big deal, I'll change it.

https://github.com/llvm/llvm-project/pull/99736
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to