https://github.com/DavidSpickett approved this pull request.
https://github.com/llvm/llvm-project/pull/99039
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: dlav-sc
Date: 2024-07-18T09:09:52+01:00
New Revision: cbd255942b52c3576aa0dca444811512fff43714
URL:
https://github.com/llvm/llvm-project/commit/cbd255942b52c3576aa0dca444811512fff43714
DIFF:
https://github.com/llvm/llvm-project/commit/cbd255942b52c3576aa0dca444811512fff43714.diff
LOG:
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/99039
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
github-actions[bot] wrote:
@dlav-sc Congratulations on having your first Pull Request (PR) merged into the
LLVM Project!
Your changes will be combined with recent changes from other authors, then
tested
by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with
a build,
ita-sc wrote:
Sorry for huge delay, could you please merge this? (I do not have write access
yet)
https://github.com/llvm/llvm-project/pull/89765
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo
DavidSpickett wrote:
I tested this with the port mapping I usually use for simulator development and
it works fine.
Thanks for the fix.
https://github.com/llvm/llvm-project/pull/98833
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://
Author: Dmitry Vasilyev
Date: 2024-07-18T10:04:49+01:00
New Revision: d097f430a172a5d798a39b416b1af84f4ec572e1
URL:
https://github.com/llvm/llvm-project/commit/d097f430a172a5d798a39b416b1af84f4ec572e1
DIFF:
https://github.com/llvm/llvm-project/commit/d097f430a172a5d798a39b416b1af84f4ec572e1.dif
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/98833
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/99305
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -153,19 +127,89 @@ void TypeQuery::SetLanguages(LanguageSet languages) {
bool TypeQuery::ContextMatches(
llvm::ArrayRef context_chain) const {
- if (GetExactMatch() || context_chain.size() == m_context.size())
-return ::contextMatches(context_chain, m_context);
-
-
https://github.com/Michael137 approved this pull request.
LGTM (left some minor questions)
I've also recently bumped into the issue of `FindTypes`/`FindNamespace`/etc.
failing to find matches due to presence of `(anonymous namespace)` entries in
the context, so thanks for fixing that
https://
@@ -153,19 +127,89 @@ void TypeQuery::SetLanguages(LanguageSet languages) {
bool TypeQuery::ContextMatches(
llvm::ArrayRef context_chain) const {
- if (GetExactMatch() || context_chain.size() == m_context.size())
-return ::contextMatches(context_chain, m_context);
-
-
https://github.com/Michael137 commented:
Should we disallow certain `CompilerContextKind` combinations from being used
in a query? E.g., `AnyModule | Type`, etc. shouldn't be something we need to
worry about supporting?
https://github.com/llvm/llvm-project/pull/99305
__
Michael137 wrote:
Thanks for the patches (if we end up going down this route you'll probably want
to split out the LLVM JIT changes into a separate PR).
Not very familiar with RISCV. Could you elaborate on the exact failures you
were seeing and why we need the extra IR pass?
https://github.co
DavidSpickett wrote:
> Thanks for the patches (if we end up going down this route you'll probably
> want to split out the LLVM JIT changes into a separate PR).
I know little about the JIT side but this is my first reaction too. I wonder if
that has its own tests that need adding, and it'll get
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/96538
>From 231e0ddc5834ac7fe8e4860c79504f6ce8666db5 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Mon, 29 Jan 2024 16:23:16 +
Subject: [PATCH 1/3] [lldb] Support new libc++ __compressed_pair layout
---
ll
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/96538
>From 0358143d3bf98d66c1e7112b9e07109eb7b852a1 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Mon, 29 Jan 2024 16:23:16 +
Subject: [PATCH 1/3] [lldb] Support new libc++ __compressed_pair layout
---
ll
@@ -153,19 +127,89 @@ void TypeQuery::SetLanguages(LanguageSet languages) {
bool TypeQuery::ContextMatches(
llvm::ArrayRef context_chain) const {
- if (GetExactMatch() || context_chain.size() == m_context.size())
-return ::contextMatches(context_chain, m_context);
-
-
labath wrote:
> LGTM (left some minor questions)
>
> I've also recently bumped into the issue of `FindTypes`/`FindNamespace`/etc.
> failing to find matches due to presence of `(anonymous namespace)` entries in
> the context, so thanks for fixing that
We're not there yet. :)
https://github.co
@@ -153,19 +127,89 @@ void TypeQuery::SetLanguages(LanguageSet languages) {
bool TypeQuery::ContextMatches(
llvm::ArrayRef context_chain) const {
- if (GetExactMatch() || context_chain.size() == m_context.size())
-return ::contextMatches(context_chain, m_context);
-
-
dzhidzhoev wrote:
> What exactly does it help with? Given that you're canonicalizing to a forward
> slash, does that mean that some of the tools you use don't accept backslashes
> (perhaps because they come from cygwin or the like)?
As far as I understand, MinGW make, on which Chocolatey build
dzhidzhoev wrote:
> It may be better to split this into smaller patches, given the fragility of
> this code. (Basically, one patch for each of your bullet points).
I was thinking about that, but for me it looked like path_wrapper thing and
cross-compilation/sdkroot fixes should have been sent
@@ -263,9 +280,9 @@ CFLAGS += $(NO_LIMIT_DEBUG_INFO_FLAGS) $(ARCH_CFLAGS)
# Use this one if you want to build one part of the result without debug
information:
ifeq "$(OS)" "Darwin"
- CFLAGS_NO_DEBUG = -O0 $(ARCHFLAG) $(ARCH) $(FRAMEWORK_INCLUDES)
$(ARCH_CFLAGS) $(CFLA
https://github.com/dzhidzhoev edited
https://github.com/llvm/llvm-project/pull/99266
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/dzhidzhoev created
https://github.com/llvm/llvm-project/pull/99532
Since Windows 10 the case of 'windir' env variable was changed. Such error
appears without that change:
```
make: \system32\cmd.exe: Command not found
Makefile.rules:628: recipe for target 'main.o' failed
``
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Vladislav Dzhidzhoev (dzhidzhoev)
Changes
Since Windows 10 the case of 'windir' env variable was changed. Such error
appears without that change:
```
make: \system32\cmd.exe: Command not found
Makefile.rules:628: recipe for target 'main.o
dzhidzhoev wrote:
Moved SHELL variable change to a separate commit
https://github.com/llvm/llvm-project/pull/99532.
https://github.com/llvm/llvm-project/pull/99266
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bi
https://github.com/dzhidzhoev created
https://github.com/llvm/llvm-project/pull/99535
Remove commands for OS/HOST_OS detection from Makefile.rules to simplify it,
since logic for these variables has been implemented in
`lldb/packages/Python/lldbsuite/test/lldbplatformutil.py`
(https://github.
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Vladislav Dzhidzhoev (dzhidzhoev)
Changes
Remove commands for OS/HOST_OS detection from Makefile.rules to simplify it,
since logic for these variables has been implemented in
`lldb/packages/Python/lldbsuite/test/lldbplatformutil.py`
(http
@@ -56,15 +57,12 @@ LLDB_BASE_DIR := $(THIS_FILE_DIR)/../../../../../
# inherited all the way down to the process spawned for make.
#--
ifeq "$(HOST_OS)" ""
- HOST_OS := $(shell uname -s)
-endif
-
-ifneq (,$(f
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/99535
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Vladislav Dzhidzhoev
Date: 2024-07-18T20:04:21+02:00
New Revision: 78e3bfc120c8a23e246f544a5e9fb122828a21a7
URL:
https://github.com/llvm/llvm-project/commit/78e3bfc120c8a23e246f544a5e9fb122828a21a7
DIFF:
https://github.com/llvm/llvm-project/commit/78e3bfc120c8a23e246f544a5e9fb122828a21a
https://github.com/dzhidzhoev closed
https://github.com/llvm/llvm-project/pull/99535
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond edited
https://github.com/llvm/llvm-project/pull/98403
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond edited
https://github.com/llvm/llvm-project/pull/98403
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/clayborg commented:
Just two quick things and this is good to go!
https://github.com/llvm/llvm-project/pull/98403
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/98403
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,69 @@
+//===-- SBSaveCoreOptions.h -*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -1216,13 +1217,26 @@ bool SBProcess::IsInstrumentationRuntimePresent(
lldb::SBError SBProcess::SaveCore(const char *file_name) {
LLDB_INSTRUMENT_VA(this, file_name);
- return SaveCore(file_name, "", SaveCoreStyle::eSaveCoreFull);
+ SBSaveCoreOptions options;
+ options.
https://github.com/clayborg approved this pull request.
Thanks for sticking with me, this looks really good now
https://github.com/llvm/llvm-project/pull/98403
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mai
https://github.com/dzhidzhoev updated
https://github.com/llvm/llvm-project/pull/99532
>From 17f92b90fff5132960037997b0ace4c17aaf93df Mon Sep 17 00:00:00 2001
From: Vladislav Dzhidzhoev
Date: Thu, 18 Jul 2024 19:27:55 +0200
Subject: [PATCH] [LLDB][test] Improve SHELL detection on Windows in
Mak
https://github.com/dzhidzhoev edited
https://github.com/llvm/llvm-project/pull/99532
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/dzhidzhoev edited
https://github.com/llvm/llvm-project/pull/99532
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
dzhidzhoev wrote:
Sorry, the initial issue this commit resolves was identified wrongly, fixed the
commit description.
https://github.com/llvm/llvm-project/pull/99532
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-
https://github.com/dzhidzhoev edited
https://github.com/llvm/llvm-project/pull/99532
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/dzhidzhoev edited
https://github.com/llvm/llvm-project/pull/99532
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/dzhidzhoev edited
https://github.com/llvm/llvm-project/pull/99266
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
bob80905 wrote:
Just an FYI, the syntax for adding a resource_class attribute as currently
implemented looks like this:
`[[hlsl::resource_class(SRV)]]`
In your description, you may want to update this and other similar attributes.
https://github.com/llvm/llvm-project/pull/97362
Author: Jacob Lalonde
Date: 2024-07-18T17:10:15-07:00
New Revision: 4120570dc408a6ccc7133b4bdbaf5cf6c4af9db7
URL:
https://github.com/llvm/llvm-project/commit/4120570dc408a6ccc7133b4bdbaf5cf6c4af9db7
DIFF:
https://github.com/llvm/llvm-project/commit/4120570dc408a6ccc7133b4bdbaf5cf6c4af9db7.diff
https://github.com/Jlalond closed
https://github.com/llvm/llvm-project/pull/98403
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/dzhidzhoev created
https://github.com/llvm/llvm-project/pull/99589
This commit fixes an undefined reference linking problem with cross-compilation
and remote testing on Linux host-Linux target configuration, that occurs when
libcxx is linked statically.
Many tests fail with
@@ -432,18 +468,18 @@ ifeq (1,$(USE_LIBCPP))
ifneq "$(LIBCPP_INCLUDE_TARGET_DIR)" ""
CXXFLAGS += -cxx-isystem
$(LIBCPP_INCLUDE_TARGET_DIR)
endif
- LDFLAGS += -L$(LIBCPP_LIBRARY_DIR)
-Wl,-rpath,$(LIBCPP
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `lldb-x86_64-debian`
running on `lldb-x86_64-debian` while building `lldb` at step 6 "test".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/162/builds/2381
Here is the relevant piece of the build log f
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `lldb-aarch64-ubuntu`
running on `linaro-lldb-aarch64-ubuntu` while building `lldb` at step 6 "test".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/59/builds/1824
Here is the relevant piece of the bui
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `lldb-arm-ubuntu` running
on `linaro-lldb-arm-ubuntu` while building `lldb` at step 6 "test".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/18/builds/1036
Here is the relevant piece of the build log f
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `lldb-aarch64-windows`
running on `linaro-armv8-windows-msvc-05` while building `lldb` at step 6
"test".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/141/builds/897
Here is the relevant piece of the
dlav-sc wrote:
> > I have also removed `.Cases(".bss", ".tbss", eSectionTypeZeroFill)`.
> > To be honest, I'm not sure about that. .bss and .tbss have SHT_NOBITS type
> > and SHF_ALLOC flag by [Linux
> > Specification](https://refspecs.linuxbase.org/LSB_3.1.1/LSB-Core-generic/LSB-Core-generic/s
Jlalond wrote:
Reverted locally and still got consistent failures. @jimingham should I file an
issue here?
https://github.com/llvm/llvm-project/pull/98403
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Vladislav Dzhidzhoev (dzhidzhoev)
Changes
This commit fixes an undefined reference linking problem with cross-compilation
and remote testing on Linux host-Linux target configuration, that occurs when
libcxx is linked statically.
Many test
https://github.com/ChuanqiXu9 created
https://github.com/llvm/llvm-project/pull/99599
Close https://github.com/llvm/llvm-project/issues/99479
See https://github.com/llvm/llvm-project/issues/99479 for details
>From 36e24bd88649e9d5771f1dbb668632d33ffe52d7 Mon Sep 17 00:00:00 2001
From: Chuanqi
llvmbot wrote:
@llvm/pr-subscribers-clang-modules
Author: Chuanqi Xu (ChuanqiXu9)
Changes
Close https://github.com/llvm/llvm-project/issues/99479
See https://github.com/llvm/llvm-project/issues/99479 for details
---
Full diff: https://github.com/llvm/llvm-project/pull/99599.diff
16 Fil
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 962d018234cb8c94e387fe3950cd030658850541
36e24bd88649e9d5771f1dbb668632d33ffe52d7 --e
@@ -0,0 +1,58 @@
+//===--- DirectToIndirectFCR.h - RISC-V specific pass
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
jasonmolenda wrote:
I'd describe this patch as handling the case where a remote stub cannot jit
memory and has a qMemoryRegion info packet which does not specify permissions.
The patch you reference makes jitted code expressions work, but I think
IRMemoryMap::FindSpec only needs to find space
jasonmolenda wrote:
A quick look at the RISCV ISA and it says that the JAL instruction is pc
relative and can jump +/- 1MB. JALR is also pc-relative but it gets the upper
20 bits from a general purpose register and it includes 12 low bits in its
instruction encoding. I know almost nothing ab
jasonmolenda wrote:
As for getting to the jitted code, of course lldb sets the pc directly so that
initial switch from user code to jitted code region is fine. But getting from
the jitted wrapper function to the user functions we need to call would require
JALR instructions?
https://github.c
66 matches
Mail list logo
