jimingham wrote:
It's been a long time since I've looked at this code, but the change to return
a 0 value rather than an error seems consistent at least.
Was there no way to test this?
https://github.com/llvm/llvm-project/pull/93548
___
lldb-commits
https://github.com/clayborg approved this pull request.
https://github.com/llvm/llvm-project/pull/93836
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Miro Bucko
Date: 2024-05-30T10:38:21-07:00
New Revision: 48175a5d9f62f0586c04e5a742dafa5e1943f19c
URL:
https://github.com/llvm/llvm-project/commit/48175a5d9f62f0586c04e5a742dafa5e1943f19c
DIFF:
https://github.com/llvm/llvm-project/commit/48175a5d9f62f0586c04e5a742dafa5e1943f19c.diff
LO
https://github.com/clayborg closed
https://github.com/llvm/llvm-project/pull/93836
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,142 @@
+"""
+Test lldb-dap "port" configuration to "attach" request
+"""
+
+
+import dap_server
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+from lldbsuite.test import lldbplatformutil
+import lldb
labath wrote:
It might be better to split this up per flag. For example, I don't see any
issues with the --make flag, but I would like to understand more about why you
need the --os flag (like, how it differs/why can't that be deduced from the
platform name?) The sysroot arg is probably also f
ayermolo wrote:
> One easy question would be: do you/your users use -fdebug-types-section? If
> so, that'd probably explain what you were seeing & you could add some test
> coverage for that wherever you like (in lldb, presumably, maybe in bolt too).
> But if you/they don't, then it's unclear
JDevlieghere wrote:
GreenDragon now has `packaging` and based on David's message, the Linaro bots
do as well.
@labath Does your ✅ mean the
[debian](https://lab.llvm.org/buildbot/#/builders/68) bot has this package
installed?
@mysterymath Can you install this package on the Fuchia bots? I as
https://github.com/mbucko created
https://github.com/llvm/llvm-project/pull/93871
Summary:
Test llvm-project/lldb/test/API/python_api/address_range/TestAddressRange.py is
failing on Windows due adding a carriage return character at the end of line.
Original PR is #93836.
Test Plan:
llvm-lit -
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Miro Bucko (mbucko)
Changes
Summary:
Test llvm-project/lldb/test/API/python_api/address_range/TestAddressRange.py is
failing on Windows due adding a carriage return character at the end of line.
Original PR is #93836.
Test Plan:
llvm-lit
https://github.com/royitaqi updated
https://github.com/llvm/llvm-project/pull/92843
>From 8499f16ad46b3268f35da2bfcbfa02a10aab935a Mon Sep 17 00:00:00 2001
From: Roy Shi
Date: Mon, 20 May 2024 22:30:40 -0400
Subject: [PATCH 1/9] Add resolvedCommand to transcript, add transcript to
statistics d
@@ -362,6 +363,36 @@ llvm::json::Value DebuggerStats::ReportStatistics(
global_stats.try_emplace("modules", std::move(json_modules));
global_stats.try_emplace("memory", std::move(json_memory));
global_stats.try_emplace("commands", std::move(cmd_stats));
+
+// Wh
@@ -320,10 +320,13 @@ class SBCommandInterpreter {
/// Returns a list of handled commands, output and error. Each element in
/// the list is a dictionary with the following keys/values:
- /// - "command" (string): The command that was executed.
+ /// - "command" (string)
mysterymath wrote:
We don't have `pexpect` either; instead the tests that require it are disabled.
Our build is as hermetic as possible; even if the package were available in the
Python on the bots, we wouldn't be able to use it, since we don't make use of
the Python on the bots, for the most
felipepiovezan wrote:
> @felipepiovezan I have another question. For the same example. I see:
>
> ```
> Name 4 {
> Hash: 0x2F94396D
> String: 0x0049 "_Z9get_statev"
> Entry @ 0x112 {
> Abbrev: 0x2
> Tag: DW_TAG_subprogram
> DW_IDX_die_offset: 0x0
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/93871
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/clayborg requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/93871
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -191,7 +191,7 @@ def test_address_range_print_resolved(self):
interp.HandleCommand(script, result, False)
self.assertTrue(result.Succeeded(), "script command succeeded")
# [0x1000-0x2000] // Resolved with target or addresses without sections
-
@@ -191,7 +191,7 @@ def test_address_range_print_resolved(self):
interp.HandleCommand(script, result, False)
self.assertTrue(result.Succeeded(), "script command succeeded")
# [0x1000-0x2000] // Resolved with target or addresses without sections
-
https://github.com/mbucko updated
https://github.com/llvm/llvm-project/pull/93871
>From afcd5a2524fc27cab2ff55ffba06cc19c62bbc4e Mon Sep 17 00:00:00 2001
From: Miro Bucko
Date: Thu, 30 May 2024 13:04:17 -0700
Subject: [PATCH] [lldb][test] Fix failing test TestAddressRange.py
Summary:
Test llvm
@@ -1425,4 +1425,6 @@ let Command = "statistics dump" in {
Desc<"Dump the total possible debug info statistics. "
"Force loading all the debug information if not yet loaded, and collect "
"statistics with those.">;
+ def statistics_dump_transcript: Option<"transcri
https://github.com/clayborg approved this pull request.
https://github.com/llvm/llvm-project/pull/93871
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Miro Bucko
Date: 2024-05-30T13:44:51-07:00
New Revision: 493eefc93f2901dd987b8ff441004352b317cab9
URL:
https://github.com/llvm/llvm-project/commit/493eefc93f2901dd987b8ff441004352b317cab9
DIFF:
https://github.com/llvm/llvm-project/commit/493eefc93f2901dd987b8ff441004352b317cab9.diff
LO
https://github.com/clayborg closed
https://github.com/llvm/llvm-project/pull/93871
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ayermolo wrote:
> > @felipepiovezan I have another question. For the same example. I see:
>
> You are right. The fact that they have the same relative offset tells me that
> some part of the code is failing to account for TUs. I just checked the
> printing code in the hope that it was a mistak
https://github.com/jimingham created
https://github.com/llvm/llvm-project/pull/93880
But one made in a situation where that's impossible might only have an error,
and no symbol context, so that's not necessarily true. Check for the target's
validity before using it.
Fixes issue #93313
>From
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (jimingham)
Changes
But one made in a situation where that's impossible might only have an error,
and no symbol context, so that's not necessarily true. Check for the target's
validity before using it.
Fixes issue #93313
---
Full d
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
6abc3876c35bbe8fb5dd6435dc60f2c816b97ef6...007bab454cd9aa2c73ce167ee15900523d3b7318
lldb/
https://github.com/medismailben approved this pull request.
LGTM with @labath's command.
https://github.com/llvm/llvm-project/pull/93833
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm
https://github.com/kastiglione created
https://github.com/llvm/llvm-project/pull/93881
None
>From 21a61a1a5ae68fc1e913f73c4311258675990f95 Mon Sep 17 00:00:00 2001
From: Dave Lee
Date: Thu, 30 May 2024 13:29:41 -0700
Subject: [PATCH] [lldb] Improve identification of Dlang mangled names
---
l
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dave Lee (kastiglione)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/93881.diff
4 Files Affected:
- (modified) lldb/source/Core/Mangled.cpp (+9-2)
- (added) lldb/test/API/lang/c/non-mangled/Makefile (+4)
- (added) l
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
f795853d1f77bff69c3805f75e54fa7a32cc23d9...21a61a1a5ae68fc1e913f73c4311258675990f95
lldb/
https://github.com/kastiglione edited
https://github.com/llvm/llvm-project/pull/93881
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kastiglione updated
https://github.com/llvm/llvm-project/pull/93881
>From 21a61a1a5ae68fc1e913f73c4311258675990f95 Mon Sep 17 00:00:00 2001
From: Dave Lee
Date: Thu, 30 May 2024 13:29:41 -0700
Subject: [PATCH 1/2] [lldb] Improve identification of Dlang mangled names
---
lld
https://github.com/jeffreytan81 updated
https://github.com/llvm/llvm-project/pull/90930
>From e7823321c1b7e23b077a0b785af50d641fc9a6b7 Mon Sep 17 00:00:00 2001
From: jeffreytan81
Date: Thu, 2 May 2024 18:12:04 -0700
Subject: [PATCH 1/5] Single thread timeout feature
---
lldb/include/lldb/Targ
https://github.com/jimingham approved this pull request.
This a little bit raises the question why we don't do the same checks for `_R`
and `_Z`.
It would be even better if the various demanglers in llvm had a quick "could
this be mine" check so we didn't have to encode this in lldb.
But you
https://github.com/dzhidzhoev created
https://github.com/llvm/llvm-project/pull/93883
This argument allows to specify the path to make which is used by LLDB API
tests to compile test programs.
It might come in handy for setting up cross-platform remote runs of API tests
on Windows host.
It ca
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Vladislav Dzhidzhoev (dzhidzhoev)
Changes
This argument allows to specify the path to make which is used by LLDB API
tests to compile test programs.
It might come in handy for setting up cross-platform remote runs of API tests
on Windows h
kastiglione wrote:
> This a little bit raises the question why we don't do the same checks for
> `_R` and `_Z`.
I asked myself the same. Turns out Rust doesn't have a number following the
`_R` prefix, so it's not as simple. Given that C++ is much more load bearing, I
didn't want to include ch
MaskRay wrote:
Consider copying the original description to ensure that the linked issues will
be properly closed.
https://github.com/llvm/llvm-project/pull/93889
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin
https://github.com/MaskRay approved this pull request.
https://github.com/llvm/llvm-project/pull/93889
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jimingham wrote:
> Also, something to keep in mind: If Dlang ever decides to change their
> mangled name scheme in the future, this change may become wrong then. I'm not
> sure what commitments the D language project has for their ABI stability
> though.
That's why this shouldn't be in lldb i
mysterymath wrote:
Did a bit of digging around; it looks like at the very least the Arch Linux
python package and the Python docker container don't contain the `packaging`
library.
https://github.com/llvm/llvm-project/pull/93712
___
lldb-commits mai
https://github.com/aaronmondal edited
https://github.com/llvm/llvm-project/pull/93889
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/aaronmondal closed
https://github.com/llvm/llvm-project/pull/93889
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Aaron Siddhartha Mondal
Date: 2024-05-31T01:29:00+02:00
New Revision: 852aaf54071ad072335dcac57f544d4da34c875a
URL:
https://github.com/llvm/llvm-project/commit/852aaf54071ad072335dcac57f544d4da34c875a
DIFF:
https://github.com/llvm/llvm-project/commit/852aaf54071ad072335dcac57f544d4da34c
https://github.com/AlexeyMerzlyakov edited
https://github.com/llvm/llvm-project/pull/93297
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/AlexeyMerzlyakov edited
https://github.com/llvm/llvm-project/pull/93297
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,84 @@
+//===-- RegisterContextPOSIXCore_riscv64.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
jasonmolenda wrote:
This patch look good to me, do you have necessary permissions to squash & merge?
https://github.com/llvm/llvm-project/pull/93297
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listin
Author: Nikita Popov
Date: 2024-05-31T08:18:35+02:00
New Revision: 71ccd0d8ccf876e32e21514839195f159642fe4c
URL:
https://github.com/llvm/llvm-project/commit/71ccd0d8ccf876e32e21514839195f159642fe4c
DIFF:
https://github.com/llvm/llvm-project/commit/71ccd0d8ccf876e32e21514839195f159642fe4c.diff
https://github.com/nikic closed https://github.com/llvm/llvm-project/pull/93548
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
101 - 152 of 152 matches
Mail list logo
