https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/74773
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -130,6 +130,10 @@ class PluginProperties : public Properties {
}
};
+bool IsTypeTag(llvm::dwarf::Tag Tag) {
clayborg wrote:
Make static and rename to `IsClassOrStructType`. There are many other type tags
in DWARF, so this doesn't make it clear that this
@@ -3128,36 +3121,11 @@
SymbolFileDWARF::FindDefinitionTypeForDWARFDeclContext(const DWARFDIE &die) {
if (type_system &&
!type_system->SupportsLanguage(GetLanguage(*type_die.GetCU(
return true;
- bool try_resolving_type = false;
- // Don
https://github.com/clayborg requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/74773
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -56,10 +56,10 @@ namespace Foo = A::B; // namespace alias
using Foo::myfunc; // using declaration
-using namespace Foo;// using directive
+//removing namespace foo; for quality naming
Michael137 wrote:
The `using` directive was used here to ma
@@ -56,10 +56,10 @@ namespace Foo = A::B; // namespace alias
using Foo::myfunc; // using declaration
-using namespace Foo;// using directive
+//removing namespace foo; for quality naming
jeevanghimire wrote:
but it can create confusion if we just
@@ -2225,7 +2225,8 @@ void ObjectFileMachO::ParseSymtab(Symtab &symtab) {
const char *file_name = file.GetFilename().AsCString("");
LLDB_SCOPED_TIMERF("ObjectFileMachO::ParseSymtab () module = %s", file_name);
LLDB_LOG(log, "Parsing symbol table for {0}", file_name);
- P
@@ -2225,7 +2225,8 @@ void ObjectFileMachO::ParseSymtab(Symtab &symtab) {
const char *file_name = file.GetFilename().AsCString("");
LLDB_SCOPED_TIMERF("ObjectFileMachO::ParseSymtab () module = %s", file_name);
LLDB_LOG(log, "Parsing symbol table for {0}", file_name);
- P
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/74818
The `expect_expr` check was introduced in
https://github.com/llvm/llvm-project/pull/74772. It is failing on Linux and
Windows, so skip this test to unblock the bots
>From 32b8d4102f73f7b42792f9c817742d1eba62
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
The `expect_expr` check was introduced in
https://github.com/llvm/llvm-project/pull/74772. It is failing on Linux and
Windows, so skip this test to unblock the bots
---
Full diff: https://github.com/llvm/
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/74818
>From 32b8d4102f73f7b42792f9c817742d1eba629351 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Fri, 8 Dec 2023 08:51:32 +
Subject: [PATCH 1/2] [lldb][test] TestLocationListLookup.py: skip expr check
on
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/74818
>From 32b8d4102f73f7b42792f9c817742d1eba629351 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Fri, 8 Dec 2023 08:51:32 +
Subject: [PATCH 1/3] [lldb][test] TestLocationListLookup.py: skip expr check
on
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
c340cf0a353cd6d1090297cf84caf2720d1c7d90...9f71e25c3729962da0ad9697ae077adb04e2b7f9
lldb/
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/74818
>From 32b8d4102f73f7b42792f9c817742d1eba629351 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Fri, 8 Dec 2023 08:51:32 +
Subject: [PATCH 1/4] [lldb][test] TestLocationListLookup.py: skip expr check
on
DavidSpickett wrote:
> doesn't appear to be anything that calls these methods
Candidate for removal then? If so it still makes sense to fix them, then remove
them. Saves fixing them again if they are brought back.
Either way, I'm not going to block this by requiring a test case.
https://githu
=?utf-8?q?José?= L. Junior ,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102 <23100...@lums.edu.pk>,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?=
https://github.com/DavidSpickett approved this pull request.
Not 100% that the skips are going to work for AArch64 but I'll fix that if it
is the case.
https://github.com/llvm/llvm-project/pull/74818
___
lldb-commits mailing list
lldb-commits@lists.ll
Author: Michael Buch
Date: 2023-12-08T10:09:38Z
New Revision: 11a7e5781c6363ca3061f57f3aa7e49164673821
URL:
https://github.com/llvm/llvm-project/commit/11a7e5781c6363ca3061f57f3aa7e49164673821
DIFF:
https://github.com/llvm/llvm-project/commit/11a7e5781c6363ca3061f57f3aa7e49164673821.diff
LOG:
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/74818
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
My intent when asking for this link was that links to the README of lldb-vscode
would end up going to the README of lldb-dap (maybe the wrong section, but at
least you'd know the name had changed). The audience for it is small but I
didn't want to make it even smaller by g
Author: Mikhail Goncharov
Date: 2023-12-08T11:39:10+01:00
New Revision: e33302fa1279d0a15aac18eca3f0311669bfe328
URL:
https://github.com/llvm/llvm-project/commit/e33302fa1279d0a15aac18eca3f0311669bfe328
DIFF:
https://github.com/llvm/llvm-project/commit/e33302fa1279d0a15aac18eca3f0311669bfe328.d
Author: Mikhail Goncharov
Date: 2023-12-08T11:43:14+01:00
New Revision: b43ab182040f7c3b43e37ade7af600af1c9b3dfd
URL:
https://github.com/llvm/llvm-project/commit/b43ab182040f7c3b43e37ade7af600af1c9b3dfd
DIFF:
https://github.com/llvm/llvm-project/commit/b43ab182040f7c3b43e37ade7af600af1c9b3dfd.d
@@ -340,8 +340,13 @@ Value *VPInstruction::generateInstruction(VPTransformState
&State,
auto *Phi = State.get(getOperand(0), 0);
// The loop step is equal to the vectorization factor (num of SIMD
// elements) times the unroll factor (num of SIMD instructions)
DavidSpickett wrote:
It was not the case, all green again!
https://github.com/llvm/llvm-project/pull/74818
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: taalhaataahir0102
Date: 2023-12-08T11:09:04Z
New Revision: c90cb6eee8296953c097fcc9fc6e61f739c0dad3
URL:
https://github.com/llvm/llvm-project/commit/c90cb6eee8296953c097fcc9fc6e61f739c0dad3
DIFF:
https://github.com/llvm/llvm-project/commit/c90cb6eee8296953c097fcc9fc6e61f739c0dad3.diff
=?utf-8?q?José?= L. Junior ,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102 <23100...@lums.edu.pk>,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?=
=?utf-8?q?José?= L. Junior ,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102 <23100...@lums.edu.pk>,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?=
Author: David Spickett
Date: 2023-12-08T11:24:07Z
New Revision: ffd61c1e96e9c8a472f305585930b45be0d639d3
URL:
https://github.com/llvm/llvm-project/commit/ffd61c1e96e9c8a472f305585930b45be0d639d3
DIFF:
https://github.com/llvm/llvm-project/commit/ffd61c1e96e9c8a472f305585930b45be0d639d3.diff
LOG
=?utf-8?q?José?= L. Junior ,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102 <23100...@lums.edu.pk>,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?=
https://github.com/fhahn closed https://github.com/llvm/llvm-project/pull/74762
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
=?utf-8?q?José?= L. Junior ,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102 <23100...@lums.edu.pk>,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?=
https://github.com/fhahn edited https://github.com/llvm/llvm-project/pull/74761
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: David Spickett
Date: 2023-12-08T13:34:07Z
New Revision: ce3c7c09100803608177459b4d923f17742885f9
URL:
https://github.com/llvm/llvm-project/commit/ce3c7c09100803608177459b4d923f17742885f9
DIFF:
https://github.com/llvm/llvm-project/commit/ce3c7c09100803608177459b4d923f17742885f9.diff
LOG
@@ -3128,36 +3121,11 @@
SymbolFileDWARF::FindDefinitionTypeForDWARFDeclContext(const DWARFDIE &die) {
if (type_system &&
!type_system->SupportsLanguage(GetLanguage(*type_die.GetCU(
return true;
- bool try_resolving_type = false;
- // Don
@@ -130,6 +130,10 @@ class PluginProperties : public Properties {
}
};
+bool IsTypeTag(llvm::dwarf::Tag Tag) {
felipepiovezan wrote:
I'll rename it.
Regarding static, this function as well as most functions defined above it, are
in an anonymous namespace
https://github.com/felipepiovezan edited
https://github.com/llvm/llvm-project/pull/74773
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan edited
https://github.com/llvm/llvm-project/pull/74773
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: David Spickett
Date: 2023-12-08T13:36:41Z
New Revision: 810d09faf89af53025205c540ef9980e2286e687
URL:
https://github.com/llvm/llvm-project/commit/810d09faf89af53025205c540ef9980e2286e687
DIFF:
https://github.com/llvm/llvm-project/commit/810d09faf89af53025205c540ef9980e2286e687.diff
LOG
Author: David Spickett
Date: 2023-12-08T13:44:06Z
New Revision: 61f18255fab3c404dc43a59091a750c22e5d0ccb
URL:
https://github.com/llvm/llvm-project/commit/61f18255fab3c404dc43a59091a750c22e5d0ccb
DIFF:
https://github.com/llvm/llvm-project/commit/61f18255fab3c404dc43a59091a750c22e5d0ccb.diff
LOG
=?utf-8?q?José?= L. Junior ,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102 <23100...@lums.edu.pk>,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?=
@@ -130,6 +130,10 @@ class PluginProperties : public Properties {
}
};
+bool IsTypeTag(llvm::dwarf::Tag Tag) {
felipepiovezan wrote:
Do you prefer if I take it out of the namespace and make it static? In
llvm-project/llvm I would have done because of the p
https://github.com/felipepiovezan edited
https://github.com/llvm/llvm-project/pull/74773
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -56,10 +56,10 @@ namespace Foo = A::B; // namespace alias
using Foo::myfunc; // using declaration
-using namespace Foo;// using directive
+//removing namespace foo; for quality naming
felipepiovezan wrote:
Hi @jeevanghimire, please note that t
@@ -34,7 +34,7 @@ namespace A {
int myfunc (int a);
int myfunc2(int a)
{
- return a + 2;
+return a + 2; //just changing tab not much
felipepiovezan wrote:
In general, we don't add diffs that are unrelated to
https://github.com/felipepiovezan requested changes to this pull request.
Hi @jeevanghimire, thank you for the PR! I believe the original issue was not
about changing LLVM test inputs, but rather about changing clang-tidy to warn
about this kind of patterns.
Please see my rationale in a previo
@@ -959,6 +967,32 @@ def : GCNPat <
}
} // let OtherPredicates = [HasShaderCyclesRegister]
+def SIMM24bitPtr : ImmLeaf (Imm);}]
+>;
+
+multiclass SMPrefetchPat {
+ def : GCNPat <
+(smrd_prefetch (SMRDImm i64:$sbase, i32:$offset), timm, timm, (i32
cache_type)),
+(!cas
https://github.com/felipepiovezan edited
https://github.com/llvm/llvm-project/pull/74773
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan updated
https://github.com/llvm/llvm-project/pull/74773
>From 9f38564875620a44a982a50492d87ee431baffcd Mon Sep 17 00:00:00 2001
From: Felipe de Azevedo Piovezan
Date: Thu, 7 Dec 2023 13:41:44 -0800
Subject: [PATCH 1/3] [SymbolFileDWARF][NFC] Remove duplicated c
@@ -130,6 +130,10 @@ class PluginProperties : public Properties {
}
};
+bool IsTypeTag(llvm::dwarf::Tag Tag) {
felipepiovezan wrote:
In the interest of expediency, I've moved it out of the anonymous namespace and
made it static
https://github.com/llvm/llv
=?utf-8?q?José?= L. Junior ,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102 <23100...@lums.edu.pk>,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?=
felipepiovezan wrote:
I am really struggling to handle the scope of the changes here, IIUC there are
a handful of changes that could be split into separate commits and merged
independently of each other: there is some code being moved around, new
GetCompilerContext APIs, the new query, the rep
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/74808
>From d544ba0cc6836c0b5c2086edccfc2b41080174ef Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Fri, 8 Dec 2023 00:11:19 -0500
Subject: [PATCH] [lldb-dap] Implement quiet commands
This adds support
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/74808
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/74808
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo created
https://github.com/llvm/llvm-project/pull/74861
Currently there's an include in which `[opt]` might be emitted twice if the
frame format also asks for it. As a trivial fix, we should manually emit
`[opt]` only if a custom frame format is not specifie
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Walter Erquinigo (walter-erquinigo)
Changes
Currently there's an include in which `[opt]` might be emitted twice if the
frame format also asks for it. As a trivial fix, we should manually emit
`[opt]` only if a custom frame format is not s
adrian-prantl wrote:
> > doesn't appear to be anything that calls these methods
>
> Candidate for removal then? If so it still makes sense to fix them, then
> remove them. Saves fixing them again if they are brought back.
>
> Either way, I'm not going to block this by requiring a test case.
I
https://github.com/walter-erquinigo created
https://github.com/llvm/llvm-project/pull/74865
This is an extension to the protocol that emits the declaration information
along with the metadata of each variable. This can be used by vscode extensions
to implement, for example, a "goToDefinition"
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Walter Erquinigo (walter-erquinigo)
Changes
This is an extension to the protocol that emits the declaration information
along with the metadata of each variable. This can be used by vscode extensions
to implement, for example, a "goToDefin
https://github.com/clayborg approved this pull request.
Thanks for the quick change, and I need to check sources for the anonymous
namespace before I comment next time!
https://github.com/llvm/llvm-project/pull/74773
___
lldb-commits mailing list
lldb
clayborg wrote:
> I am really struggling to handle the scope of the changes here, IIUC there
> are a handful of changes that could be split into separate commits and merged
> independently of each other: there is some code being moved around, new
> GetCompilerContext APIs, the new query, the r
@@ -959,6 +967,32 @@ def : GCNPat <
}
} // let OtherPredicates = [HasShaderCyclesRegister]
+def SIMM24bitPtr : ImmLeaf (Imm);}]
+>;
+
+multiclass SMPrefetchPat {
+ def : GCNPat <
+(smrd_prefetch (SMRDImm i64:$sbase, i32:$offset), timm, timm, (i32
cache_type)),
+(!cas
https://github.com/fhahn closed https://github.com/llvm/llvm-project/pull/74761
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -8,10 +8,7 @@
// UNSUPPORTED: c++03, c++11, c++14, c++17
-// sentinel() = default;
-// constexpr explicit sentinel(sentinel_t end);
-// constexpr sentinel(sentinel s)
-// requires Const && convertible_to, sentinel_t>;
+// constexpr sentinel_t base() const;
--
https://github.com/oltolm updated
https://github.com/llvm/llvm-project/pull/74731
>From 9383b8b92849c71a96b4b4e7e55f615d8f2efedb Mon Sep 17 00:00:00 2001
From: oltolm
Date: Fri, 1 Dec 2023 16:49:13 +0100
Subject: [PATCH 1/2] lldb: add support for thread names on Windows
---
.../Windows/Common
PortalPete wrote:
> > > doesn't appear to be anything that calls these methods
> >
> >
> > Candidate for removal then? If so it still makes sense to fix them, then
> > remove them. Saves fixing them again if they are brought back.
> > Either way, I'm not going to block this by requiring a test
oltolm wrote:
I have added a test.
https://github.com/llvm/llvm-project/pull/74731
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan approved this pull request.
https://github.com/llvm/llvm-project/pull/74413
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -2225,7 +2225,8 @@ void ObjectFileMachO::ParseSymtab(Symtab &symtab) {
const char *file_name = file.GetFilename().AsCString("");
LLDB_SCOPED_TIMERF("ObjectFileMachO::ParseSymtab () module = %s", file_name);
LLDB_LOG(log, "Parsing symbol table for {0}", file_name);
- P
@@ -2225,7 +2225,8 @@ void ObjectFileMachO::ParseSymtab(Symtab &symtab) {
const char *file_name = file.GetFilename().AsCString("");
LLDB_SCOPED_TIMERF("ObjectFileMachO::ParseSymtab () module = %s", file_name);
LLDB_LOG(log, "Parsing symbol table for {0}", file_name);
- P
https://github.com/jroelofs updated
https://github.com/llvm/llvm-project/pull/73686
>From bc152095691b32d1ad8539dfd60f5089df5eed8d Mon Sep 17 00:00:00 2001
From: Jon Roelofs
Date: Tue, 28 Nov 2023 10:39:44 -0800
Subject: [PATCH 01/10] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20?=
=?UTF
https://github.com/jroelofs updated
https://github.com/llvm/llvm-project/pull/73686
>From bc152095691b32d1ad8539dfd60f5089df5eed8d Mon Sep 17 00:00:00 2001
From: Jon Roelofs
Date: Tue, 28 Nov 2023 10:39:44 -0800
Subject: [PATCH 01/10] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20?=
=?UTF
adrian-prantl wrote:
Sorry, it's been a while since I last reviewed this and I must admit I forgot
about this in the mean time. The only thing I'd like to check before we can
land this is to hear from @Michael137 who has been actively working on
FindTypes performance recently whether this alig
https://github.com/jroelofs updated
https://github.com/llvm/llvm-project/pull/73686
>From bc152095691b32d1ad8539dfd60f5089df5eed8d Mon Sep 17 00:00:00 2001
From: Jon Roelofs
Date: Tue, 28 Nov 2023 10:39:44 -0800
Subject: [PATCH 01/11] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20?=
=?UTF
https://github.com/jimingham created
https://github.com/llvm/llvm-project/pull/74894
When you debug a binary and the change & rebuild and then rerun in lldb w/o
quitting lldb, the Modules in the Global Module Cache for the old binary & .o
files if used are now "unreachable". Nothing in lldb i
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (jimingham)
Changes
When you debug a binary and the change & rebuild and then rerun in lldb w/o
quitting lldb, the Modules in the Global Module Cache for the old binary &
.o files if used are now "unreachable". Nothing in lldb is hol
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 44dc1e0baae7c4b8a02ba06dcf396d3d452aa873
438d35a7a7fca454718062583f91776ca018b2b1 --
https://github.com/ayalz edited https://github.com/llvm/llvm-project/pull/74762
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -340,8 +340,14 @@ Value *VPInstruction::generateInstruction(VPTransformState
&State,
auto *Phi = State.get(getOperand(0), 0);
// The loop step is equal to the vectorization factor (num of SIMD
// elements) times the unroll factor (num of SIMD instructions)
https://github.com/ayalz commented:
post-commit nit
https://github.com/llvm/llvm-project/pull/74762
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jimingham wrote:
Note, I thought about adding an SBDebugger::GetSharedModules or something, but
I don't actually think that's a good thing to give external access to. Some
day we should make an SBTestAPI with some useful for testing but not for the SB
API library so we can make this sort of t
https://github.com/bulbazord approved this pull request.
TIL about this overload of `llvm::interleave`!!!
https://github.com/llvm/llvm-project/pull/74788
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/l
@@ -33,14 +39,49 @@ void RunLLDBCommands(llvm::StringRef prefix,
const char *error = result.GetError();
strm << error;
}
+ };
+
+ lldb::SBCommandInterpreter interp = g_dap.debugger.GetCommandInterpreter();
+ for (llvm::StringRef command : commands) {
+lld
https://github.com/bulbazord commented:
I think conceptually this makes sense, but I somewhat wonder if folks would get
confused when they have a custom frame format and don't see the [opt] in there?
The current behavior is that [opt] is always there so folks know they don't
have to put it in
@@ -1101,6 +1101,29 @@ std::string
CreateUniqueVariableNameForDisplay(lldb::SBValue v,
// can use this optional information to present the
// children in a paged UI and fetch them in chunks."
// }
+// "declaration": {
+//
https://github.com/jroelofs updated
https://github.com/llvm/llvm-project/pull/73686
>From bc152095691b32d1ad8539dfd60f5089df5eed8d Mon Sep 17 00:00:00 2001
From: Jon Roelofs
Date: Tue, 28 Nov 2023 10:39:44 -0800
Subject: [PATCH 01/11] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20?=
=?UTF
jimingham wrote:
Would it make sense to have opt be the result of a frame-format token, which we
could put in the default format (function.optimization?) and people could add
or not in custom formats?
Jim
> On Dec 8, 2023, at 3:59 PM, Alex Langford ***@***.***> wrote:
>
>
> @bulbazord comme
@@ -33,14 +39,49 @@ void RunLLDBCommands(llvm::StringRef prefix,
const char *error = result.GetError();
strm << error;
}
+ };
+
+ lldb::SBCommandInterpreter interp = g_dap.debugger.GetCommandInterpreter();
+ for (llvm::StringRef command : commands) {
+lld
@@ -1101,6 +1101,29 @@ std::string
CreateUniqueVariableNameForDisplay(lldb::SBValue v,
// can use this optional information to present the
// children in a paged UI and fetch them in chunks."
// }
+// "declaration": {
+//
https://github.com/PortalPete created
https://github.com/llvm/llvm-project/pull/74912
Many methods return `nullptr` or `ValueObjectSP()` to represent an invalid
result.
For methods that have a `Status &error` parameter and return an
`ValueObjectSP`, the return value *becomes* the container
https://github.com/PortalPete edited
https://github.com/llvm/llvm-project/pull/74912
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/PortalPete edited
https://github.com/llvm/llvm-project/pull/74912
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/PortalPete edited
https://github.com/llvm/llvm-project/pull/74912
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/74808
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -33,14 +39,49 @@ void RunLLDBCommands(llvm::StringRef prefix,
const char *error = result.GetError();
strm << error;
}
+ };
+
+ lldb::SBCommandInterpreter interp = g_dap.debugger.GetCommandInterpreter();
+ for (llvm::StringRef command : commands) {
+lld
@@ -13,16 +13,22 @@ namespace lldb_dap {
void RunLLDBCommands(llvm::StringRef prefix,
const llvm::ArrayRef &commands,
- llvm::raw_ostream &strm) {
+ llvm::raw_ostream &strm, bool parse_command_directives) {
if (co
@@ -33,9 +39,14 @@ namespace lldb_dap {
/// \param[in] strm
/// The stream that will receive the prefix, prompt + command and
/// all command output.
+///
+/// \param[in] parse_command_directives
+/// If \b false, then command prefixes like \b ! or \b ? are not pars
https://github.com/clayborg requested changes to this pull request.
I would rather not terminate the debug session if we get erorrs on `!`. It
would be nice if the `RunLLDBCommands` function could take an extra `bool
&fatal_error` that clients could check after running when needed to decide wh
@@ -13,16 +13,22 @@ namespace lldb_dap {
void RunLLDBCommands(llvm::StringRef prefix,
const llvm::ArrayRef &commands,
- llvm::raw_ostream &strm) {
+ llvm::raw_ostream &strm, bool parse_command_directives) {
-
@@ -33,14 +39,49 @@ void RunLLDBCommands(llvm::StringRef prefix,
const char *error = result.GetError();
strm << error;
}
+ };
+
+ lldb::SBCommandInterpreter interp = g_dap.debugger.GetCommandInterpreter();
+ for (llvm::StringRef command : commands) {
+lld
1 - 100 of 126 matches
Mail list logo
