PortalPete wrote: > > > doesn't appear to be anything that calls these methods > > > > > > Candidate for removal then? If so it still makes sense to fix them, then > > remove them. Saves fixing them again if they are brought back. > > Either way, I'm not going to block this by requiring a test case. > > I think that makes sense. @PortalPete why don't you land this without a test > and then create a PR to remove the unused methods?
That works for me, @adrian-prantl. I'll remove these methods wholesale after someone approves/merges this PR on my behalf. https://github.com/llvm/llvm-project/pull/74413 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits