clayborg wrote: > I am really struggling to handle the scope of the changes here, IIUC there > are a handful of changes that could be split into separate commits and merged > independently of each other: there is some code being moved around, new > GetCompilerContext APIs, the new query, the replacing of the old queries with > the new queries. All of these could be different changes? It would also > making reverting things a lot easier if we end up breaking bots down the > line, and some of these changes are just "NFC goodness" that would never need > to be reverted
I would prefer to keep this all in one as I spent a month last year making all of the changes needed for this patch and it was accepted in Phabricator by Adrian after many iterations. While some of the changes are "NFC goodness", they don't make sense without this patch and we usually don't commit changes that aren't used (the GetCompilerContext APIs). The only code that was moved was the Language set. And if we want to revert this, I would say this is easier to revert as a single commit. @adrian-prantl thoughts? https://github.com/llvm/llvm-project/pull/74786 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
