[Lldb-commits] [PATCH] D146058: [lldb][gnustep] Add basic test and infrastructure for GNUstep ObjC runtime

sgraenitz added a comment. I think this is ready to land, but I will leave it here for a few more days to allow for further questions. Comment at: lldb/test/Shell/helper/toolchain.py:46 +if config.objc_gnustep_dir: + build_script_args.append('--objc-gnustep-dir="{0

[Lldb-commits] [lldb] 85bc498 - [LLDB] Show sub type of signals when debugging a core file

Author: David Spickett Date: 2023-03-21T09:10:09Z New Revision: 85bc498826d4dac4b64f7b02659f6ec52f11c223 URL: https://github.com/llvm/llvm-project/commit/85bc498826d4dac4b64f7b02659f6ec52f11c223 DIFF: https://github.com/llvm/llvm-project/commit/85bc498826d4dac4b64f7b02659f6ec52f11c223.diff LOG

[Lldb-commits] [PATCH] D146045: [LLDB] Show sub type of signals when debugging a core file

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG85bc498826d4: [LLDB] Show sub type of signals when debugging a core file (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D145566: [lldb] Add RegisterFlags class

DavidSpickett updated this revision to Diff 506882. DavidSpickett added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145566/new/ https://reviews.llvm.org/D145566 Files: lldb/include/lldb/Target/RegisterFlags.

[Lldb-commits] [PATCH] D145568: [lldb] Add dummy field to RegisterInfo for register flags use later

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/ABI/ARM/ABIMacOSX_arm.cpp:57-68 {"r1", nullptr, 4, 0, eEncodingUint, eFormatHex, {ehframe_r1, dwarf_r1, LLDB_REGNUM_GENERIC_ARG2, LLDB_INVALID_REGNUM, JD

[Lldb-commits] [lldb] 090205f - [lldb] Fix TestStepOverWatchpoint

Author: Pavel Labath Date: 2023-03-21T10:45:12+01:00 New Revision: 090205fb57a1ca65bec6fada32232c2e975d0c48 URL: https://github.com/llvm/llvm-project/commit/090205fb57a1ca65bec6fada32232c2e975d0c48 DIFF: https://github.com/llvm/llvm-project/commit/090205fb57a1ca65bec6fada32232c2e975d0c48.diff

[Lldb-commits] [PATCH] D145574: [lldb] Read register fields from target XML

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:4053 + // appears once, so we don't have to handle that here. + if (attr_name == "name") { +LLDB_LOGF(log, JDevlieghere wrote: > Do you

[Lldb-commits] [lldb] 0165b73 - [lldb] Relax expectation on TestMainThreadExit

Author: Pavel Labath Date: 2023-03-21T11:26:32+01:00 New Revision: 0165b73be37c2330ae196799cb3d93445532072b URL: https://github.com/llvm/llvm-project/commit/0165b73be37c2330ae196799cb3d93445532072b DIFF: https://github.com/llvm/llvm-project/commit/0165b73be37c2330ae196799cb3d93445532072b.diff

[Lldb-commits] [PATCH] D145566: [lldb] Add RegisterFlags class

DavidSpickett updated this revision to Diff 506902. DavidSpickett added a comment. Use LOG instead of LOGF. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145566/new/ https://reviews.llvm.org/D145566 Files: lldb/include/lldb/Target/RegisterFlags.

[Lldb-commits] [PATCH] D145574: [lldb] Read register fields from target XML

DavidSpickett updated this revision to Diff 506903. DavidSpickett added a comment. Use LOG instead of LOGF. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145574/new/ https://reviews.llvm.org/D145574 Files: lldb/include/lldb/Target/DynamicRegiste

[Lldb-commits] [lldb] c8af0d3 - [lldb] Add compile time checks for signal codes when on the matching platform

Author: David Spickett Date: 2023-03-21T11:45:13Z New Revision: c8af0d3cea8cab9277651f8cabe54e2f1a3b167f URL: https://github.com/llvm/llvm-project/commit/c8af0d3cea8cab9277651f8cabe54e2f1a3b167f DIFF: https://github.com/llvm/llvm-project/commit/c8af0d3cea8cab9277651f8cabe54e2f1a3b167f.diff LOG

[Lldb-commits] [PATCH] D146222: [lldb] Add compile time checks for signal codes when on the matching platform

This revision was automatically updated to reflect the committed changes. Closed by commit rGc8af0d3cea8c: [lldb] Add compile time checks for signal codes when on the matching platform (authored by DavidSpickett). Changed prior to commit: https://reviews.llvm.org/D146222?vs=506029&id=506915#toc

[Lldb-commits] [PATCH] D145580: [lldb] Show register fields using bitfield struct types

DavidSpickett added a comment. On the subject of not using `TypeSystemClang`, looking around it seems like `TypeSystem` is purely used to look up basic types, never to make new ones. When new types are made the code asks the `TypeSystem` for its `TypeSystemClang` and then uses that to do it. I

[Lldb-commits] [lldb] 392d9eb - [lldb] For native compiles, check signal numbers are correct when adding codes

Author: David Spickett Date: 2023-03-21T14:31:21Z New Revision: 392d9eb03af5a1adac66a86939351b22b3e73495 URL: https://github.com/llvm/llvm-project/commit/392d9eb03af5a1adac66a86939351b22b3e73495 DIFF: https://github.com/llvm/llvm-project/commit/392d9eb03af5a1adac66a86939351b22b3e73495.diff LOG

[Lldb-commits] [PATCH] D146285: [lldb] For native compiles, check signal numbers are correct when adding codes

This revision was automatically updated to reflect the committed changes. Closed by commit rG392d9eb03af5: [lldb] For native compiles, check signal numbers are correct when adding codes (authored by DavidSpickett). Changed prior to commit: https://reviews.llvm.org/D146285?vs=506036&id=506971#to

[Lldb-commits] [PATCH] D145940: [lldb] Add test for unavailable registers

DavidSpickett added a comment. ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145940/new/ https://reviews.llvm.org/D145940 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llv

[Lldb-commits] [PATCH] D146124: [lldb] Fix a 32 bit warning in ScriptedProcessInterface

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146124/new/ https://reviews.llvm.org/D146124

[Lldb-commits] [PATCH] D146154: [lldb][gnustep] Add minimal GNUstepObjCRuntime plugin for LanguageTypeObjC on non-Apple platforms

sgraenitz updated this revision to Diff 506989. sgraenitz added a comment. Check for GNUstep EH personality in ELF targets and `__objc_load` on native Windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146154/new/ https://reviews.llvm.org/D1461

[Lldb-commits] [lldb] e73dd62 - [lldb] Fix a 32 bit warning in ScriptedProcessInterface

Author: David Spickett Date: 2023-03-21T15:34:17Z New Revision: e73dd6254e310a799b492127c0f237af0e2236e2 URL: https://github.com/llvm/llvm-project/commit/e73dd6254e310a799b492127c0f237af0e2236e2 DIFF: https://github.com/llvm/llvm-project/commit/e73dd6254e310a799b492127c0f237af0e2236e2.diff LOG

[Lldb-commits] [PATCH] D146124: [lldb] Fix a 32 bit warning in ScriptedProcessInterface

This revision was automatically updated to reflect the committed changes. Closed by commit rGe73dd6254e31: [lldb] Fix a 32 bit warning in ScriptedProcessInterface (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146124/new/

[Lldb-commits] [PATCH] D146154: [lldb][gnustep] Add minimal GNUstepObjCRuntime plugin for LanguageTypeObjC on non-Apple platforms

sgraenitz added a comment. In D146154#4203277 , @aprantl wrote: > Here is an example of how the Swift Runtime plugin detects both itself and > whether ObjC interop is enabled. Basically all I'm asking is to not > accidentally break this mechanism. Than

[Lldb-commits] [PATCH] D146536: SymbolFile: ensure that we have a value before invoking `getBitWidth`

compnerd created this revision. compnerd added reviewers: rnk, sgraenitz. Herald added a project: All. compnerd requested review of this revision. Herald added a project: LLDB. Ensure that the variant returned by `member->getValue()` has a value and is not `Empty`. Failure to do so will trigger a

[Lldb-commits] [PATCH] D145940: [lldb] Add test for unavailable registers

rupprecht added a comment. Seems like most xml-based tests like this are in `lldb/test/API/functionalities/gdb_remote_client`, is there a reason this is not in that package too? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145940/new/ https://re

[Lldb-commits] [PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

aprantl added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:2640 if (!D || !D->isCompleteDefinition()) -return FwdDecl; +return {FwdDecl, nullptr}; I'm curious if this works if we encounter a forward declaration, early exit here, th

[Lldb-commits] [PATCH] D146536: SymbolFile: ensure that we have a value before invoking `getBitWidth`

sgraenitz added a comment. Thanks for tackling this! Yes, I hit it as well during development and wondered what is the right thing to do. The effect of the proposed change will be log messages like this right? ... which resolves to a constant value of mismatched width (-1 bits). Ignoring con

[Lldb-commits] [PATCH] D145574: [lldb] Read register fields from target XML

JDevlieghere accepted this revision. JDevlieghere added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:4053 + // appears once, so we don't have to handle that here. + if (attr_name == "name") { +LLDB_LOGF(log, --

[Lldb-commits] [PATCH] D145566: [lldb] Add RegisterFlags class

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145566/new/ https://reviews.llvm.org/D145566 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [PATCH] D145940: [lldb] Add test for unavailable registers

DavidSpickett added a comment. It's not in that dir because it's testing how the register command handles missing registers, rather than how the gdb client does. It assumes that the gdb client is correctly doing its job. And it seemed like the place one would look if you wondered whether there

[Lldb-commits] [PATCH] D145568: [lldb] Add dummy field to RegisterInfo for register flags use later

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM Comment at: lldb/source/Plugins/ABI/ARM/ABIMacOSX_arm.cpp:57-68 {"r1", nullptr, 4, 0, eEncodingUint, eFormatHex, {ehframe_r1, dwarf_r1, LLDB_REGNUM_GENERIC_ARG2, LLD

[Lldb-commits] [PATCH] D145940: [lldb] Add test for unavailable registers

DavidSpickett added a comment. The non XML way to do this is just reading bogus register names (and is already tested). However that's all or nothing so it doesn't prove that when there is a mix of available and unavailable registers the command works correctly. Repository: rG LLVM Github Mo

[Lldb-commits] [PATCH] D146541: [lldb][expr] Propagate ClangDynamicCheckerFunctions::Install() errors to caller

sgraenitz created this revision. sgraenitz added reviewers: teemperor, bulbazord, JDevlieghere. Herald added subscribers: kadircet, arphaman. Herald added a project: All. sgraenitz requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: LLDB. I

[Lldb-commits] [PATCH] D146154: [lldb][gnustep] Add minimal GNUstepObjCRuntime plugin for LanguageTypeObjC on non-Apple platforms

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Thanks for adding the check! Comment at: lldb/source/Plugins/LanguageRuntime/ObjC/GNUstepObjCRuntime/GNUstepObjCRuntime.cpp:185 + llvm::StringRef filename = module_file_s

[Lldb-commits] [PATCH] D145940: [lldb] Add test for unavailable registers

DavidSpickett planned changes to this revision. DavidSpickett added a comment. On second thought I think you can do this without XML, I'll figure that out. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145940/new/ https://reviews.llvm.org/D145940

[Lldb-commits] [lldb] 75fdf7f - [lldb] Test direct ivar access in objc++ (NFC)

Author: Dave Lee Date: 2023-03-21T10:14:42-07:00 New Revision: 75fdf7fd1516090651c0c3ffba4869cba9f3a879 URL: https://github.com/llvm/llvm-project/commit/75fdf7fd1516090651c0c3ffba4869cba9f3a879 DIFF: https://github.com/llvm/llvm-project/commit/75fdf7fd1516090651c0c3ffba4869cba9f3a879.diff LOG:

[Lldb-commits] [PATCH] D146320: [lldb] Test direct ivar access in objc++ (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG75fdf7fd1516: [lldb] Test direct ivar access in objc++ (NFC) (authored by kastiglione). Changed prior to commit: https://reviews.llvm.org/D146320?vs=506157&id=507033#toc Repository: rG LLVM Github Mo

[Lldb-commits] [PATCH] D145940: [lldb] Add test for unavailable registers

DavidSpickett updated this revision to Diff 507035. DavidSpickett added a comment. Remove the need for regex, with the tradeoff that you need the X86 backend which is pretty common to have. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145940/new/

[Lldb-commits] [PATCH] D146547: [lldb][gnustep][PDB] Add special handling for ObjC built-in types eBasicTypeObjCID and eBasicTypeObjCSel

sgraenitz created this revision. sgraenitz added reviewers: aleksandr.urakov, rnk, teemperor, DavidSpickett, aprantl, zturner, jdoerfert. Herald added a project: All. sgraenitz requested review of this revision. Herald added a project: LLDB. Let the PDB parser recognize special ObjC type names li

[Lldb-commits] [PATCH] D146541: [lldb][expr] Propagate ClangDynamicCheckerFunctions::Install() errors to caller

bulbazord accepted this revision. bulbazord added a comment. Thanks for improving the error message here! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146541/new/ https://reviews.llvm.org/D146541 ___ ll

[Lldb-commits] [PATCH] D146541: [lldb][expr] Propagate ClangDynamicCheckerFunctions::Install() errors to caller

sgraenitz added a comment. Thanks for the quick replies! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146541/new/ https://reviews.llvm.org/D146541 ___ lldb-commits mailing list lldb-commits@lists.llvm.o

[Lldb-commits] [PATCH] D145580: [lldb] Show register fields using bitfield struct types

bulbazord added a subscriber: aprantl. bulbazord added a comment. In D145580#4209621 , @DavidSpickett wrote: > On the subject of not using `TypeSystemClang`, looking around it seems like > `TypeSystem` is purely used to look up basic types, never to mak

[Lldb-commits] [lldb] 3854963 - Recommit [lldb] Change dwim-print to default to disabled persistent results

Author: Dave Lee Date: 2023-03-21T10:42:24-07:00 New Revision: 385496385476fc9735da5fa4acabc34654e8b30d URL: https://github.com/llvm/llvm-project/commit/385496385476fc9735da5fa4acabc34654e8b30d DIFF: https://github.com/llvm/llvm-project/commit/385496385476fc9735da5fa4acabc34654e8b30d.diff LOG:

[Lldb-commits] [PATCH] D146548: [lldb] Refactor deduction of the instance variable's name (NFC)

kastiglione created this revision. kastiglione added a reviewer: aprantl. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Move responsibility of providing the instance variable name (`this`, `self`)

[Lldb-commits] [PATCH] D146154: [lldb][gnustep] Add minimal GNUstepObjCRuntime plugin for LanguageTypeObjC on non-Apple platforms

sgraenitz updated this revision to Diff 507054. sgraenitz marked an inline comment as done. sgraenitz added a comment. Make shared library name checks OS-dependent Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146154/new/ https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D146154: [lldb][gnustep] Add minimal GNUstepObjCRuntime plugin for LanguageTypeObjC on non-Apple platforms

sgraenitz added a comment. Thanks for reviewing! I will land this as soon as the previous review is ready. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146154/new/ https://reviews.llvm.org/D146154 ___ l

[Lldb-commits] [PATCH] D146473: [lldb][CMake] Enforce not letting lldbUtility link against any other lldb libs

bulbazord added a comment. > Can we do something similar for plugins? Yep, I'll tackle that in a follow-up. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146473/new/ https://reviews.llvm.org/D146473 ___

[Lldb-commits] [lldb] 2356bf2 - [lldb][CMake] Enforce not letting lldbUtility link against any other lldb libs

Author: Alex Langford Date: 2023-03-21T11:03:51-07:00 New Revision: 2356bf27f722eddbdf3c9acf4072cbdd348f00d0 URL: https://github.com/llvm/llvm-project/commit/2356bf27f722eddbdf3c9acf4072cbdd348f00d0 DIFF: https://github.com/llvm/llvm-project/commit/2356bf27f722eddbdf3c9acf4072cbdd348f00d0.diff

[Lldb-commits] [PATCH] D146473: [lldb][CMake] Enforce not letting lldbUtility link against any other lldb libs

This revision was automatically updated to reflect the committed changes. Closed by commit rG2356bf27f722: [lldb][CMake] Enforce not letting lldbUtility link against any other lldb libs (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[Lldb-commits] [lldb] 32baf5c - [lldb][expr] Propagate ClangDynamicCheckerFunctions::Install() errors to caller

Author: Stefan Gränitz Date: 2023-03-21T19:05:23+01:00 New Revision: 32baf5c1c29b6b2f282354c9f5919865bc1ff958 URL: https://github.com/llvm/llvm-project/commit/32baf5c1c29b6b2f282354c9f5919865bc1ff958 DIFF: https://github.com/llvm/llvm-project/commit/32baf5c1c29b6b2f282354c9f5919865bc1ff958.diff

[Lldb-commits] [PATCH] D146541: [lldb][expr] Propagate ClangDynamicCheckerFunctions::Install() errors to caller

This revision was automatically updated to reflect the committed changes. Closed by commit rG32baf5c1c29b: [lldb][expr] Propagate ClangDynamicCheckerFunctions::Install() errors to caller (authored by sgraenitz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[Lldb-commits] [PATCH] D146553: [lldb][CMake] Enforce not linking against plugin libs in core libs

bulbazord created this revision. bulbazord added a reviewer: JDevlieghere. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Non-plugin lldb libraries should generally not be linking against lldb plugin

[Lldb-commits] [PATCH] D146473: [lldb][CMake] Enforce not letting lldbUtility link against any other lldb libs

bulbazord added a comment. In D146473#4210440 , @bulbazord wrote: >> Can we do something similar for plugins? > > Yep, I'll tackle that in a follow-up. For those following along at home: D146553 Repository: rG LLVM

[Lldb-commits] [PATCH] D146553: [lldb][CMake] Enforce not linking against plugin libs in core libs

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146553/new/ https://reviews.llvm.org/D146553 ___

[Lldb-commits] [PATCH] D145940: [lldb] Add test for unavailable registers

rupprecht accepted this revision. rupprecht added inline comments. This revision is now accepted and ready to land. Comment at: lldb/test/API/commands/register/register/TestRegistersUnavailable.py:43-53 +self.expect("register read --all", patterns=[ +"(?sm)^g

[Lldb-commits] [PATCH] D145580: [lldb] Show register fields using bitfield struct types

aprantl added inline comments. Comment at: lldb/source/Core/DumpRegisterValue.cpp:136-137 + // See if we have made this type before and can reuse it. + CompilerType fields_type = ast->GetTypeForIdentifier( + ConstString(register_type_name.c_str())); + bulb

[Lldb-commits] [PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

bnbarham added inline comments. Comment at: clang/lib/Index/USRGeneration.cpp:1032 + case TemplateArgument::UncommonValue: +// FIXME: Visit value. +break; bolshakov-a wrote: > bnbarham wrote: > > bolshakov-a wrote: > > > bnbarham wrote: > > > > bolshakov

[Lldb-commits] [lldb] c327f99 - [lldb] Refactor deduction of the instance variable's name (NFC)

Author: Dave Lee Date: 2023-03-21T15:22:07-07:00 New Revision: c327f9925428870e6288fa65bb709dcc3c0a0f31 URL: https://github.com/llvm/llvm-project/commit/c327f9925428870e6288fa65bb709dcc3c0a0f31 DIFF: https://github.com/llvm/llvm-project/commit/c327f9925428870e6288fa65bb709dcc3c0a0f31.diff LOG:

[Lldb-commits] [PATCH] D146548: [lldb] Refactor deduction of the instance variable's name (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rGc327f9925428: [lldb] Refactor deduction of the instance variable's name (NFC) (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146548

[Lldb-commits] [PATCH] D146590: [lldb] Update some uses of Python2 API in typemaps.

jgorbe created this revision. jgorbe added reviewers: labath, rupprecht. jgorbe added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. jgorbe requested review of this revision. Python 3 doesn't have a distinction between PyInt and PyLong, it's all PyLong now.

[Lldb-commits] [lldb] 5499b02 - [lldb][CMake] Enforce not linking against plugin libs in core libs

Author: Alex Langford Date: 2023-03-21T16:24:36-07:00 New Revision: 5499b026d218f694a8c9f148466da3259f6cc1fd URL: https://github.com/llvm/llvm-project/commit/5499b026d218f694a8c9f148466da3259f6cc1fd DIFF: https://github.com/llvm/llvm-project/commit/5499b026d218f694a8c9f148466da3259f6cc1fd.diff

[Lldb-commits] [PATCH] D146553: [lldb][CMake] Enforce not linking against plugin libs in core libs

This revision was automatically updated to reflect the committed changes. Closed by commit rG5499b026d218: [lldb][CMake] Enforce not linking against plugin libs in core libs (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14655

[Lldb-commits] [PATCH] D146590: [lldb] Update some uses of Python2 API in typemaps.

rupprecht added reviewers: bulbazord, mib. rupprecht added a comment. Can you add a regression test that invokes `lldb -o "script data=lldb.SBData(); data.SetDataFromUInt64Array([2**63])"`? Just a simple shell test should suffice. LGTM, but it'd be nice if someone else can look too. Adding some

[Lldb-commits] [PATCH] D146590: [lldb] Update some uses of Python2 API in typemaps.

bulbazord added a comment. > `lldb -o "script data=lldb.SBData(); data.SetDataFromUInt64Array([2**63])"` Just tried this, didn't crash LLDB but it does give me the OverflowError you mentioned. Either way, this is probably okay? What do you think @mib? Repository: rG LLVM Github Monorepo CH

[Lldb-commits] [PATCH] D146590: [lldb] Update some uses of Python2 API in typemaps.

rupprecht added a comment. In D146590#4211763 , @bulbazord wrote: >> `lldb -o "script data=lldb.SBData(); data.SetDataFromUInt64Array([2**63])"` > > Just tried this, didn't crash LLDB but it does give me the OverflowError you > mentioned. Here's what th

[Lldb-commits] [PATCH] D146590: [lldb] Update some uses of Python2 API in typemaps.

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. Yep, LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146590/new/ https://reviews.llvm.org/D146590 ___