JDevlieghere accepted this revision.
JDevlieghere added a comment.
LGTM
================
Comment at: lldb/source/Plugins/ABI/ARM/ABIMacOSX_arm.cpp:57-68
{"r1",
nullptr,
4,
0,
eEncodingUint,
eFormatHex,
{ehframe_r1, dwarf_r1, LLDB_REGNUM_GENERIC_ARG2, LLDB_INVALID_REGNUM,
----------------
DavidSpickett wrote:
> JDevlieghere wrote:
> > Would using a `.def` file make this easier to maintain?
> Almost certainly, do you mean in general? Half of these files are using some
> macro to make the defs already, one could probably generalise that. You'd end
> up with a sort of constructor for RegisterInfo, but it's a macro. So if some
> file wants to diverge, it can.
>
> Let me see what I can do about that, though I think it would be best done in
> a new patch.
Yeah, I meant the `g_register_infos` as a whole. Tablegen would be an option
too, but that might be overkill for this. Separate patch sounds fair.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145568/new/
https://reviews.llvm.org/D145568
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
