aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.

Thanks for adding the check!



================
Comment at: 
lldb/source/Plugins/LanguageRuntime/ObjC/GNUstepObjCRuntime/GNUstepObjCRuntime.cpp:185
+  llvm::StringRef filename = module_file_spec.GetFilename().GetStringRef();
+  return filename.starts_with("libobjc.so") || filename == "objc.dll";
+}
----------------
Do you have access to the target triple here? Might want to only check for the 
strings based on the the OS?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146154/new/

https://reviews.llvm.org/D146154

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to