[Lldb-commits] [PATCH] D135516: [lldb] [MainLoopPosix] Fix crash upon adding lots of pending callbacks

labath added a comment. I never expected we would have so many callbacks that we'd have to worry about this, but yes, this is one way to fix the problem. Another (slightly simpler, but also less performant) would be to make the write pipe nonblocking, and do not treat EAGAIN as an error. ===

[Lldb-commits] [PATCH] D134849: [LLDB][NativePDB] Fix struct layout when it has anonymous unions.

labath added a comment. The test looks great, and the comments have helped. I still have a couple of questions about the algorithm though. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/UdtRecordCompleter.cpp:431 +uint64_t offset = pair.first; +auto &fields = pai

[Lldb-commits] [PATCH] D135461: [LLDB] Fix crash when printing a struct with a static wchar_t member

DavidSpickett added a comment. You need to update the python file for the test as well. What does the output look like, do we actually print the character itself or it's value? (just curious, which one we do is probably out of scope for this change) Comment at: clang/lib/AST

[Lldb-commits] [PATCH] D135413: [lldb][CPlusPlusLanguage] Respect the step-avoid-regex for functions with auto return types

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. > There are longer-term plans of replacing the hand-rolled C++ parser with an > alternative that uses the mangle tree API to do the parsing for us. You may be aware of this, but I feel I shoul

[Lldb-commits] [PATCH] D135352: [LLDB] Complete set of char tests for static integral members

DavidSpickett added a comment. ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135352/new/ https://reviews.llvm.org/D135352 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llv

[Lldb-commits] [PATCH] D135352: [LLDB] Complete set of char tests for static integral members

Michael137 accepted this revision. Michael137 added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135352/new/ https://reviews.llvm.org/D135352 ___

[Lldb-commits] [PATCH] D135352: [LLDB] Complete set of char tests for static integral members

This revision was automatically updated to reflect the committed changes. Closed by commit rGb3d4d9ced17c: [LLDB] Complete set of char tests for static integral members (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135352

[Lldb-commits] [lldb] b3d4d9c - [LLDB] Complete set of char tests for static integral members

Author: David Spickett Date: 2022-10-10T11:16:19Z New Revision: b3d4d9ced17c5b3ebd6bf5b61731ddcdde3cbca5 URL: https://github.com/llvm/llvm-project/commit/b3d4d9ced17c5b3ebd6bf5b61731ddcdde3cbca5 DIFF: https://github.com/llvm/llvm-project/commit/b3d4d9ced17c5b3ebd6bf5b61731ddcdde3cbca5.diff LOG

[Lldb-commits] [PATCH] D135413: [lldb][CPlusPlusLanguage] Respect the step-avoid-regex for functions with auto return types

Michael137 updated this revision to Diff 466467. Michael137 added a comment. - Reword commit message - Remove redundant header from test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135413/new/ https://reviews.llvm.org/D135413 Files: lldb/sourc

[Lldb-commits] [PATCH] D135413: [lldb][CPlusPlusLanguage] Respect the step-avoid-regex for functions with auto return types

Michael137 added a comment. In D135413#3846390 , @labath wrote: >> There are longer-term plans of replacing the hand-rolled C++ parser with an >> alternative that uses the mangle tree API to do the parsing for us. > > You may be aware of this, but I feel

[Lldb-commits] [lldb] a4561d9 - [lldb][CPlusPlusLanguage] Respect the step-avoid-regex for functions with auto return types

Author: Michael Buch Date: 2022-10-10T12:50:15+01:00 New Revision: a4561d934877fbba5cfb3cac3195a41707ba6043 URL: https://github.com/llvm/llvm-project/commit/a4561d934877fbba5cfb3cac3195a41707ba6043 DIFF: https://github.com/llvm/llvm-project/commit/a4561d934877fbba5cfb3cac3195a41707ba6043.diff

[Lldb-commits] [PATCH] D135413: [lldb][CPlusPlusLanguage] Respect the step-avoid-regex for functions with auto return types

This revision was automatically updated to reflect the committed changes. Closed by commit rGa4561d934877: [lldb][CPlusPlusLanguage] Respect the step-avoid-regex for functions with auto… (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[Lldb-commits] [PATCH] D135577: Summary:

HenriqueBucher created this revision. HenriqueBucher added a reviewer: clayborg. Herald added a project: All. HenriqueBucher requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This documentation patch adds information to allow remote users to

[Lldb-commits] [PATCH] D131858: [clang] Track the templated entity in type substitution.

erichkeane accepted this revision. erichkeane added a comment. This LGTM, but please give @davrec time (a few days?) to do another review before merging. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131858/new/ https://reviews.llvm.org/D131858 _

[Lldb-commits] [PATCH] D135413: [lldb][CPlusPlusLanguage] Respect the step-avoid-regex for functions with auto return types

stella.stamenova added a comment. Looks like this change broke the windows lldb bot: https://lab.llvm.org/buildbot/#/builders/83/builds/24631 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135413/new/ https://reviews.llvm.org/D135413 _

[Lldb-commits] [PATCH] D134991: [lldb] Add diagnostics

JDevlieghere marked 4 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/include/lldb/Utility/Log.h:231 llvm::StringRef function, const char *format, - Args &&... args) { + Args &&...args) { F

[Lldb-commits] [PATCH] D135413: [lldb][CPlusPlusLanguage] Respect the step-avoid-regex for functions with auto return types

Michael137 added a comment. In D135413#3846954 , @stella.stamenova wrote: > Looks like this change broke the windows lldb bot: > https://lab.llvm.org/buildbot/#/builders/83/builds/24631 I thought I had skipped it on Windows. Will fix now Repository:

[Lldb-commits] [PATCH] D134991: [lldb] Add diagnostics

JDevlieghere updated this revision to Diff 466526. JDevlieghere marked 3 inline comments as done. JDevlieghere added a comment. Address code review feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134991/new/ https://reviews.llvm.org/D134991 Files: lldb/include/lldb/API/SBDebug

[Lldb-commits] [PATCH] D135516: [lldb] [MainLoopPosix] Fix crash upon adding lots of pending callbacks

mgorny added a comment. In D135516#3846182 , @labath wrote: > I never expected we would have so many callbacks that we'd have to worry > about this, but yes, this is one way to fix the problem. Another (slightly > simpler, but also less performant) woul

[Lldb-commits] [PATCH] D135577: Summary:

JDevlieghere requested changes to this revision. JDevlieghere added inline comments. This revision now requires changes to proceed. Comment at: lldb/tools/lldb-vscode/README.md:39 +It is important to note that the directory `~/.vscode/extensions` works for users logged in loca

[Lldb-commits] [PATCH] D135547: [lldb/Utility] Add GetDescription(Stream&) to StructureData::*

JDevlieghere added a comment. The change looks good but this needs unit tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135547/new/ https://reviews.llvm.org/D135547 ___ lldb-commits mailing list lld

[Lldb-commits] [lldb] fd91e8f - [lldb][test] Skip TestStepAvoidsRegexp.py on Windows

Author: Michael Buch Date: 2022-10-10T17:07:52+01:00 New Revision: fd91e8f5016626328093aedc8419f12af20ff554 URL: https://github.com/llvm/llvm-project/commit/fd91e8f5016626328093aedc8419f12af20ff554 DIFF: https://github.com/llvm/llvm-project/commit/fd91e8f5016626328093aedc8419f12af20ff554.diff

[Lldb-commits] [PATCH] D135577: Summary:

jryans added a comment. Please also give this patch a title that would make sense as the first line of a commit message. It currently just says "Summary:" at the moment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135577/new/ https://reviews.llv

[Lldb-commits] [PATCH] D135577: Summary:

HenriqueBucher updated this revision to Diff 466537. HenriqueBucher added a comment. Formatted text to wrap in 80 columns Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135577/new/ https://reviews.llvm.org/D135577 Files: lldb/tools/lldb-vscode/RE

[Lldb-commits] [PATCH] D135577: Summary:

HenriqueBucher updated this revision to Diff 466538. HenriqueBucher added a comment. Removed 2 extra blank lines Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135577/new/ https://reviews.llvm.org/D135577 Files: lldb/tools/lldb-vscode/README.md

[Lldb-commits] [PATCH] D135577: Summary:

HenriqueBucher added inline comments. Comment at: lldb/tools/lldb-vscode/README.md:39 +It is important to note that the directory `~/.vscode/extensions` works for users logged in locally to the machine. If you are remoting into the box using Visual Studio Code's Remote plugin

[Lldb-commits] [lldb] b8a8c2d - Allow DynamicLoaderDarwinKernel to activate without binary

Author: Jason Molenda Date: 2022-10-10T10:19:09-07:00 New Revision: b8a8c2d47a38ba08012fe9cbb28169a1e0f7be2a URL: https://github.com/llvm/llvm-project/commit/b8a8c2d47a38ba08012fe9cbb28169a1e0f7be2a DIFF: https://github.com/llvm/llvm-project/commit/b8a8c2d47a38ba08012fe9cbb28169a1e0f7be2a.diff

[Lldb-commits] [PATCH] D135577: Summary:

JDevlieghere added inline comments. Comment at: lldb/tools/lldb-vscode/README.md:39 +It is important to note that the directory `~/.vscode/extensions` works for users logged in locally to the machine. If you are remoting into the box using Visual Studio Code's Remote plugins

[Lldb-commits] [PATCH] D134991: [lldb] Add diagnostics

JDevlieghere updated this revision to Diff 466549. JDevlieghere added a comment. Changed my mind (again). I made the Callback a std::function so we can use lambas. I used function pointers originally so we could easily compare and remove callbacks, but there's too many places where this overcomp

[Lldb-commits] [PATCH] D135607: Summary:

HenriqueBucher created this revision. HenriqueBucher added reviewers: JDevlieghere, clayborg. Herald added a project: All. HenriqueBucher requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Reformatted doc text so it is more or less around 80 c

[Lldb-commits] [PATCH] D134849: [LLDB][NativePDB] Fix struct layout when it has anonymous unions.

zequanwu updated this revision to Diff 466575. zequanwu marked 2 inline comments as done. zequanwu added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134849/new/ https://reviews.llvm.org/D134849 Files: lldb/source/P

[Lldb-commits] [PATCH] D134849: [LLDB][NativePDB] Fix struct layout when it has anonymous unions.

zequanwu added inline comments. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/UdtRecordCompleter.cpp:459 + uint64_t end_offset = offset + fields.back()->bit_size; + parent->fields.push_back(fields.back()); + end_offset_map[end_offset].push_back(parent);

[Lldb-commits] [PATCH] D135577: Summary:

HenriqueBucher added a comment. Ok submitted another patch. Added you as reviewer. Check if it is okay. https://reviews.llvm.org/D135607 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135577/new/ https://reviews.llvm.org/D135577 __

[Lldb-commits] [PATCH] D135616: [lldb/Utility] Fix StructuredData::ParseJSONValue for null items

mib created this revision. mib added a reviewer: JDevlieghere. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch fixes the JSON parser for StructuredData to handle JSON null entries. Signed-off-by: Me

[Lldb-commits] [PATCH] D134066: [LLDB][NativePDB] Forcefully complete a record type it has incomplete type debug info.

zequanwu added inline comments. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/PdbAstBuilder.cpp:681 +auto &ts = llvm::cast(*ct.GetTypeSystem()); +ts.GetMetadata(&tag)->SetIsForcefullyCompleted(); + } labath wrote: > zequanwu wrote: > >

[Lldb-commits] [PATCH] D135461: [LLDB] Fix crash when printing a struct with a static wchar_t member

aeubanks updated this revision to Diff 466622. aeubanks added a comment. update python test, although those changes don't actually test the code path changed here, the code path here is tested via the existing `self.expect("image lookup -t A")` Repository: rG LLVM Github Monorepo CHANGES SI

[Lldb-commits] [PATCH] D135461: [LLDB] Fix crash when printing a struct with a static wchar_t member

aeubanks added inline comments. Comment at: clang/lib/AST/StmtPrinter.cpp:1298 + case BuiltinType::WChar_U: +break; // no suffix. } DavidSpickett wrote: > Is there any reason to have a suffix here? > > I admit this function is puzzling to me anyway given

[Lldb-commits] [PATCH] D135547: [lldb/Utility] Add GetDescription(Stream&) to StructureData::*

mib updated this revision to Diff 466624. mib added a comment. Address @JDevlieghere comment: - Add unittest CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135547/new/ https://reviews.llvm.org/D135547 Files: lldb/include/lldb/Core/StructuredDataImpl.h lldb/include/lldb/Utility/Stru

[Lldb-commits] [PATCH] D135547: [lldb/Utility] Add GetDescription(Stream&) to StructureData::*

mib updated this revision to Diff 466626. mib added a comment. Add test file CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135547/new/ https://reviews.llvm.org/D135547 Files: lldb/include/lldb/Core/StructuredDataImpl.h lldb/include/lldb/Utility/StructuredData.h lldb/source/Comman

[Lldb-commits] [PATCH] D126260: [lldb/crashlog] Add support for Application Specific Backtraces & Information

mib marked 2 inline comments as done. mib added inline comments. Comment at: lldb/examples/python/crashlog.py:581-597 +def parse_asi_backtrace(self, thread, bt): +for line in bt.split('\n'): +frame_match = TextCrashLogParser.frame_regex.search(

[Lldb-commits] [PATCH] D126260: [lldb/crashlog] Add support for Application Specific Backtraces & Information

mib updated this revision to Diff 466636. mib marked an inline comment as done. mib edited the summary of this revision. mib added a comment. - Address @JDevlieghere comments. - Change implementation to have the ASI in the process extended crash info and ASB as an extended HistoryThread of the ac

[Lldb-commits] [PATCH] D135620: Prevent lldb-vscode tests from source lldbinit file

yinghuitan created this revision. yinghuitan added reviewers: clayborg, labath, jingham, jdoerfert, JDevlieghere, aadsm, kusmour, fixathon. Herald added a project: All. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. lldb-vscode

[Lldb-commits] [PATCH] D135621: [lldb] Add an always-on log channel

JDevlieghere created this revision. JDevlieghere added reviewers: labath, DavidSpickett, jingham, mib, clayborg. Herald added a project: All. JDevlieghere requested review of this revision. Add an "always on" log channel. The channel is meant to be used sparsely and deliberately for logging high-

[Lldb-commits] [PATCH] D135622: [lldb] Add a "diagnostics dump" command

JDevlieghere created this revision. JDevlieghere added reviewers: labath, DavidSpickett, clayborg, jingham. Herald added a project: All. JDevlieghere requested review of this revision. Add a "diagnostics dump" command to, as the name implies, dump the diagnostics to disk. The goal of this command

[Lldb-commits] [lldb] e5fd507 - [NFCI] More TypeCategoryImpl refactoring.

Author: Jorge Gorbe Moya Date: 2022-10-10T15:14:55-07:00 New Revision: e5fd507f9b6f774c83c7b061fa77c906c882935b URL: https://github.com/llvm/llvm-project/commit/e5fd507f9b6f774c83c7b061fa77c906c882935b DIFF: https://github.com/llvm/llvm-project/commit/e5fd507f9b6f774c83c7b061fa77c906c882935b.di

[Lldb-commits] [PATCH] D135399: [NFCI] More TypeCategoryImpl refactoring.

This revision was automatically updated to reflect the committed changes. Closed by commit rGe5fd507f9b6f: [NFCI] More TypeCategoryImpl refactoring. (authored by jgorbe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135399/new/ https://reviews.llvm

[Lldb-commits] [PATCH] D135620: Prevent lldb-vscode tests from source lldbinit file

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Just add a comment as suggested and this is good to go! Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:1448-1449 + + auto arguments = request.getObject("ar

[Lldb-commits] [PATCH] D134962: [LLDB] Change pointer to ref in EmulateInstruction::ReadRegister methods

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. sorry for the delay, was on vacation for the past week Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134962/new/ https://reviews.llvm.org/D1

[Lldb-commits] [PATCH] D134991: [lldb] Add diagnostics

clayborg added inline comments. Comment at: lldb/source/Target/Statistics.cpp:293 + +llvm::Error DebuggerStats::Dump(const FileSpec &dir) { + for (size_t debugger_idx = 0; debugger_idx < Debugger::GetNumDebuggers(); Should this return a Expected> in case the cal

[Lldb-commits] [PATCH] D135631: [lldb] Copy log files into diagnostic directory (RFC)

JDevlieghere created this revision. JDevlieghere added reviewers: labath, DavidSpickett, clayborg, mib. Herald added a project: All. JDevlieghere requested review of this revision. This patch copies over log files to the diagnostic directory. It's a bit of a straw man proposal as it has some shor

[Lldb-commits] [PATCH] D135607: Summary:

clayborg added a comment. I am not sure how and if any of these changes will affect the output. Any chance we can attach a before and after screenshot of the rendered output? Comment at: lldb/tools/lldb-vscode/README.md:18-19 The `lldb-vscode` tool creates a command line tool

[Lldb-commits] [PATCH] D135577: Summary:

clayborg added a comment. lgtm. Jonas? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135577/new/ https://reviews.llvm.org/D135577 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.l

[Lldb-commits] [PATCH] D135607: Summary:

HenriqueBucher added a comment. To be frank, I think this formatting is silly and wrong now that I am looking at it. Looking at the rendered markdown at Github you can see that the browser itself word wraps for y

[Lldb-commits] [PATCH] D131858: [clang] Track the templated entity in type substitution.

ChuanqiXu added inline comments. Comment at: clang/lib/Serialization/ASTWriterDecl.cpp:623-626 + VisitDeclaratorDecl(D); + Record.AddDeclarationNameLoc(D->DNLoc, D->getDeclName()); + Record.push_back(D->getIdentifierNamespace()); + mizvekov wrote: > ChuanqiXu