labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

> There are longer-term plans of replacing the hand-rolled C++ parser with an 
> alternative that uses the mangle tree API to do the parsing for us.

You may be aware of this, but I feel I should mention that there are cases when 
a function just does not have a mangled name, either because it is in an 
`extern "C"` block, or because it was complied with 
`--dwarf-linkage-names=Abstract` (default for `-gsce`). In this case, we 
construct a fake demangled name from the DWARF debug info (the names of 
enclosing (DW_TAG_)namespaces, and the types for (DW_TAG_)formal_parameters. Of 
course, in this case, it makes even less sense to parse the resulting string, 
since we're the ones who constructed it in the first place. However, it may not 
be sufficient to assume that one can just start with a mangled name, and get 
everything out that way.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135413/new/

https://reviews.llvm.org/D135413

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to