[Lldb-commits] [PATCH] D124760: [lldb] Fix ppc64 detection in lldb

labath added a comment. Sure, that's great. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124760/new/ https://reviews.llvm.org/D124760 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://li

[Lldb-commits] [lldb] fa593b0 - Revert "[lldb] parallelize calling of Module::PreloadSymbols()"

Author: Pavel Labath Date: 2022-05-09T11:11:01+02:00 New Revision: fa593b079b76f1c30d684cfe42a662fed157e2e5 URL: https://github.com/llvm/llvm-project/commit/fa593b079b76f1c30d684cfe42a662fed157e2e5 DIFF: https://github.com/llvm/llvm-project/commit/fa593b079b76f1c30d684cfe42a662fed157e2e5.diff

[Lldb-commits] [PATCH] D122975: parallelize calling of Module::PreloadSymbols()

labath added a comment. I'm afraid I had to revert this, as it was causing hangs in TestMultipleDebuggers.py. I haven't fully debugged this, but what I think is happening is this: - the test debug multiple (identical) inferiors in parallel - as a result the thread pool gets hit with many preloa

[Lldb-commits] [PATCH] D125154: [lldb] Specify aguments of `image list`

DavidSpickett added a comment. Can you add a test for the help output to `lldb/test/API/commands/help/TestHelp.py` ? Just the one line that includes the argument list is fine. Also I see that we don't test this part of the command at all. Not an issue for this change (I assume it is working fo

[Lldb-commits] [PATCH] D122975: parallelize calling of Module::PreloadSymbols()

labath added a comment. In D122975#3500176 , @labath wrote: > or rethink the do-tasks-while-you-wait idea. I suppose one way to fix this would be to ensure that the waiting thread only picks up its own subtasks while its waiting. That would avoid these

[Lldb-commits] [PATCH] D124370: [lldb/DWARF] Fix linking direction in CopyUniqueClassMethodTypes

This revision was automatically updated to reflect the committed changes. Closed by commit rGae7fe65cf65d: [lldb/DWARF] Fix linking direction in CopyUniqueClassMethodTypes (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124370/new

[Lldb-commits] [lldb] ae7fe65 - [lldb/DWARF] Fix linking direction in CopyUniqueClassMethodTypes

Author: Pavel Labath Date: 2022-05-09T11:47:55+02:00 New Revision: ae7fe65cf65dd4f71e117dee868965c152d27542 URL: https://github.com/llvm/llvm-project/commit/ae7fe65cf65dd4f71e117dee868965c152d27542 DIFF: https://github.com/llvm/llvm-project/commit/ae7fe65cf65dd4f71e117dee868965c152d27542.diff

[Lldb-commits] [lldb] fc440f2 - Filter non-external static members from SBType::GetFieldAtIndex.

Author: Sigurur sgeirsson Date: 2022-05-09T12:34:13+02:00 New Revision: fc440f27cd50e48e1f9ebe6e56febe2823e59de4 URL: https://github.com/llvm/llvm-project/commit/fc440f27cd50e48e1f9ebe6e56febe2823e59de4 DIFF: https://github.com/llvm/llvm-project/commit/fc440f27cd50e48e1f9ebe6e56febe2823e59de4.d

[Lldb-commits] [PATCH] D124409: Filter non-external static members from SBType::GetFieldAtIndex.

This revision was automatically updated to reflect the committed changes. Closed by commit rGfc440f27cd50: Filter non-external static members from SBType::GetFieldAtIndex. (authored by Sigurur sgeirsson , committed by labath). Changed prior to commit: https://reviews.llvm.or

[Lldb-commits] [PATCH] D125218: [lldb][NFC] Make cmd a reference in GenerateOptionUsage

DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Nowhere in lldb do we call this with a null pointer. If we did, the first line of the function would fault anywa

[Lldb-commits] [PATCH] D125219: [lldb][NFC] Simplify GenerateOptionUsage

DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Once we get into the if block we know the value of only_print_args. Move some variables closer to point of use.

[Lldb-commits] [PATCH] D124409: Filter non-external static members from SBType::GetFieldAtIndex.

siggi-alpheus added a comment. Thanks! Comment at: lldb/test/Shell/SymbolFile/DWARF/x86/debug_static-member-anonymous-namespace.s:18 +# static int s; +# int m = 14159265; +# }; I wonder why I couldn't get the query to work against an initialized global wi

[Lldb-commits] [lldb] 8abfa51 - [lldb/test] Fix TestCppIncompleteTypeMembers.py

Author: Pavel Labath Date: 2022-05-09T17:11:57+02:00 New Revision: 8abfa5119addc97e881025a819b8d643d53dda14 URL: https://github.com/llvm/llvm-project/commit/8abfa5119addc97e881025a819b8d643d53dda14 DIFF: https://github.com/llvm/llvm-project/commit/8abfa5119addc97e881025a819b8d643d53dda14.diff

[Lldb-commits] [lldb] ac7747e - [lldb/test] Append CXXFLAGS_EXTRAS last in Makefile.rules

Author: Pavel Labath Date: 2022-05-09T19:26:29+02:00 New Revision: ac7747ef281c3be4cfefa5adb5d0395cefc10223 URL: https://github.com/llvm/llvm-project/commit/ac7747ef281c3be4cfefa5adb5d0395cefc10223 DIFF: https://github.com/llvm/llvm-project/commit/ac7747ef281c3be4cfefa5adb5d0395cefc10223.diff

[Lldb-commits] [lldb] a49d5e9 - [lldb/test] Remove superfluous -std=c++11 from tests

Author: Pavel Labath Date: 2022-05-09T20:04:14+02:00 New Revision: a49d5e976e6d49a5a182a394c4a2a04395159b13 URL: https://github.com/llvm/llvm-project/commit/a49d5e976e6d49a5a182a394c4a2a04395159b13 DIFF: https://github.com/llvm/llvm-project/commit/a49d5e976e6d49a5a182a394c4a2a04395159b13.diff

[Lldb-commits] [PATCH] D125253: Add the ability to debug through an exec into ld

clayborg created this revision. clayborg added reviewers: labath, wallace, yinghuitan, rdhindsa. Herald added a project: All. clayborg requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. A previous commit enabled LLDB to be able to debug a prog

[Lldb-commits] [PATCH] D125253: Add the ability to debug through an exec into ld

yinghuitan added inline comments. Comment at: lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp:312 BreakpointSP dyld_break; - if (m_rendezvous.IsValid()) { + if (m_rendezvous.IsValid() && m_rendezvous.GetBreakAddress() != 0) { break_addr = m_rend

[Lldb-commits] [PATCH] D125253: Add the ability to debug through an exec into ld

clayborg added inline comments. Comment at: lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp:312 BreakpointSP dyld_break; - if (m_rendezvous.IsValid()) { + if (m_rendezvous.IsValid() && m_rendezvous.GetBreakAddress() != 0) { break_addr = m_rendez

[Lldb-commits] [PATCH] D125253: Add the ability to debug through an exec into ld

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. nice! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125253/new/ https://reviews.llvm.org/D125253

[Lldb-commits] [PATCH] D124648: [trace][intelpt] Support system-wide tracing [3] - Refactor IntelPTThreadTrace

wallace added inline comments. Comment at: lldb/source/Plugins/Process/Linux/IntelPTSingleBufferTrace.h:41-48 + /// \param[in] tid + /// The tid of the thread to be traced. + /// + /// \return + /// A \a IntelPTSingleBufferTrace instance if tracing was successful, or +

[Lldb-commits] [PATCH] D125148: Add an example command that runs to one of a set of breakpoints

hawkinsw added a comment. Just trying to be helpful! Comment at: lldb/examples/python/cont_to_bkpt.py:26 +target = exe_ctx.target +if not exe_ctx.target.IsValid(): +result.SetError("Need a valid target") Reuse `target` here rather t

[Lldb-commits] [lldb] b8d1776 - [trace][intelpt] Support system-wide tracing [2] - Add a dummy --per-core-tracing option

Author: Walter Erquinigo Date: 2022-05-09T16:05:26-07:00 New Revision: b8d1776fc58d56af30d446386788e377d25dd512 URL: https://github.com/llvm/llvm-project/commit/b8d1776fc58d56af30d446386788e377d25dd512 DIFF: https://github.com/llvm/llvm-project/commit/b8d1776fc58d56af30d446386788e377d25dd512.di

[Lldb-commits] [lldb] 7b73de9 - [trace][intelpt] Support system-wide tracing [3] - Refactor IntelPTThreadTrace

Author: Walter Erquinigo Date: 2022-05-09T16:05:26-07:00 New Revision: 7b73de9ec2b19df040c919d3004dfbead9b6ac59 URL: https://github.com/llvm/llvm-project/commit/7b73de9ec2b19df040c919d3004dfbead9b6ac59 DIFF: https://github.com/llvm/llvm-project/commit/7b73de9ec2b19df040c919d3004dfbead9b6ac59.di

[Lldb-commits] [PATCH] D124640: [trace][intelpt] Support system-wide tracing [2] - Add a dummy --per-core-tracing option

This revision was automatically updated to reflect the committed changes. Closed by commit rGb8d1776fc58d: [trace][intelpt] Support system-wide tracing [2] - Add a dummy --per-core… (authored by Walter Erquinigo ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D124648: [trace][intelpt] Support system-wide tracing [3] - Refactor IntelPTThreadTrace

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7b73de9ec2b1: [trace][intelpt] Support system-wide tracing [3] - Refactor IntelPTThreadTrace (authored by Walter Erquinigo ). Repos

[Lldb-commits] [lldb] 879a47a - Add the ability to debug through an exec into ld

Author: Greg Clayton Date: 2022-05-09T16:07:40-07:00 New Revision: 879a47a55ffb94976cbac1d191ef53be135d86a7 URL: https://github.com/llvm/llvm-project/commit/879a47a55ffb94976cbac1d191ef53be135d86a7 DIFF: https://github.com/llvm/llvm-project/commit/879a47a55ffb94976cbac1d191ef53be135d86a7.diff

[Lldb-commits] [PATCH] D125253: Add the ability to debug through an exec into ld

This revision was automatically updated to reflect the committed changes. Closed by commit rG879a47a55ffb: Add the ability to debug through an exec into ld (authored by clayborg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125253/new/ https://rev

[Lldb-commits] [lldb] 909a2e3 - [lldb] Fix 7b73de9ec2b19df040c919d3004dfbead9b6ac59

Author: Walter Erquinigo Date: 2022-05-09T21:02:40-07:00 New Revision: 909a2e3c8822f0826234aa320794003c7066fada URL: https://github.com/llvm/llvm-project/commit/909a2e3c8822f0826234aa320794003c7066fada DIFF: https://github.com/llvm/llvm-project/commit/909a2e3c8822f0826234aa320794003c7066fada.di

[Lldb-commits] [lldb] c4172c7 - [lldb] Fix 7b73de9ec2b19df040c919d3004dfbead9b6ac59

Author: Walter Erquinigo Date: 2022-05-09T21:12:11-07:00 New Revision: c4172c751a39313efd9c7588a103482c3648987e URL: https://github.com/llvm/llvm-project/commit/c4172c751a39313efd9c7588a103482c3648987e DIFF: https://github.com/llvm/llvm-project/commit/c4172c751a39313efd9c7588a103482c3648987e.di

[Lldb-commits] [lldb] b6bb9e7 - [lldb] Fix 7b73de9ec2b19df040c919d3004dfbead9b6ac59

Author: Walter Erquinigo Date: 2022-05-09T21:29:00-07:00 New Revision: b6bb9e7d61fd84caf1221eeb09a743e8393fb43f URL: https://github.com/llvm/llvm-project/commit/b6bb9e7d61fd84caf1221eeb09a743e8393fb43f DIFF: https://github.com/llvm/llvm-project/commit/b6bb9e7d61fd84caf1221eeb09a743e8393fb43f.di

[Lldb-commits] [lldb] 9d2dd6d - [NFC][lldb][trace] Use uint64_t when decoding and enconding json

Author: Walter Erquinigo Date: 2022-05-09T21:55:43-07:00 New Revision: 9d2dd6d7622335ba9c19b55ac7d463cf662cab0d URL: https://github.com/llvm/llvm-project/commit/9d2dd6d7622335ba9c19b55ac7d463cf662cab0d DIFF: https://github.com/llvm/llvm-project/commit/9d2dd6d7622335ba9c19b55ac7d463cf662cab0d.di

[Lldb-commits] [PATCH] D124858: [trace][intelpt] Support system-wide tracing [4] - Support per core tracing on lldb-server

wallace added inline comments. Comment at: lldb/docs/lldb-gdb-remote.txt:372-374 +// This limit applies to the sum of the sizes of all trace and core +// buffers for the current process, excluding the ones started with +// "thread tracing". ---

[Lldb-commits] [lldb] 285b39a - Revert "[NFC][lldb][trace] Use uint64_t when decoding and enconding json"

Author: Walter Erquinigo Date: 2022-05-09T22:47:05-07:00 New Revision: 285b39a31ec63a0253fa88c3c61f447712e2f131 URL: https://github.com/llvm/llvm-project/commit/285b39a31ec63a0253fa88c3c61f447712e2f131 DIFF: https://github.com/llvm/llvm-project/commit/285b39a31ec63a0253fa88c3c61f447712e2f131.di