[Lldb-commits] [PATCH] D125253: Add the ability to debug through an exec into ld

[jeffrey tan via Phabricator via lldb-commits]

yinghuitan added inline comments.


================
Comment at: 
lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp:312
   BreakpointSP dyld_break;
-  if (m_rendezvous.IsValid()) {
+  if (m_rendezvous.IsValid() && m_rendezvous.GetBreakAddress() != 0) {
     break_addr = m_rendezvous.GetBreakAddress();
----------------
Since zero break address is considered invalid, maybe move 
`m_rendezvous.GetBreakAddress() != 0` check into `DYLDRendezvous::IsValid()` 
method? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125253/new/

https://reviews.llvm.org/D125253

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits