[Lldb-commits] [PATCH] D122373: [NFC] Be more lazy about looking up simulator SDKs on macs

jasonmolenda created this revision. jasonmolenda added a reviewer: aprantl. jasonmolenda added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. This is a perf fix for when

[Lldb-commits] [PATCH] D120485: [lldb][Process/FreeBSD] Add support for address masks on aarch64

DavidSpickett added a comment. I did something along these lines for lldb-server memory tagging tests in `lldb/test/API/tools/lldb-server/memory-tagging/main.c`. In that case you've got 3 points where you we could skip the test, and you could check the auxv but that was overkill for this exampl

[Lldb-commits] [lldb] 00fb050 - [lldb] Remove unused Module argument (NFC)

Author: Nikita Popov Date: 2022-03-24T12:53:02+01:00 New Revision: 00fb0504082ea0b4b0c25d1ae773b39874d88e95 URL: https://github.com/llvm/llvm-project/commit/00fb0504082ea0b4b0c25d1ae773b39874d88e95 DIFF: https://github.com/llvm/llvm-project/commit/00fb0504082ea0b4b0c25d1ae773b39874d88e95.diff

[Lldb-commits] [lldb] b3fbbab - [lldb] Use byval type

Author: Nikita Popov Date: 2022-03-24T12:55:42+01:00 New Revision: b3fbbabdc1f7a52c0cc2756036a132b9aaab5742 URL: https://github.com/llvm/llvm-project/commit/b3fbbabdc1f7a52c0cc2756036a132b9aaab5742 DIFF: https://github.com/llvm/llvm-project/commit/b3fbbabdc1f7a52c0cc2756036a132b9aaab5742.diff

[Lldb-commits] [lldb] 840bb72 - [lldb] Avoid pointer element type accesses

Author: Nikita Popov Date: 2022-03-24T13:09:23+01:00 New Revision: 840bb725435c729f47458c48723d434ce45d57ee URL: https://github.com/llvm/llvm-project/commit/840bb725435c729f47458c48723d434ce45d57ee DIFF: https://github.com/llvm/llvm-project/commit/840bb725435c729f47458c48723d434ce45d57ee.diff

[Lldb-commits] [lldb] 9b79187 - [trace][intelpt] Server side changes for TSC to wall time conversion

Author: Jakob Johnson Date: 2022-03-24T05:36:21-07:00 New Revision: 9b79187c96a3bc2c245ab54d49accc12336f0cee URL: https://github.com/llvm/llvm-project/commit/9b79187c96a3bc2c245ab54d49accc12336f0cee DIFF: https://github.com/llvm/llvm-project/commit/9b79187c96a3bc2c245ab54d49accc12336f0cee.diff

[Lldb-commits] [PATCH] D122246: [trace][intelpt] Server side changes for TSC to wall time conversion

This revision was automatically updated to reflect the committed changes. Closed by commit rG9b79187c96a3: [trace][intelpt] Server side changes for TSC to wall time conversion (authored by jj10306). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Githu

[Lldb-commits] [PATCH] D122389: [lldb] Fix interpreting absolute Windows paths with forward slashes

mstorsjo created this revision. mstorsjo added a reviewer: labath. Herald added a project: All. mstorsjo requested review of this revision. Herald added a project: LLDB. In practice, Windows paths can use either backslashes or forward slashes. This fixes an issue reported downstream at https://gi

[Lldb-commits] [PATCH] D122293: [wip][intelpt] Refactoring instruction decoding for flexibility

wallace added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/DecodedThread.cpp:103-105 +// llvm::Error DecodedThread::GetError(uint64_t idx) const { +// return m_errors.at(idx); +// } Errors can only be copied, that's why we need to create a ne

[Lldb-commits] [PATCH] D122293: [wip][intelpt] Refactoring instruction decoding for flexibility

wallace added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/IntelPTDecoder.cpp:227 + +static Expected DecodeLiveThread(const ThreadSP &thread_sp, + TraceIntelPT &trace) { don't use expected. The D

[Lldb-commits] [PATCH] D118794: [lldb][AArch64] Remove non-address bits from addresses passed to ptrace on Linux

DavidSpickett updated this revision to Diff 417960. DavidSpickett added a comment. Herald added a project: All. Switch to removing non-address bits in lldb instead of lldb-server. The breakpoint issues I mention only really happen if you try to break on a tagged function pointer. Which is pretty

[Lldb-commits] [PATCH] D122411: [lldb][AArch64] Fix corefile memory reads when there are non-address bits

DavidSpickett created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Previously if you read a code/data mask before there was a valid threa

[Lldb-commits] [PATCH] D122411: [lldb][AArch64] Fix corefile memory reads when there are non-address bits

DavidSpickett added a reviewer: omjavaid. DavidSpickett added a comment. This smells a little bit like a hack but in some ways it makes sense that an address mask value couldn't possibly be valid until we have a thread setup. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[Lldb-commits] [lldb] aca9648 - [LLDB] Cleanup for Fixing DWARFExpression handling of ValueType::FileAddress case for DW_OP_deref_size

Author: Shafik Yaghmour Date: 2022-03-24T10:00:26-07:00 New Revision: aca96480784b5373ad7229816b00297690354208 URL: https://github.com/llvm/llvm-project/commit/aca96480784b5373ad7229816b00297690354208 DIFF: https://github.com/llvm/llvm-project/commit/aca96480784b5373ad7229816b00297690354208.dif

[Lldb-commits] [PATCH] D122041: [llvm][utils] Fix llvm::Optional summary provider

kastiglione added a comment. > There's some CMake trickery Can you shed some more light on this? Am I understanding right: these formatters are llvm, but the test would be in lldb? It seems weird that something in llvm/ would only have tests in lldb/. Would it be bad to move this file into lld

[Lldb-commits] [PATCH] D122293: [wip][intelpt] Refactoring instruction decoding for flexibility

zrthxn updated this revision to Diff 417969. zrthxn added a comment. Error gettting method Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122293/new/ https://reviews.llvm.org/D122293 Files: lldb/source/Plugins/Trace/intel-pt/DecodedThread.cpp l

[Lldb-commits] [PATCH] D122293: [wip][intelpt] Refactoring instruction decoding for flexibility

wallace requested changes to this revision. wallace added a comment. This revision now requires changes to proceed. there are many comments from the previous versions of this diff that you didn't apply. Go through all of them first :) Comment at: lldb/source/Plugins/Trace/inte

[Lldb-commits] [PATCH] D122293: [wip][intelpt] Refactoring instruction decoding for flexibility

zrthxn updated this revision to Diff 418000. zrthxn added a comment. Incorporate other comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122293/new/ https://reviews.llvm.org/D122293 Files: lldb/source/Plugins/Trace/intel-pt/DecodedThread.cp

[Lldb-commits] [PATCH] D122422: [lldb/crashlog] Parse more thread fields and pass it to crashlog scripted process

mib created this revision. mib added a reviewer: JDevlieghere. Herald added a project: All. mib requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Previously, the ScriptedThread used the thread index as the thread id. This patch parses the cr

[Lldb-commits] [PATCH] D122422: [lldb/crashlog] Parse more thread fields and pass it to crashlog scripted process

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122422/new/ https://reviews.llvm.org/D122422 __

[Lldb-commits] [PATCH] D122426: [lldb/Utility] Make `StructuredData::Dictionary::GetKeys1 return an `Array`

mib created this revision. mib added reviewers: JDevlieghere, kastiglione. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch changes `StructuredData::Dictionary::GetKeys` return type from an `Structure

[Lldb-commits] [PATCH] D122254: [trace][intelpt] Introduce instruction Ids

clayborg added inline comments. Comment at: lldb/include/lldb/Target/TraceCursor.h:162-166 + /// - In terms of efficiency, moving the cursor to a given id should be as + /// fast + /// as possible, but not necessarily O(1). That's why the recommended way to + /// travers

[Lldb-commits] [PATCH] D122429: [lldb/Plugin] Sort the ScriptedProcess' thread list before creating threads

mib created this revision. mib added reviewers: JDevlieghere, jingham. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. With Scripted Processes, in order to create scripted threads, the blueprint provides a dict

[Lldb-commits] [PATCH] D122254: [trace][intelpt] Introduce instruction Ids

wallace updated this revision to Diff 418032. wallace added a comment. fix some comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122254/new/ https://reviews.llvm.org/D122254 Files: lldb/include/lldb/Target/TraceCursor.h lldb/include/lldb

[Lldb-commits] [PATCH] D122254: [trace][intelpt] Introduce instruction Ids

wallace added inline comments. Comment at: lldb/include/lldb/Target/TraceInstructionDumper.h:50 + /// Additional options for configuring the dumping. + TraceInstructionDumper(lldb::TraceCursorUP &&cursor_up, Stream &s, + const TraceInstructionDumperO

[Lldb-commits] [PATCH] D122041: [llvm][utils] Fix llvm::Optional summary provider

aprantl added a comment. In D122041#3405821 , @kastiglione wrote: >> There's some CMake trickery > > Can you shed some more light on this? Am I understanding right: these > formatters are llvm, but the test would be in lldb? It seems weird that > somet

[Lldb-commits] [PATCH] D122373: [NFC] Be more lazy about looking up simulator SDKs on macs

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Fair word of warning — i've broken more than one LLDB build in the past while messing with this code :-) So you're basically sinking the calls to GetXcodeSDKPath into PlatformAppleSimulator

[Lldb-commits] [lldb] 9951578 - Don't search for sim SDK path until we know we need it

Author: Jason Molenda Date: 2022-03-24T15:44:57-07:00 New Revision: 99515783a63cd5018fa9231872dc5c8b13d64947 URL: https://github.com/llvm/llvm-project/commit/99515783a63cd5018fa9231872dc5c8b13d64947 DIFF: https://github.com/llvm/llvm-project/commit/99515783a63cd5018fa9231872dc5c8b13d64947.diff

[Lldb-commits] [PATCH] D122373: [NFC] Be more lazy about looking up simulator SDKs on macs

This revision was automatically updated to reflect the committed changes. Closed by commit rG99515783a63c: Don't search for sim SDK path until we know we need it (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122373/new/ h

[Lldb-commits] [PATCH] D122422: [lldb/crashlog] Parse thread fields and pass it to crashlog scripted process

mib updated this revision to Diff 418093. mib retitled this revision from "[lldb/crashlog] Parse more thread fields and pass it to crashlog scripted process" to "[lldb/crashlog] Parse thread fields and pass it to crashlog scripted process". mib edited the summary of this revision. mib added a com

[Lldb-commits] [PATCH] D121967: [LLDB][NativePDB] Create inline function decls

zequanwu updated this revision to Diff 418094. zequanwu added a comment. - change live debugging test to cpp file. - mirror fix on previous change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121967/new/ https://reviews.llvm.org/D121967 Files:

[Lldb-commits] [PATCH] D122429: [lldb/Plugin] Sort the ScriptedProcess' thread list before creating threads

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp:320 + + std::vector sorted_keys(keys->GetSize()); + auto sort_keys = [&sorted_keys](StructuredData::Object *item) -> bool { Won't this overflow when you ret

[Lldb-commits] [PATCH] D122461: [lldb] Add a fuzzer for target create

JDevlieghere created this revision. JDevlieghere added a reviewer: LLDB. Herald added a subscriber: mgorny. Herald added a project: All. JDevlieghere requested review of this revision. This patch adds a fuzzer that interprets inputs as object files and makes lldb create targets from them. It is v

[Lldb-commits] [PATCH] D122461: [lldb] Add a fuzzer for target create

JDevlieghere updated this revision to Diff 418133. JDevlieghere added a comment. Fix ASCII art CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122461/new/ https://reviews.llvm.org/D122461 Files: lldb/tools/CMakeLists.txt lldb/tools/lldb-fuzzer/CMakeLists.txt lldb/tools/lldb-fuzzer/