Author: Nikita Popov Date: 2022-03-24T12:53:02+01:00 New Revision: 00fb0504082ea0b4b0c25d1ae773b39874d88e95
URL: https://github.com/llvm/llvm-project/commit/00fb0504082ea0b4b0c25d1ae773b39874d88e95 DIFF: https://github.com/llvm/llvm-project/commit/00fb0504082ea0b4b0c25d1ae773b39874d88e95.diff LOG: [lldb] Remove unused Module argument (NFC) Added: Modified: lldb/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptx86ABIFixups.cpp Removed: ################################################################################ diff --git a/lldb/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptx86ABIFixups.cpp b/lldb/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptx86ABIFixups.cpp index f5c3c139a3ee2..f7f1982f4059a 100644 --- a/lldb/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptx86ABIFixups.cpp +++ b/lldb/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptx86ABIFixups.cpp @@ -24,10 +24,9 @@ using namespace lldb_private; -static bool isRSAPICall(llvm::Module &module, llvm::CallInst *call_inst) { +static bool isRSAPICall(llvm::CallInst *call_inst) { // TODO get the list of renderscript modules from lldb and check if // this llvm::Module calls into any of them. - (void)module; const auto func_name = call_inst->getCalledFunction()->getName(); if (func_name.startswith("llvm") || func_name.startswith("lldb")) return false; @@ -38,8 +37,7 @@ static bool isRSAPICall(llvm::Module &module, llvm::CallInst *call_inst) { return true; } -static bool isRSLargeReturnCall(llvm::Module &module, - llvm::CallInst *call_inst) { +static bool isRSLargeReturnCall(llvm::CallInst *call_inst) { // i686 and x86_64 returns for large vectors in the RenderScript API are not // handled as normal register pairs, but as a hidden sret type. This is not // reflected in the debug info or mangled symbol name, and the android ABI @@ -50,7 +48,6 @@ static bool isRSLargeReturnCall(llvm::Module &module, // It is perhaps an unreliable heuristic, and relies on bcc not generating // AVX code, so if the android ABI one day provides for AVX, this function // may go out of fashion. - (void)module; if (!call_inst || !call_inst->getCalledFunction()) return false; @@ -68,9 +65,7 @@ static bool isRSAllocationPtrTy(const llvm::Type *type) { ptr_type->getStructName().startswith("struct.rs_allocation"); } -static bool isRSAllocationTyCallSite(llvm::Module &module, - llvm::CallInst *call_inst) { - (void)module; +static bool isRSAllocationTyCallSite(llvm::CallInst *call_inst) { if (!call_inst->hasByValArgument()) return false; for (const auto *param : call_inst->operand_values()) @@ -125,7 +120,7 @@ static llvm::FunctionType *cloneToStructRetFnTy(llvm::CallInst *call_inst) { static bool findRSCallSites(llvm::Module &module, std::set<llvm::CallInst *> &rs_callsites, - bool (*predicate)(llvm::Module &, llvm::CallInst *)) { + bool (*predicate)(llvm::CallInst *)) { bool found = false; for (auto &func : module.getFunctionList()) @@ -136,7 +131,7 @@ findRSCallSites(llvm::Module &module, std::set<llvm::CallInst *> &rs_callsites, if (!call_inst || !call_inst->getCalledFunction()) // This is not the call-site you are looking for... continue; - if (isRSAPICall(module, call_inst) && predicate(module, call_inst)) { + if (isRSAPICall(call_inst) && predicate(call_inst)) { rs_callsites.insert(call_inst); found = true; } _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
