wallace added inline comments.
================ Comment at: lldb/include/lldb/Target/TraceInstructionDumper.h:50 + /// Additional options for configuring the dumping. + TraceInstructionDumper(lldb::TraceCursorUP &&cursor_up, Stream &s, + const TraceInstructionDumperOptions &options); ---------------- clayborg wrote: > Do we want the stream in the options? we can't do it nicely, because we are adding a TraceInstructionDumper variable in CommandObjectTraceDumpInstructions::CommandOptions, where we don't have a stream available. I imagine this being the only variable that we can't put in the options, so it should be okay Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122254/new/ https://reviews.llvm.org/D122254 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
