[Lldb-commits] [PATCH] D119548: [lldb] Fix race condition between lldb-vscode and stop hooks executor

ilya-nozhkin created this revision. ilya-nozhkin added reviewers: jingham, clayborg. ilya-nozhkin requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The race is between these two pieces of code that are executed in two separate lldb-vscode thr

[Lldb-commits] [PATCH] D119501: [lldb/crashlog] Replace interactive mode by CrashLogScriptedProcess

mib added a subscriber: clayborg. mib added a comment. @clayborg Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119501/new/ https://reviews.llvm.org/D119501 ___ lldb-commits mailing list lldb-commits@list

[Lldb-commits] [PATCH] D119501: [lldb/crashlog] Replace interactive mode by CrashLogScriptedProcess

mib added a comment. @clayborg I heard from Jim that you might be interested by this patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119501/new/ https://reviews.llvm.org/D119501 ___ lldb-commits mail

[Lldb-commits] [PATCH] D113498: [lldb] Constant-resolve operands to `getelementptr`

shafik added a comment. I was hoping you would add a positive test as well like the one I came up with that covered the new code as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113498/new/ https://reviews.llvm.org/D113498 _

[Lldb-commits] [PATCH] D113498: [lldb] Constant-resolve operands to `getelementptr`

werat added a comment. In D113498#3314729 , @shafik wrote: > I was hoping you would add a positive test as well like the one I came up > with that covered the new code as well. Oh, whoops, sorry, I don’t know how I missed your point :) I will add a test

[Lldb-commits] [PATCH] D119501: [lldb/crashlog] Replace interactive mode by CrashLogScriptedProcess

clayborg added a comment. I used this back when I worked at Apple to load thousands of crash logs and get information about the versions of a library that were all involved in the crash. From the Apple crash reporter site, download the zip file with all crash logs, load them all into, use inter

[Lldb-commits] [PATCH] D119501: [lldb/crashlog] Replace interactive mode by CrashLogScriptedProcess

JDevlieghere added a comment. In D119501#3314991 , @clayborg wrote: > I used this back when I worked at Apple to load thousands of crash logs and > get information about the versions of a library that were all involved in the > crash. From the Apple cra

[Lldb-commits] [PATCH] D119504: [lldb/crashlog] Fix exception signal parsing

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/examples/python/crashlog.py:471 exception_extra = "" -return "{} ({}){}".format(exception_type, exception_signal,

[Lldb-commits] [PATCH] D119388: [lldb/Plugin] Add artificial stackframe loading in ScriptedThread

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119388/new/ https://reviews.llvm.org/D119388 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [PATCH] D119388: [lldb/Plugin] Add artificial stackframe loading in ScriptedThread

shafik added inline comments. Comment at: lldb/source/Plugins/Process/scripted/ScriptedThread.cpp:159 + + size_t arr_size = arr_sp->GetSize(); + if (arr_size > std::numeric_limits::max()) `const` Comment at: lldb/source/Plugins/Process/script

[Lldb-commits] [PATCH] D119389: [lldb/crashlog] Add CrashLogScriptedProcess and resurrect_crashlog method

JDevlieghere added inline comments. Comment at: lldb/examples/python/crashlog.py:1098 +class ResurrectCrashProcess: +def __init__(self, debugger, internal_dict): Do we need this at all if we integrate it in the existing crashlog command?

[Lldb-commits] [PATCH] D119389: [lldb/crashlog] Add CrashLogScriptedProcess and resurrect_crashlog method

mib marked 3 inline comments as done. mib added inline comments. Comment at: lldb/examples/python/crashlog.py:1301-1302 'command script add -c lldb.macosx.crashlog.Symbolicate crashlog') +debugger.HandleCommand( +'command script add -c lldb.macosx.crashlog.Re

[Lldb-commits] [lldb] af96914 - [lldb] Pin the shared cache when iterating over its images

Author: Jonas Devlieghere Date: 2022-02-11T15:26:33-08:00 New Revision: af969141fa285157044e34fb6b27963c3278241b URL: https://github.com/llvm/llvm-project/commit/af969141fa285157044e34fb6b27963c3278241b DIFF: https://github.com/llvm/llvm-project/commit/af969141fa285157044e34fb6b27963c3278241b.d

[Lldb-commits] [PATCH] D119501: [lldb/crashlog] Add CrashLogScriptedProcess to replace interactive mode

mib updated this revision to Diff 408081. mib retitled this revision from "[lldb/crashlog] Replace interactive mode by CrashLogScriptedProcess" to "[lldb/crashlog] Add CrashLogScriptedProcess to replace interactive mode". mib edited the summary of this revision. mib added a comment. Herald added

[Lldb-commits] [PATCH] D119501: [lldb/crashlog] Add CrashLogScriptedProcess to replace interactive mode

JDevlieghere added a comment. Test? Comment at: lldb/examples/python/crashlog.py:990 +res = lldb.SBCommandReturnObject() +ci.HandleCommand('script from lldb.macosx import crashlog_scripted_process', res) +if not res.Succeeded(): Do we need to have

[Lldb-commits] [PATCH] D119602: Add additional method for ObjectFileMachO to find the first loadable segment in a Mach-O binary

jasonmolenda created this revision. jasonmolenda added a reviewer: JDevlieghere. jasonmolenda added a project: LLDB. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. When lldb is processing the first couple of binaries in a process launch, it needs to compu

[Lldb-commits] [PATCH] D119602: Add additional method for ObjectFileMachO to find the first loadable segment in a Mach-O binary

jasonmolenda updated this revision to Diff 408091. jasonmolenda added a comment. Fix typeo in comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119602/new/ https://reviews.llvm.org/D119602 Files: lldb/source/Plugins/ObjectFile/Mach-O/Object

[Lldb-commits] [PATCH] D119501: [lldb/crashlog] Add CrashLogScriptedProcess to replace interactive mode

mib marked an inline comment as done. mib added inline comments. Comment at: lldb/examples/python/crashlog.py:990 +res = lldb.SBCommandReturnObject() +ci.HandleCommand('script from lldb.macosx import crashlog_scripted_process', res) +if not res.Succeeded(): -

[Lldb-commits] [PATCH] D119501: [lldb/crashlog] Add CrashLogScriptedProcess & remove interactive mode

mib updated this revision to Diff 408107. mib marked an inline comment as done. mib retitled this revision from "[lldb/crashlog] Add CrashLogScriptedProcess to replace interactive mode" to "[lldb/crashlog] Add CrashLogScriptedProcess & remove interactive mode". mib added a comment. Address @JDev

[Lldb-commits] [PATCH] D119501: [lldb/crashlog] Add CrashLogScriptedProcess & remove interactive mode

JDevlieghere added inline comments. Comment at: lldb/examples/python/crashlog.py:990 +res = lldb.SBCommandReturnObject() +ci.HandleCommand('script from lldb.macosx import crashlog_scripted_process', res) +if not res.Succeeded(): mib wrote: > JDevlieg

[Lldb-commits] [PATCH] D119501: [lldb/crashlog] Add CrashLogScriptedProcess & remove interactive mode

mib marked 3 inline comments as done. mib added inline comments. Comment at: lldb/examples/python/crashlog.py:990 +res = lldb.SBCommandReturnObject() +ci.HandleCommand('script from lldb.macosx import crashlog_scripted_process', res) +if not res.Succeeded(): -

[Lldb-commits] [PATCH] D119616: [lldb] Replace asserts on .Success() with assertSuccess()

kastiglione created this revision. kastiglione added a reviewer: jingham. Herald added a subscriber: wenlei. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Replace forms of `assertTrue(x.Success())` with `assertSuccess(x)`. R

[Lldb-commits] [PATCH] D119616: [lldb] Replace asserts on .Success() with assertSuccess()

shafik added a comment. Can you please provide a motivation in the summary, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119616/new/ https://reviews.llvm.org/D119616 ___ lldb-commits mailing