JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: lldb/examples/python/crashlog.py:471
exception_extra = ""
- return "{} ({}){}".format(exception_type, exception_signal,
exception_extra)
----------------
mib wrote:
> @JDevlieghere Here it's only prepended by a space, which is honored in my
> change since I concatenate `"({})".format(json_exception['signal'])` to
> `exception_signal` (which is initialized with a space).
>
> I don't think this should have a trailing space because it's not guaranteed
> that we get something in `exception_extra`.
Thanks, I missed the `+` in `+=`, I thought it was just an assignment.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D119504/new/
https://reviews.llvm.org/D119504
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
