JDevlieghere added a comment.
Test?
================
Comment at: lldb/examples/python/crashlog.py:990
+ res = lldb.SBCommandReturnObject()
+ ci.HandleCommand('script from lldb.macosx import
crashlog_scripted_process', res)
+ if not res.Succeeded():
----------------
Do we need to have LLDB import it? Can we import it here straight from python?
================
Comment at: lldb/examples/python/crashlog.py:1148-1157
+ if options.interactive:
+ load_crashlog_in_scripted_process(debugger, crash_log_file)
+ elif options.batch:
+ crash_log = CrashLogParser().parse(debugger, crash_log_file,
options.verbose)
+ SymbolicateCrashLog(crash_log, options)
+ elif ci and ci.IsInteractive():
+ load_crashlog_in_scripted_process(debugger, crash_log_file)
----------------
I'd extract a helper to compute if we need the interactive or batch crashlog to
avoid the duplication across the clauses.
================
Comment at: lldb/examples/python/crashlog.py:1153-1154
+ SymbolicateCrashLog(crash_log, options)
+ elif ci and ci.IsInteractive():
+ load_crashlog_in_scripted_process(debugger, crash_log_file)
+ else:
----------------
Let's hold off on making the interactive one the default for now.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D119501/new/
https://reviews.llvm.org/D119501
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
