[Lldb-commits] [PATCH] D108889: Use dSYM SymbolFile Sections file addr instead of ObjectFile Section file addr when they differ in ObjectFileMachO

jasonmolenda updated this revision to Diff 369653. jasonmolenda added a comment. Update patch to incorporate Greg's suggestion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108889/new/ https://reviews.llvm.org/D108889 Files: lldb/source/Plugins

[Lldb-commits] [lldb] c1184ca - Use dSYM's file addr for Sections when it doesn't match binary

Author: Jason Molenda Date: 2021-08-31T01:35:07-07:00 New Revision: c1184ca6eb97e0ac5f7b6cdcc99e3905d27f9d95 URL: https://github.com/llvm/llvm-project/commit/c1184ca6eb97e0ac5f7b6cdcc99e3905d27f9d95 DIFF: https://github.com/llvm/llvm-project/commit/c1184ca6eb97e0ac5f7b6cdcc99e3905d27f9d95.diff

[Lldb-commits] [PATCH] D108889: Use dSYM SymbolFile Sections file addr instead of ObjectFile Section file addr when they differ in ObjectFileMachO

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc1184ca6eb97: Use dSYM's file addr for Sections when it doesn't match binary (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CHAN

[Lldb-commits] [lldb] aafa05e - [lldb] Add minidump save-core functionality to ELF object files

Author: Andrej Korman Date: 2021-08-31T13:04:38+02:00 New Revision: aafa05e03d629cc6605718c54575256d9d683659 URL: https://github.com/llvm/llvm-project/commit/aafa05e03d629cc6605718c54575256d9d683659 DIFF: https://github.com/llvm/llvm-project/commit/aafa05e03d629cc6605718c54575256d9d683659.diff

[Lldb-commits] [PATCH] D108233: WIP: Add minidump save-core functionality to ELF object files

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaafa05e03d62: [lldb] Add minidump save-core functionality to ELF object files (authored by Aj0SK, committed by werat). Changed prior to commit: ht

[Lldb-commits] [PATCH] D100263: [lldb] [gdb-remote client] Remove breakpoints in forked processes

mgorny updated this revision to Diff 369676. mgorny added a comment. Rebased CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100263/new/ https://reviews.llvm.org/D100263 Files: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp lldb/source/Plugins/Process/gdb-remote/ProcessG

[Lldb-commits] [PATCH] D100263: [lldb] [gdb-remote client] Remove breakpoints in forked processes

krytarowski accepted this revision. krytarowski added a comment. This revision is now accepted and ready to land. Looks correct. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100263/new/ https://reviews.llvm.org/D100263 ___ lldb-commits maili

[Lldb-commits] [lldb] 1f986f6 - Revert "[lldb] Add minidump save-core functionality to ELF object files"

Author: Andy Yankovsky Date: 2021-08-31T13:36:53+02:00 New Revision: 1f986f60573c6f4355c2d8a5c7ddcb2d32dfd43c URL: https://github.com/llvm/llvm-project/commit/1f986f60573c6f4355c2d8a5c7ddcb2d32dfd43c DIFF: https://github.com/llvm/llvm-project/commit/1f986f60573c6f4355c2d8a5c7ddcb2d32dfd43c.diff

[Lldb-commits] [lldb] 8307869 - [lldb] [gdb-remote client] Remove breakpoints in forked processes

Author: Michał Górny Date: 2021-08-31T13:41:35+02:00 New Revision: 8307869a224633d3516d98071b45fdec7314f8a3 URL: https://github.com/llvm/llvm-project/commit/8307869a224633d3516d98071b45fdec7314f8a3 DIFF: https://github.com/llvm/llvm-project/commit/8307869a224633d3516d98071b45fdec7314f8a3.diff

[Lldb-commits] [PATCH] D100263: [lldb] [gdb-remote client] Remove breakpoints in forked processes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8307869a2246: [lldb] [gdb-remote client] Remove breakpoints in forked processes (authored by mgorny). Herald added a project: LLDB. Repository: rG

[Lldb-commits] [PATCH] D108233: WIP: Add minidump save-core functionality to ELF object files

Aj0SK updated this revision to Diff 369686. Aj0SK added a comment. Fixes arm and aarch64 build run fails. Adding aarch64 to the matching in SystemInfo stream and activating test only on x86_64 as this is the only platform where also thread info etc. is being saved. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D108351: [lldb server] Tidy up LLDB server return codes and associated tests

saschwartz added a comment. Hey there - just wondering if someone might be able to merge this in a while? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108351/new/ https://reviews.llvm.org/D108351 ___ ll

[Lldb-commits] [PATCH] D108233: WIP: Add minidump save-core functionality to ELF object files

Aj0SK updated this revision to Diff 369722. Aj0SK added a comment. Fix not-correctly applied change from review regarding memory reading. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108233/new/ https://reviews.llvm.org/D108233 Files: lldb/incl

[Lldb-commits] [lldb] 4f7fb13 - [lldb] Don't save empty expressions in the multiline editor history

Author: Raphael Isemann Date: 2021-08-31T18:51:18+02:00 New Revision: 4f7fb13f87e10bd2cd89ccf2be70b026032237a7 URL: https://github.com/llvm/llvm-project/commit/4f7fb13f87e10bd2cd89ccf2be70b026032237a7 DIFF: https://github.com/llvm/llvm-project/commit/4f7fb13f87e10bd2cd89ccf2be70b026032237a7.dif

[Lldb-commits] [PATCH] D108983: [lldb] Don't save empty expressions in the multiline editor history

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4f7fb13f87e1: [lldb] Don't save empty expressions in the multiline editor history (authored by teemperor). Herald added a subscriber: lldb-commits.

[Lldb-commits] [PATCH] D109004: [lldb] Catch all exceptions when checking if simulator exists

augusto2112 created this revision. augusto2112 added a reviewer: aprantl. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Some lldb tests are failing intermittently due to the check for simulators failing for some reason unrela

[Lldb-commits] [PATCH] D109004: [lldb] Catch all exceptions when checking if simulator exists

teemperor added a comment. Herald added a subscriber: JDevlieghere. Do we know what the exception that is being thrown here? FWIW, `except Exception` will catch everything, even completely bogus things such as type errors, calling functions with the wrong arguments and things that should probab

[Lldb-commits] [PATCH] D109004: [lldb] Catch all exceptions when checking if simulator exists

augusto2112 added a comment. The error that happens in xcodebuild is: 2021-08-30 16:54:51.925 xcodebuild[95554:469108] DVTDownloadable: Failed to get authorization with error Error Domain=DVTDownloadableErrors Code=3 "The authorization was denied since no user interaction was possible." Use

Re: [Lldb-commits] New feature suggestion: Tacking variable update

From what I can tell, you are suggesting using instruction single stepping and printing out the variable value if it has changed. Is that right? That seems much more expensive than watchpoints, and it isn't clear to me what the benefits would be. I would be interested to hear more about the

[Lldb-commits] [PATCH] D108061: [lldb] Add support for shared library load when executable called through ld.

clayborg added a comment. In D108061#2973624 , @rdhindsa wrote: > For me, this test passes every time. I have tried multiple times with > instructions from failing bot, but haven't been able to reproduce the failure > locally yet. I will patch this int

Re: [Lldb-commits] New feature suggestion: Tacking variable update

BTW, if you do want to follow this approach, then you should look at the "thread plan tracer" bits built into lldb, if you haven't already seen them. The idea is that you can inject an automatic tracer into the machinery that governs how the program is executed. The tracer can either follow th

[Lldb-commits] [PATCH] D109013: [lldb] Tighten lock in Language::ForEach

bulbazord created this revision. bulbazord added reviewers: jingham, teemperor, JDevlieghere, clayborg, aprantl. bulbazord requested review of this revision. Herald added a project: LLDB. It is easy to accidentally introduce a deadlock by having the callback passed to Language::ForEach also attemp

[Lldb-commits] [PATCH] D100263: [lldb] [gdb-remote client] Remove breakpoints in forked processes

augusto2112 added a comment. Hi. It looks like the fork-follow-parent-softbp test is failing on CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100263/new/ https://reviews.llvm.org/D10

[Lldb-commits] [PATCH] D109013: [lldb] Tighten lock in Language::ForEach

bulbazord added a comment. For further context, I encountered this when debugging the test failures from D108229 . `BreakpointResolverName::AddNameLookup` constructs a `Module::LookupInfo` in a callback that it passes to `Language::ForEach`. Repository: rG

[Lldb-commits] [PATCH] D109013: [lldb] Tighten lock in Language::ForEach

clayborg added a comment. The language map is a global that contains unique pointers to a "Language *", so the language objects are intentionally leaked because the language map is kept alive due to C++ destructor chain issues, so this should be safe. LGTM. Anyone else have any objections? Re

[Lldb-commits] [PATCH] D100263: [lldb] [gdb-remote client] Remove breakpoints in forked processes

mgorny added a comment. In D100263#2975272 , @augusto2112 wrote: > Hi. It looks like the fork-follow-parent-softbp test is failing on CI. > Thanks for the ping. Shouldn't the bot have mailed

[Lldb-commits] [lldb] 84f99ef - [lldb] [test] Mark fork-follow-parent-softbp.test as darwin-unsupported

Author: Michał Górny Date: 2021-08-31T21:19:27+02:00 New Revision: 84f99ef2b196565d4a8b340d4eb9c923a5781697 URL: https://github.com/llvm/llvm-project/commit/84f99ef2b196565d4a8b340d4eb9c923a5781697 DIFF: https://github.com/llvm/llvm-project/commit/84f99ef2b196565d4a8b340d4eb9c923a5781697.diff

[Lldb-commits] [PATCH] D109004: [lldb] Catch all exceptions when checking if simulator exists

teemperor added a comment. Weird, in the test log it seems xcodebuild fails, but that would just raise a `CalledProcessError` (which we already catch here and cause the test to skip). And this would also not print anything to stderr as we set the stderr output in the `check_output` call to `/de

[Lldb-commits] [PATCH] D109004: [lldb] Catch all exceptions when checking if simulator exists

augusto2112 added a comment. My initial thought was that xcodebuild is throwing some other error (maybe, for some reason, it times out, which is a `subprocess.TimeoutExpired` exception), which is why my solution was to catch //any// exception thrown by `subprocess.check_output`. Many the secur

[Lldb-commits] [PATCH] D108983: [lldb] Don't save empty expressions in the multiline editor history

aprantl added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108983/new/ https://reviews.llvm.org/D108983 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.or

[Lldb-commits] [PATCH] D108233: WIP: Add minidump save-core functionality to ELF object files

clayborg added inline comments. Comment at: lldb/test/API/functionalities/process_save_core_minidump/TestProcessSaveCoreMinidump.py:17 + +@skipUnlessArch("x86_64") +@skipUnlessPlatform(["linux"]) Do we only support x86_64 right now? If we are actually su

[Lldb-commits] [PATCH] D109013: [lldb] Tighten lock in Language::ForEach

teemperor accepted this revision. teemperor added a comment. Yay! It's probably worth adding comment that `callback` might end up calling back into ForEach :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109013/new/ https://reviews.llvm.org/D1090

[Lldb-commits] [PATCH] D108233: WIP: Add minidump save-core functionality to ELF object files

Aj0SK added inline comments. Comment at: lldb/test/API/functionalities/process_save_core_minidump/TestProcessSaveCoreMinidump.py:17 + +@skipUnlessArch("x86_64") +@skipUnlessPlatform(["linux"]) clayborg wrote: > Do we only support x86_64 right now? If we

[Lldb-commits] [PATCH] D108061: [lldb] Add support for shared library load when executable called through ld.

clayborg added a comment. In D108061#2973624 , @rdhindsa wrote: > For me, this test passes every time. I have tried multiple times with > instructions from failing bot, but haven't been able to reproduce the failure > locally yet. A few things you can

[Lldb-commits] [PATCH] D109013: [lldb] Tighten lock in Language::ForEach

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG862a311301f5: [lldb] Tighten lock in Language::ForEach (authored by bulbazord). Changed prior to commit: https://reviews.llvm.org/D109013?vs=36975

[Lldb-commits] [lldb] 862a311 - [lldb] Tighten lock in Language::ForEach

Author: Alex Langford Date: 2021-08-31T15:45:38-07:00 New Revision: 862a311301f51214d405eefd5bc4aa7289241f86 URL: https://github.com/llvm/llvm-project/commit/862a311301f51214d405eefd5bc4aa7289241f86 DIFF: https://github.com/llvm/llvm-project/commit/862a311301f51214d405eefd5bc4aa7289241f86.diff

[Lldb-commits] [PATCH] D108061: [lldb] Add support for shared library load when executable called through ld.

clayborg added a comment. I tried with RelWithDebInfo and it failed, but it was because it wasn't building: devvm1358:~/local/llvm/main/Release $ ./bin/llvm-lit -sv ../llvm-project/lldb/test/API/api/multithreaded/TestMultithreaded.py llvm-lit: /home/gclayton/local/llvm/main/llvm-project/ll

[Lldb-commits] [PATCH] D100267: [lldb] [gdb-remote client] Remove breakpoints throughout vfork

krytarowski accepted this revision. krytarowski added a comment. This revision is now accepted and ready to land. Looks reasonable CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100267/new/ https://reviews.llvm.org/D100267 ___ lldb-commits mai

[Lldb-commits] [lldb] 199344d - [lldb] [gdb-remote client] Remove breakpoints throughout vfork

Author: Michał Górny Date: 2021-09-01T08:16:12+02:00 New Revision: 199344d832c1bed1d75b1db2c1493e5a3e5c5544 URL: https://github.com/llvm/llvm-project/commit/199344d832c1bed1d75b1db2c1493e5a3e5c5544 DIFF: https://github.com/llvm/llvm-project/commit/199344d832c1bed1d75b1db2c1493e5a3e5c5544.diff

[Lldb-commits] [PATCH] D100267: [lldb] [gdb-remote client] Remove breakpoints throughout vfork

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG199344d832c1: [lldb] [gdb-remote client] Remove breakpoints throughout vfork (authored by mgorny). Herald added a project: LLDB. Changed prior to co

[Lldb-commits] [lldb] ceccbb8 - Revert "[lldb] [gdb-remote client] Remove breakpoints throughout vfork"

Author: Michał Górny Date: 2021-09-01T08:53:35+02:00 New Revision: ceccbb8145c87d62c4a796d7b2a380083cf32331 URL: https://github.com/llvm/llvm-project/commit/ceccbb8145c87d62c4a796d7b2a380083cf32331 DIFF: https://github.com/llvm/llvm-project/commit/ceccbb8145c87d62c4a796d7b2a380083cf32331.diff

[Lldb-commits] [PATCH] D100267: [lldb] [gdb-remote client] Remove breakpoints throughout vfork

mgorny updated this revision to Diff 369869. mgorny added a comment. Try another approach for getting trap size. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100267/new/ https://reviews.llvm.org/D100267 Files: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp lldb/source

[Lldb-commits] [PATCH] D100267: [lldb] [gdb-remote client] Remove breakpoints throughout vfork

krytarowski accepted this revision. krytarowski added a comment. Let's see. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100267/new/ https://reviews.llvm.org/D100267 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llv