Aj0SK added inline comments.
================
Comment at:
lldb/test/API/functionalities/process_save_core_minidump/TestProcessSaveCoreMinidump.py:17
+
+ @skipUnlessArch("x86_64")
+ @skipUnlessPlatform(["linux"])
----------------
clayborg wrote:
> Do we only support x86_64 right now? If we are actually supporting other
> architectures and emitting a minidump for them, we should be testing them. Do
> we return an error for any architectures that we don't support in the
> ObjectFIleMinidump::SaveCore(...) function?
We only support "full-featured" minidump for the x86_64. For some platforms,
listed in AddSystemInfo method we provide minidump with only basic
information(SystemInfo, ModuleInfo and MiscInfo streams). For all other
platforms, no minidump is created and it will error-out...
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108233/new/
https://reviews.llvm.org/D108233
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
