[Lldb-commits] [PATCH] D106355: [DWARF5] Only fallback to manual index if no entry was found

kimanh marked an inline comment as not done. kimanh added a comment. Thanks once more for reviewing! If I should rename the variable (or anything else), let me know! Otherwise, could you help me to land this change (since I do not have committer rights)? Comment at: lldb/sour

[Lldb-commits] [lldb] ab5b8ee - [LLDB] Skip HW breakpoints test_step_until on Arm/Linux

Author: Muhammad Omair Javaid Date: 2021-07-28T13:18:14+05:00 New Revision: ab5b8ee1a7a18fe097419e21224ac4f15591bcd7 URL: https://github.com/llvm/llvm-project/commit/ab5b8ee1a7a18fe097419e21224ac4f15591bcd7 DIFF: https://github.com/llvm/llvm-project/commit/ab5b8ee1a7a18fe097419e21224ac4f15591bc

[Lldb-commits] [lldb] 6cd0e35 - Revert "[LLDB] Skip HW breakpoints test_step_until on Arm/Linux"

Author: Muhammad Omair Javaid Date: 2021-07-28T13:26:06+05:00 New Revision: 6cd0e35f43ac7aab8ff05acb4c5dfaa9071958d5 URL: https://github.com/llvm/llvm-project/commit/6cd0e35f43ac7aab8ff05acb4c5dfaa9071958d5 DIFF: https://github.com/llvm/llvm-project/commit/6cd0e35f43ac7aab8ff05acb4c5dfaa9071958

[Lldb-commits] [PATCH] D105182: [lldb] Add "memory tag write" command

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6a7a2ee8161d: [lldb] Add "memory tag write" command (authored by DavidSpickett). Changed prior to commit: https://reviews.llvm.org/D105182?vs=3620

[Lldb-commits] [lldb] 6a7a2ee - [lldb] Add "memory tag write" command

Author: David Spickett Date: 2021-07-28T10:12:50+01:00 New Revision: 6a7a2ee8161da84d9a58a88b497b0b47c8df99f3 URL: https://github.com/llvm/llvm-project/commit/6a7a2ee8161da84d9a58a88b497b0b47c8df99f3 DIFF: https://github.com/llvm/llvm-project/commit/6a7a2ee8161da84d9a58a88b497b0b47c8df99f3.diff

[Lldb-commits] [lldb] 5db8e23 - [lldb] Temporarily bump the max length of the pexpect error message to diagnose an lldb-aarch64 test failure

Author: Raphael Isemann Date: 2021-07-28T11:47:54+02:00 New Revision: 5db8e232126fc4c0f5d5b0339bdc5a49830268d1 URL: https://github.com/llvm/llvm-project/commit/5db8e232126fc4c0f5d5b0339bdc5a49830268d1 DIFF: https://github.com/llvm/llvm-project/commit/5db8e232126fc4c0f5d5b0339bdc5a49830268d1.dif

[Lldb-commits] [lldb] 30308d1 - [LLDB] Skip HW breakpoints test_step_until on Arm/Linux

Author: Muhammad Omair Javaid Date: 2021-07-28T15:30:47+05:00 New Revision: 30308d1eb966afa35ee2fd5c5b47b17eb0382896 URL: https://github.com/llvm/llvm-project/commit/30308d1eb966afa35ee2fd5c5b47b17eb0382896 DIFF: https://github.com/llvm/llvm-project/commit/30308d1eb966afa35ee2fd5c5b47b17eb03828

[Lldb-commits] [lldb] 0dc9c88 - [LLDB] Skip TestGuiBasicDebug.py on Arm/AArch64 Linux

Author: Muhammad Omair Javaid Date: 2021-07-28T15:30:48+05:00 New Revision: 0dc9c88aa38ed330ddffe92bae79d4066832c38e URL: https://github.com/llvm/llvm-project/commit/0dc9c88aa38ed330ddffe92bae79d4066832c38e DIFF: https://github.com/llvm/llvm-project/commit/0dc9c88aa38ed330ddffe92bae79d4066832c3

[Lldb-commits] [PATCH] D105183: [lldb] Add "memory tag write" --end-addr option

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6eded00e0c6b: [lldb] Add "memory tag write" --end-addr option (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [lldb] 6eded00 - [lldb] Add "memory tag write" --end-addr option

Author: David Spickett Date: 2021-07-28T14:05:40+01:00 New Revision: 6eded00e0c6b4e06225df74292c078030556b8ce URL: https://github.com/llvm/llvm-project/commit/6eded00e0c6b4e06225df74292c078030556b8ce DIFF: https://github.com/llvm/llvm-project/commit/6eded00e0c6b4e06225df74292c078030556b8ce.diff

[Lldb-commits] [PATCH] D104914: [lldb] Correct format of qMemTags type field

DavidSpickett updated this revision to Diff 362366. DavidSpickett added a comment. - Rebase onto main - Update the way we cast down to int32_t to avoid use of static_cast. We weren't invoking the undefined behaviour of unsigned to signed due to the limit check. However I think this shows our inte

[Lldb-commits] [PATCH] D102757: [lldb] Remove non address bits when looking up memory regions

DavidSpickett updated this revision to Diff 362383. DavidSpickett added a comment. - Rebase onto main - Add DoGetMemoryRegionInfo for ScriptedProcess I'm going to build this and the follow up patch on Windows to get some more coverage. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[Lldb-commits] [PATCH] D103626: [lldb][AArch64] Remove non address bits from memory read arguments

DavidSpickett updated this revision to Diff 362384. DavidSpickett added a comment. Rebase onto main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103626/new/ https://reviews.llvm.org/D103626 Files: lldb/source/Commands/CommandObjectMemory.cpp

[Lldb-commits] [lldb] 83c752b - Revert "[lldb] Temporarily bump the max length of the pexpect error message to diagnose an lldb-aarch64 test failure"

Author: Raphael Isemann Date: 2021-07-28T18:11:52+02:00 New Revision: 83c752bfa6071f34c8c4564a379d99b1b94f604a URL: https://github.com/llvm/llvm-project/commit/83c752bfa6071f34c8c4564a379d99b1b94f604a DIFF: https://github.com/llvm/llvm-project/commit/83c752bfa6071f34c8c4564a379d99b1b94f604a.dif

[Lldb-commits] [PATCH] D106171: [lldb] Avoid moving ThreadPlanSP from plans vector

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. IIRC the fact that the shared pointer is null is implementation defined and the standard just says that a moved-from object is in an undefined state. Comment at:

[Lldb-commits] [PATCH] D106584: [lldb] Assert file cache and live memory are equal on debug builds

augusto2112 updated this revision to Diff 362435. augusto2112 added a comment. Add setting to enable assert Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106584/new/ https://reviews.llvm.org/D106584 Files: lldb/include/lldb/Core/Section.h lldb

[Lldb-commits] [PATCH] D106584: [lldb] Assert file cache and live memory are equal on debug builds

JDevlieghere added a comment. Should this be enabled in the test suite? (`packages/Python/lldbsuite/test/lldbtest.py:783`, `test/Shell/lit-lldb-init.in`) Comment at: lldb/source/Target/Target.cpp:1773 + if (load_addr != LLDB_INVALID_ADDRESS) { +uint8_t *l

[Lldb-commits] [PATCH] D106192: [LLDB][GUI] Add Create Target form

OmarEmaraDev updated this revision to Diff 362450. OmarEmaraDev added a comment. - Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106192/new/ https://reviews.llvm.org/D106192 Files: lldb/source/Core/IOHandlerCursesGUI.cpp

[Lldb-commits] [lldb] aad17c5 - [trace] Introduce Hierarchical Trace Representation (HTR) and add command for Intel PT trace visualization

Author: Walter Erquinigo Date: 2021-07-28T11:04:13-07:00 New Revision: aad17c55a8116cd3831d4392d909139702019d65 URL: https://github.com/llvm/llvm-project/commit/aad17c55a8116cd3831d4392d909139702019d65 DIFF: https://github.com/llvm/llvm-project/commit/aad17c55a8116cd3831d4392d909139702019d65.di

[Lldb-commits] [PATCH] D105741: [trace] Introduce Hierarchical Trace Representation (HTR) and add `thread trace export ctf` command for Intel PT trace visualization

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaad17c55a811: [trace] Introduce Hierarchical Trace Representation

[Lldb-commits] [PATCH] D105741: [trace] Introduce Hierarchical Trace Representation (HTR) and add `thread trace export ctf` command for Intel PT trace visualization

wallace added a comment. Landed as aad17c55a8116cd3831d4392d909139702019d65 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105741/new/ https://reviews.llvm.org/D105741 _

[Lldb-commits] [PATCH] D106984: [lldb] [gdb-remote] Add eOpenOptionReadWrite for future gdb compat

mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski, jasonmolenda, clayborg, JDevlieghere. mgorny requested review of this revision. Modify OpenOptions enum to open the future path into synchronizing vFile:open bits with GDB. Currently, LLDB and GDB use different fl

[Lldb-commits] [PATCH] D106985: [lldb] [gdb-remote] Sync vFile:open mode constants with GDB

mgorny created this revision. mgorny added reviewers: krytarowski, labath, emaste, jasonmolenda, JDevlieghere, clayborg. mgorny requested review of this revision. Sync the mode constants used to drive vFile:open requests with these used by GDB and defined for the gdb remote protocol. This makes

[Lldb-commits] [PATCH] D105215: [lldb] Remove CPlusPlusLanguage from Mangled

bulbazord added a comment. Thanks for the reviews and comments! It's kind of unfortunate that LLDB is like this right now but I believe this patch is a step in the right direction. :) Comment at: lldb/source/Core/Mangled.cpp:322 if (preference == ePreferDemangledWithoutArgu

[Lldb-commits] [PATCH] D106999: [LLDB][GUI] Add Environment Variable Field

OmarEmaraDev created this revision. OmarEmaraDev added a reviewer: clayborg. Herald added a reviewer: teemperor. OmarEmaraDev requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch adds an environment variable field. This is usually use

[Lldb-commits] [PATCH] D106999: [LLDB][GUI] Add Environment Variable Field

OmarEmaraDev added a comment. Herald added a subscriber: JDevlieghere. Example list of environment fields: F18194751: 20210728-221522.png <https://reviews.llvm.org/F18194751> Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106999/new/

[Lldb-commits] [lldb] 4b88a94 - Revert "[trace] Introduce Hierarchical Trace Representation (HTR) and add command for Intel PT trace visualization"

Author: Muhammad Omair Javaid Date: 2021-07-29T01:34:24+05:00 New Revision: 4b88a94ebe08054ad88435cc89aaa3b84e41b938 URL: https://github.com/llvm/llvm-project/commit/4b88a94ebe08054ad88435cc89aaa3b84e41b938 DIFF: https://github.com/llvm/llvm-project/commit/4b88a94ebe08054ad88435cc89aaa3b84e41b9

[Lldb-commits] [PATCH] D105741: [trace] Introduce Hierarchical Trace Representation (HTR) and add `thread trace export ctf` command for Intel PT trace visualization

omjavaid added a comment. In D105741#2910908 , @wallace wrote: > Landed as aad17c55a8116cd3831d4392d909139702019d65 > Temporarily reverted this change as it breaks LLDB build on 32 bi

[Lldb-commits] [PATCH] D106985: [lldb] [gdb-remote] Sync vFile:open mode constants with GDB

mgorny updated this revision to Diff 362521. mgorny added a comment. Add a test for correct flag encoding. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106985/new/ https://reviews.llvm.org/D106985 Files: lldb/docs/lldb-platform-packets.txt lldb/include/lldb/Host/File.h lldb/sour

[Lldb-commits] [PATCH] D106584: [lldb] Assert file cache and live memory are equal on debug builds

augusto2112 updated this revision to Diff 362523. augusto2112 added a comment. Run file-cache verification on tests, change raw buffer to unique pointer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106584/new/ https://reviews.llvm.org/D106584 Fil

[Lldb-commits] [PATCH] D106985: [lldb] [gdb-remote] Sync vFile:open mode constants with GDB

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Thanks for fixing this, it's long overdue. For a long time I thought we'd need to operate in a compatibility mode to accept either set of constants, but I finally realized I was w

[Lldb-commits] [PATCH] D106584: [lldb] Assert file cache and live memory are equal on debug builds

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Looks great! Thanks for doing this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106584/new/ https://reviews.llvm.org/D106584 ___

[Lldb-commits] [lldb] d52ba48 - [trace] Introduce Hierarchical Trace Representation (HTR) and add command for Intel PT trace visualization

Author: Walter Erquinigo Date: 2021-07-28T13:56:45-07:00 New Revision: d52ba48821301c33650b97cd9f262615fcc0fdc1 URL: https://github.com/llvm/llvm-project/commit/d52ba48821301c33650b97cd9f262615fcc0fdc1 DIFF: https://github.com/llvm/llvm-project/commit/d52ba48821301c33650b97cd9f262615fcc0fdc1.di

[Lldb-commits] [PATCH] D100243: [LLDB][GUI] Expand selected thread tree item by default

omjavaid added a comment. This change has caused various GUI related tests to fail randomly. https://lab.llvm.org/buildbot/#/builders/96/builds/10100 This also causes random failures of one of the most resource sufficient buildbot here: https://lab.llvm.org/buildbot/#/builders/68/builds/16275 h

[Lldb-commits] [PATCH] D106192: [LLDB][GUI] Add Create Target form

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106192/new/ https://reviews.llvm.org/D106192

[Lldb-commits] [PATCH] D106999: [LLDB][GUI] Add Environment Variable Field

clayborg added inline comments. Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:1924 + +class EnvironmentVariableFieldDelegate : public FieldDelegate { +public: There are other things that could benefit from having two text fields, like source mapping: ``` (

[Lldb-commits] [PATCH] D107015: Add "current" token for the -t option to "break set/modify"

jingham created this revision. jingham added reviewers: kastiglione, JDevlieghere. Herald added a subscriber: dang. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. It's fairly common to want to set a breakpoint that is limited to th

[Lldb-commits] [PATCH] D106171: [lldb] Avoid moving ThreadPlanSP from plans vector

kastiglione added a comment. In D106171#2910693 , @JDevlieghere wrote: > IIRC the fact that the shared pointer is null is implementation defined and > the standard just says that a moved-from object is in an undefined state. According to cppreference,

[Lldb-commits] [PATCH] D106584: [lldb] Assert file cache and live memory are equal on debug builds

JDevlieghere accepted this revision. JDevlieghere added a comment. Seems like this is still missing form `lit-lldb-init.in` which means the shell tests (and by extension the Swift REPL tests downstream) will run with the setting off. Other than that this LGTM. Repository: rG LLVM Github Mono