[Lldb-commits] [PATCH] D106584: [lldb] Assert file cache and live memory are equal on debug builds

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere added a comment.

Should this be enabled in the test suite? 
(`packages/Python/lldbsuite/test/lldbtest.py:783`, 
`test/Shell/lit-lldb-init.in`)



================
Comment at: lldb/source/Target/Target.cpp:1773
+          if (load_addr != LLDB_INVALID_ADDRESS) {
+            uint8_t *live_buf = (uint8_t *)malloc(dst_len);
+            bytes_read =
----------------
Can we use a unique_ptr here (`std::make_unique<uint8_t[]>`)?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106584/new/

https://reviews.llvm.org/D106584

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits