[Lldb-commits] [PATCH] D101893: [Process/elf-core] Read PID from FreeBSD prpsinfo

mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski. Herald added a subscriber: arichardson. mgorny requested review of this revision. Add a function to read NT_PRPSINFO note from FreeBSD core dumps. This is necessary to get the process ID (NT_PRSTATUS has only threa

[Lldb-commits] [PATCH] D97281: [lldb][AArch64] Add class for managing memory tags

omjavaid added a comment. This looks ok to me apart from some cosmetic nits. Also you may figure out a way to clean up the whole address including pauth now after D99944 is merged. Comment at: lldb/include/lldb/Target/MemoryTagManager.h:72 +

[Lldb-commits] [PATCH] D101903: [LLDB] Don't use the local python to set a default for LLDB_PYTHON_RELATIVE_PATH when cross compiling.

mstorsjo created this revision. mstorsjo added a reviewer: JDevlieghere. Herald added a subscriber: mgorny. mstorsjo requested review of this revision. Herald added a project: LLDB. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D101903 Files: lldb/CMakeLists.txt Index: lldb/

[Lldb-commits] [PATCH] D101903: [LLDB] Don't use the local python to set a default for LLDB_PYTHON_RELATIVE_PATH when cross compiling.

JDevlieghere accepted this revision. JDevlieghere added inline comments. This revision is now accepted and ready to land. Comment at: lldb/CMakeLists.txt:48 +message(FATAL_ERROR + "Crosscompiling with python requires manually setting + LLDB_PYTHON_RELATIVE_PATH.") -

[Lldb-commits] [lldb] 632ebc4 - [MC] Untangle MCContext and MCObjectFileInfo

Author: Philipp Krones Date: 2021-05-05T10:03:02-07:00 New Revision: 632ebc4ab4374e53fce1ec870465c587e0a33668 URL: https://github.com/llvm/llvm-project/commit/632ebc4ab4374e53fce1ec870465c587e0a33668 DIFF: https://github.com/llvm/llvm-project/commit/632ebc4ab4374e53fce1ec870465c587e0a33668.diff

Re: [Lldb-commits] [lldb] 30fcdf0 - [lldb/Symbol] Update SymbolFilePDB unitest with SourceLocationSpec

The last location_spec On line 341 does not seem to be used. > On May 4, 2021, at 5:34 PM, Med Ismail Bennani via lldb-commits > mailto:lldb-commits@lists.llvm.org>> wrote: > > > Author: Med Ismail Bennani > Date: 2021-05-05T00:34:44Z > New Revision: 30fcdf0b19661ca77767bd41ceba03f5dd33

Re: [Lldb-commits] [lldb] 30fcdf0 - [lldb/Symbol] Update SymbolFilePDB unitest with SourceLocationSpec

Apologies, I see now you fixed it in a separate commit. > On May 5, 2021, at 10:19 AM, Shafik Yaghmour via lldb-commits > wrote: > > The last > > location_spec > > On line 341 does not seem to be used. > >> On May 4, 2021, at 5:34 PM, Med Ismail Bennani via lldb-commits >> mailto:lldb-comm

[Lldb-commits] [PATCH] D101933: If an interrupt fails, don't try to fetch any more packets from the server

jingham created this revision. jingham added reviewers: clayborg, JDevlieghere, labath. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When a gdb-remote plugin process doesn't respond to an interrupt, it returns from SendContinueP

[Lldb-commits] [PATCH] D101903: [LLDB] Don't use the local python to set a default for LLDB_PYTHON_RELATIVE_PATH when cross compiling.

mstorsjo added inline comments. Comment at: lldb/CMakeLists.txt:48 +message(FATAL_ERROR + "Crosscompiling with python requires manually setting + LLDB_PYTHON_RELATIVE_PATH.") JDevlieghere wrote: > Are there other reasons `LLDB_PYTHON_RELATIVE_PATH`

[Lldb-commits] [PATCH] D101933: If an interrupt fails, don't try to fetch any more packets from the server

clayborg accepted this revision. clayborg added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:3698-3701 +// If the process has exited, don't try to fetch more events from the +//

[Lldb-commits] [PATCH] D101585: [lldb] Ensure SBStructuredData::m_impl_up is always non-null

kastiglione updated this revision to Diff 343208. kastiglione added a comment. Herald added a subscriber: mgorny. Add unittest Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101585/new/ https://reviews.llvm.org/D101585 Files: lldb/source/API/SBSt

[Lldb-commits] [lldb] c5cf4b8 - [lldb] Handle missing SBStructuredData copy assignment cases

Author: Dave Lee Date: 2021-05-05T15:12:03-07:00 New Revision: c5cf4b8f11cd641560b0cd6e106765721688e74a URL: https://github.com/llvm/llvm-project/commit/c5cf4b8f11cd641560b0cd6e106765721688e74a DIFF: https://github.com/llvm/llvm-project/commit/c5cf4b8f11cd641560b0cd6e106765721688e74a.diff LOG:

[Lldb-commits] [PATCH] D101585: [lldb] Ensure SBStructuredData::m_impl_up is always non-null

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc5cf4b8f11cd: [lldb] Handle missing SBStructuredData copy assignment cases (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D95601: [lldb][AArch64] Add memory tag reading to lldb-server

omjavaid added a comment. it look good to me but I have some final minor nits inline. Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:1458 + + struct iovec tags_vec; + uint8_t *dest = &tags[0]; may be rename to tags_iovec? because reading