JDevlieghere accepted this revision.
JDevlieghere added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lldb/CMakeLists.txt:48
+    message(FATAL_ERROR
+      "Crosscompiling with python requires manually setting
+      LLDB_PYTHON_RELATIVE_PATH.")
----------------
Are there other reasons `LLDB_PYTHON_RELATIVE_PATH` could be empty at this 
point, unrelated to cross compilation? Would it make sense to move the error in 
the else clause of `if (NOT CMAKE_CROSSCOMPILING)` instead? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101903/new/

https://reviews.llvm.org/D101903

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to