mstorsjo added inline comments.
================
Comment at: lldb/CMakeLists.txt:48
+ message(FATAL_ERROR
+ "Crosscompiling with python requires manually setting
+ LLDB_PYTHON_RELATIVE_PATH.")
----------------
JDevlieghere wrote:
> Are there other reasons `LLDB_PYTHON_RELATIVE_PATH` could be empty at this
> point, unrelated to cross compilation? Would it make sense to move the error
> in the else clause of `if (NOT CMAKE_CROSSCOMPILING)` instead?
I guess it could be if the python command above succeeded, but output an empty
string.
My cmake-fu isn't very strong, but I wonder if it's ok to check
`${LLDB_PYTHON_RELATIVE_PATH}` before the `set(LLDB_PYTHON_RELATIVE_PATH
${LLDB_PYTHON_DEFAULT_RELATIVE_PATH} CACHE ...)` command? I guess it is,
because it's going to need to be set beforehand anyway?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101903/new/
https://reviews.llvm.org/D101903
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
