[Lldb-commits] [lldb] 8f63cf5 - [lldb][NFC] Cleanup ValueObject construction code

Author: Raphael Isemann Date: 2021-02-23T09:39:18+01:00 New Revision: 8f63cf5da3c098f5f16a1055d6e13d4bcf399a27 URL: https://github.com/llvm/llvm-project/commit/8f63cf5da3c098f5f16a1055d6e13d4bcf399a27 DIFF: https://github.com/llvm/llvm-project/commit/8f63cf5da3c098f5f16a1055d6e13d4bcf399a27.dif

[Lldb-commits] [PATCH] D97199: [lldb][NFC] Cleanup ValueObject construction code

This revision was automatically updated to reflect the committed changes. Closed by commit rG8f63cf5da3c0: [lldb][NFC] Cleanup ValueObject construction code (authored by teemperor). Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[Lldb-commits] [PATCH] D97205: [lldb][NFC] Don't inherit from UserID in ValueObject

teemperor updated this revision to Diff 325708. teemperor added a comment. - Rebased. - Add a `GetID()` call where we relied on the `==` overload before. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97205/new/ https://reviews.llvm.org/D97205 Files: lldb/include/lldb/Core/ValueObject

[Lldb-commits] [lldb] d77e3c6 - [lldb][NFC] Don't inherit from UserID in ValueObject

Author: Raphael Isemann Date: 2021-02-23T10:15:42+01:00 New Revision: d77e3c6aec2916fdf7b8ab0ca08c550230244695 URL: https://github.com/llvm/llvm-project/commit/d77e3c6aec2916fdf7b8ab0ca08c550230244695 DIFF: https://github.com/llvm/llvm-project/commit/d77e3c6aec2916fdf7b8ab0ca08c550230244695.dif

[Lldb-commits] [PATCH] D97205: [lldb][NFC] Don't inherit from UserID in ValueObject

This revision was automatically updated to reflect the committed changes. Closed by commit rGd77e3c6aec29: [lldb][NFC] Don't inherit from UserID in ValueObject (authored by teemperor). Herald added a subscriber: lldb-commits. Changed prior to commit: https://reviews.llvm.org/D97205?vs=325708&id

[Lldb-commits] [lldb] 03310c1 - [lldb][NFC] Give CompilerType's IsArrayType/IsVectorType/IsBlockPointerType out-parameters default values

Author: Raphael Isemann Date: 2021-02-23T11:15:31+01:00 New Revision: 03310c1e952d0bf7aa84b8ed06809aa7ea1deb9b URL: https://github.com/llvm/llvm-project/commit/03310c1e952d0bf7aa84b8ed06809aa7ea1deb9b DIFF: https://github.com/llvm/llvm-project/commit/03310c1e952d0bf7aa84b8ed06809aa7ea1deb9b.dif

[Lldb-commits] [PATCH] D96460: [LLDB] Arm64/Linux Add MTE and Pointer Authentication registers

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/Utility/RegisterInfoPOSIX_arm64.cpp:276 +if (opt_regsets & eRegsetEnableMTE) + m_mte_regset_enabled = true; } omjavaid wrote: > DavidSpickett wrote: > > (like earlier) would

[Lldb-commits] [PATCH] D96463: [LLDB] Arm64/Linux test case for MTE and Pointer Authentication regset

DavidSpickett added inline comments. Comment at: lldb/test/API/commands/register/register/aarch64_dynamic_regset/TestArm64DynamicRegsets.py:45 + +self.expect("register read ffr", substrs=[p_regs_value]) + omjavaid wrote: > DavidSpickett wrote: > > Do we

[Lldb-commits] [lldb] bda83ba - [lldb][NFC] Clean up ValueObject comments

Author: Raphael Isemann Date: 2021-02-23T12:02:36+01:00 New Revision: bda83ba0d296303dff02d262cab73dc984cda3c1 URL: https://github.com/llvm/llvm-project/commit/bda83ba0d296303dff02d262cab73dc984cda3c1 DIFF: https://github.com/llvm/llvm-project/commit/bda83ba0d296303dff02d262cab73dc984cda3c1.dif

[Lldb-commits] [lldb] bea2d5e - [lldb][NFC] Remove unused ValueObject::LogValueObject functions

Author: Raphael Isemann Date: 2021-02-23T12:10:40+01:00 New Revision: bea2d5e47867687c8d2f95bd70ed9a77d19eeb6e URL: https://github.com/llvm/llvm-project/commit/bea2d5e47867687c8d2f95bd70ed9a77d19eeb6e DIFF: https://github.com/llvm/llvm-project/commit/bea2d5e47867687c8d2f95bd70ed9a77d19eeb6e.dif

[Lldb-commits] [PATCH] D97165: [lldb] Add deref support and tests to shared_ptr synthetic

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. This LGTM modulo a missing nullptr check. Thanks for fixing this! Also we probably should investigate the `strong=` summary differences. I would have blamed the fake constructors we are

[Lldb-commits] [lldb] 2f75363 - [lldb] [test] Un-XFAIL a test that no longer fail on FreeBSD

Author: Michał Górny Date: 2021-02-23T14:35:34+01:00 New Revision: 2f75363a9e138429d5c80ca0a541247a5bc70614 URL: https://github.com/llvm/llvm-project/commit/2f75363a9e138429d5c80ca0a541247a5bc70614 DIFF: https://github.com/llvm/llvm-project/commit/2f75363a9e138429d5c80ca0a541247a5bc70614.diff

[Lldb-commits] [lldb] 6c06b0a - [lldb] [test] Un-XFAIL TestBuiltinTrap on FreeBSD/aarch64

Author: Michał Górny Date: 2021-02-23T14:35:34+01:00 New Revision: 6c06b0aa5a5534a370532c287cf35a96eeb2146e URL: https://github.com/llvm/llvm-project/commit/6c06b0aa5a5534a370532c287cf35a96eeb2146e DIFF: https://github.com/llvm/llvm-project/commit/6c06b0aa5a5534a370532c287cf35a96eeb2146e.diff

[Lldb-commits] [PATCH] D97281: [lldb][AArch64] Add class for managing memory tags

DavidSpickett created this revision. Herald added subscribers: danielkiss, kristof.beyls, mgorny. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This adds the MemoryTagManager class and a specialisation of that class for AArc

[Lldb-commits] [PATCH] D97281: [lldb][AArch64] Add class for managing memory tags

DavidSpickett added reviewers: labath, omjavaid. DavidSpickett added a comment. Herald added a subscriber: JDevlieghere. Omair, I've taken one of your suggestions on the class name from the other review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[Lldb-commits] [PATCH] D97282: [lldb][AArch64] Add memory-tagging qSupported feature

DavidSpickett created this revision. Herald added subscribers: danielkiss, kristof.beyls, krytarowski. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This feature "memory-tagging+" indicates that lldb-server supports memory t

[Lldb-commits] [PATCH] D97282: [lldb][AArch64] Add memory-tagging qSupported feature

DavidSpickett added a comment. This feature name matches the one GDB is planning to use: https://sourceware.org/pipermail/gdb-patches/2021-January/175514.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97282/new/ https://reviews.llvm.org/D97282

[Lldb-commits] [PATCH] D95601: [lldb][AArch64] Add MTE memory tag reading to lldb-server

DavidSpickett updated this revision to Diff 325767. DavidSpickett added a comment. Split the patches into smaller changes. (see stack) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95601/new/ https://reviews.llvm.org/D95601 Files: lldb/include/l

[Lldb-commits] [PATCH] D95602: [lldb][AArch64] Add MTE memory tag reading for lldb

DavidSpickett updated this revision to Diff 325769. DavidSpickett added a comment. Split into smaller changes. Tag read command is now a further change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95602/new/ https://reviews.llvm.org/D95602 Files

[Lldb-commits] [PATCH] D97284: [lldb][AArch64] Add MTE CPU feature test predicate

DavidSpickett created this revision. Herald added subscribers: danielkiss, kristof.beyls. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Change the logic slightly so that the feature can be anywhere in the list. Repository:

[Lldb-commits] [PATCH] D97284: [lldb][AArch64] Add MTE CPU feature test predicate

DavidSpickett added a reviewer: omjavaid. DavidSpickett added a comment. Herald added a subscriber: JDevlieghere. I think we both have something like this in our changes. Yours will probably land sooner but here it is anyway. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[Lldb-commits] [PATCH] D97285: [lldb][AArch64] Add "memory tag read" command

DavidSpickett created this revision. Herald added subscribers: danielkiss, kristof.beyls, mgorny. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This new command looks much like "memory read" and mirrors its basic behaviour.

[Lldb-commits] [PATCH] D97285: [lldb][AArch64] Add "memory tag read" command

DavidSpickett added reviewers: omjavaid, labath. DavidSpickett added a comment. This command is described in the RFC under the name "mtag showatag" (https://lists.llvm.org/pipermail/lldb-dev/2020-August/016402.html). The change of naming was suggested in feedback and I think it does fit better w

[Lldb-commits] [PATCH] D95601: [lldb][AArch64] Add memory tag reading to lldb-server

DavidSpickett added inline comments. Comment at: lldb/test/API/tools/lldb-server/memory-tagging/main.c:36 + // This intrinsic treats the addresses as if they were untagged + while (__arm_mte_ptrdiff(tagged_ptr, buf) < page_size) { +// This sets the allocation tag --

[Lldb-commits] [PATCH] D97285: [lldb][AArch64] Add "memory tag read" command

DavidSpickett added inline comments. Comment at: lldb/test/API/linux/aarch64/mte_tag_read/main.c:46 + // A different tag so that buf_alt_tag > buf if you don't handle the tag + char *buf_alt_tag = __arm_mte_create_random_tag(buf, ~(1 << 10)); + https://develope

[Lldb-commits] [PATCH] D97285: [lldb][AArch64] Add "memory tag read" command

DavidSpickett updated this revision to Diff 325775. DavidSpickett added a comment. - Add some comments to explain the intrinsics used. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97285/new/ https://reviews.llvm.org/D97285 Files: lldb/source/Co

[Lldb-commits] [PATCH] D97287: [lldb][NFC] Rename the second ValueObjectManager to ValueObjectUpdater and remove the dead code

teemperor created this revision. teemperor added a reviewer: LLDB. teemperor added a project: LLDB. Herald added subscribers: JDevlieghere, mgorny. teemperor requested review of this revision. `ValueObject.h` contains the `ValueObject::ValueObjectManager` type which is just a typedef for the Clus

[Lldb-commits] [PATCH] D97287: [lldb][NFC] Rename the second ValueObjectManager to ValueObjectUpdater and remove the dead code

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97287/new/ https://reviews.llvm.org/D97287 ___ lldb-commits mailing list lldb-commits@lists.l

[Lldb-commits] [PATCH] D97298: [lldb][NFC] Move trivial ValueObject getters/setters to the header

teemperor created this revision. teemperor added a reviewer: LLDB. teemperor added a project: LLDB. Herald added a subscriber: JDevlieghere. teemperor requested review of this revision. NFC refactoring that moves the definitions of all the trivial getters/setters to the header file which is what

[Lldb-commits] [PATCH] D97165: [lldb] Add deref support and tests to shared_ptr synthetic

kastiglione updated this revision to Diff 325808. kastiglione added a comment. check ptr_sp before use Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97165/new/ https://reviews.llvm.org/D97165 Files: lldb/source/Plugins/Language/CPlusPlus/LibCxx.

[Lldb-commits] [lldb] 0ac42fd - [lldb] Add deref support and tests to shared_ptr synthetic

Author: Dave Lee Date: 2021-02-23T09:03:46-08:00 New Revision: 0ac42fd26d738b2d7b2811fc995bd7cacf994144 URL: https://github.com/llvm/llvm-project/commit/0ac42fd26d738b2d7b2811fc995bd7cacf994144 DIFF: https://github.com/llvm/llvm-project/commit/0ac42fd26d738b2d7b2811fc995bd7cacf994144.diff LOG:

[Lldb-commits] [PATCH] D97165: [lldb] Add deref support and tests to shared_ptr synthetic

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0ac42fd26d73: [lldb] Add deref support and tests to shared_ptr synthetic (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES S

[Lldb-commits] [PATCH] D97249: [lldb] Support debugging utility functions

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. This will be really handy! The code for UserExpressions ends up doing this same thing (over in ClangExpressionParser::ParseInternal. But given how light-weight creating the file is I'm pre

[Lldb-commits] [PATCH] D97307: [lldb][NFC] Extract ValueObject's expression path parsing into own class

teemperor created this revision. teemperor added a reviewer: LLDB. teemperor added a project: LLDB. Herald added subscribers: JDevlieghere, mgorny. teemperor requested review of this revision. A large chunk of the `ValueObject` implementation is the hand-written expression path parser and nearly

[Lldb-commits] [PATCH] D97249: [lldb] Support debugging utility functions

shafik added inline comments. Comment at: lldb/source/Expression/FunctionCaller.cpp:324 EvaluateExpressionOptions real_options = options; real_options.SetDebug(false); + real_options.SetGenerateDebugInfo(debug); It feels a little weird you are using the na

[Lldb-commits] [PATCH] D97249: [lldb] Support debugging utility functions

JDevlieghere marked 2 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/source/Expression/FunctionCaller.cpp:324 EvaluateExpressionOptions real_options = options; real_options.SetDebug(false); + real_options.SetGenerateDebugInfo(debug);

[Lldb-commits] [PATCH] D97249: [lldb] Support debugging utility functions

teemperor added inline comments. Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionSourceCode.cpp:38 const char *ClangExpressionSourceCode::g_expression_prefix = -"#line 1 \"" PREFIX_NAME R"(" +"#line 1 \"" PREFIX_NAME R"("#line 1 #ifndef offsetof -

[Lldb-commits] [PATCH] D97249: [lldb] Support debugging utility functions

JDevlieghere updated this revision to Diff 325837. JDevlieghere marked 6 inline comments as done. JDevlieghere added a comment. Address code review feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97249/new/ https://reviews.llvm.org/D97249 Files: lldb/include/lldb/Expression/Ut

[Lldb-commits] [PATCH] D97298: [lldb][NFC] Move trivial ValueObject getters/setters to the header

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97298/new/ https://reviews.llvm.org/D97298 ___ lldb-commits mailing list ll

[Lldb-commits] [PATCH] D97287: [lldb][NFC] Rename the second ValueObjectManager to ValueObjectUpdater and remove the dead code

JDevlieghere accepted this revision. JDevlieghere added a comment. Nice CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97287/new/ https://reviews.llvm.org/D97287 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/

[Lldb-commits] [PATCH] D97230: [lldb] [test] Workaround symlink-related test failures

mgorny updated this revision to Diff 325870. mgorny retitled this revision from "[lldb] [test] Workaround symlink-related create_after_attach test failure" to "[lldb] [test] Workaround symlink-related test failures". mgorny edited the summary of this revision. mgorny added a comment. Added a sim

[Lldb-commits] [PATCH] D96194: Defer the decision whether to use the CU or TU index until after reading the unit header.

jgorbe updated this revision to Diff 325884. jgorbe added a comment. Changed logic that checked the type of unit to use `header.IsTypeUnit()` as suggested by reviewer. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96194/new/ https://reviews.llvm.org/D96194 Files: lldb/source/Plugins

[Lldb-commits] [PATCH] D96194: Defer the decision whether to use the CU or TU index until after reading the unit header.

jgorbe added a comment. I'm going to go ahead and commit this given that I have just made the last suggested modification and the patch has already been up for review without further comments for a long while (sorry for the late replies, work keeps getting in the way of work). ==

[Lldb-commits] [lldb] 979ca1c - Defer the decision whether to use the CU or TU index until after reading the unit header.

Author: Jorge Gorbe Moya Date: 2021-02-23T13:26:11-08:00 New Revision: 979ca1c05f83114483caec3e6d1b75daae86da79 URL: https://github.com/llvm/llvm-project/commit/979ca1c05f83114483caec3e6d1b75daae86da79 DIFF: https://github.com/llvm/llvm-project/commit/979ca1c05f83114483caec3e6d1b75daae86da79.di

[Lldb-commits] [PATCH] D96194: Defer the decision whether to use the CU or TU index until after reading the unit header.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG979ca1c05f83: Defer the decision whether to use the CU or TU index until after reading the… (authored by jgorbe). Repository: rG LLVM Github Monor