JDevlieghere marked 2 inline comments as done.
JDevlieghere added inline comments.
================
Comment at: lldb/source/Expression/FunctionCaller.cpp:324
EvaluateExpressionOptions real_options = options;
real_options.SetDebug(false);
+ real_options.SetGenerateDebugInfo(debug);
----------------
shafik wrote:
> It feels a little weird you are using the name `debug` but using it in the
> call to `SetDebug(...)` but are using it in the call to
> `SetGenerateDebugInfo(...)`
Do you have a suggestion? Change the variable to `debug_utility_function`?
================
Comment at:
lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionSourceCode.cpp:38
const char *ClangExpressionSourceCode::g_expression_prefix =
-"#line 1 \"" PREFIX_NAME R"("
+ "#line 1 \"" PREFIX_NAME R"("#line 1
#ifndef offsetof
----------------
shafik wrote:
> Why additional `#line 1`.
Good catch, this is a remnant of me playing around with the line directive, it
shouldn't have made it into the patch.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97249/new/
https://reviews.llvm.org/D97249
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
