DavidSpickett added inline comments.
================ Comment at: lldb/source/Plugins/Process/Utility/RegisterInfoPOSIX_arm64.cpp:276 + if (opt_regsets & eRegsetEnableMTE) + m_mte_regset_enabled = true; } ---------------- omjavaid wrote: > DavidSpickett wrote: > > (like earlier) would it be ok to remove the if? > > ``` > > m_mte_regset_enabled = opt_regsets & eRegsetEnableMTE; > > ``` > I think here as well if do write eveytime regardless of true/false we might > end up refreshing the whole data set contained in cache against a > RegisterInfoPOSIX_arm64 object. What do you think? I assume you mean the cpu cache not any lldb register cache, I don't see a need to care that much about it here. The reason to always assign is so that there's no implication that there's a 3rd state. Like "false and not enabled" "true and enabled" "false and enabled" (which makes no sense but types wise, it's possible). Granted it's a drop in the bucket vs the rest of the state we're handling here so I'll leave it up to you. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96460/new/ https://reviews.llvm.org/D96460 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
