[Lldb-commits] [PATCH] D82732: WIP: Use SB APIs in CommandObjects

teemperor added inline comments. Comment at: lldb/include/lldb/API/SBBreakpoint.h:142 + + lldb::BreakpointSP GetSP() const; + I assume this is WIP code and we already told you that, but we can't expose the internal `lldb_private::*` classes (or their `lldb::*SP

[Lldb-commits] [lldb] e9f9434 - [lldb] Skip TestIOHandlerResizeNoEditline on Windows

Author: Raphael Isemann Date: 2020-07-08T11:45:38+02:00 New Revision: e9f943429c895e4d6d29505fab2fad365fe2766e URL: https://github.com/llvm/llvm-project/commit/e9f943429c895e4d6d29505fab2fad365fe2766e DIFF: https://github.com/llvm/llvm-project/commit/e9f943429c895e4d6d29505fab2fad365fe2766e.dif

[Lldb-commits] [lldb] ebee165 - [lldb][NFC] Fix indentation in expect_expr

Author: Raphael Isemann Date: 2020-07-08T12:33:31+02:00 New Revision: ebee165184a8000b7f650f0946b25b6ea51859b8 URL: https://github.com/llvm/llvm-project/commit/ebee165184a8000b7f650f0946b25b6ea51859b8 DIFF: https://github.com/llvm/llvm-project/commit/ebee165184a8000b7f650f0946b25b6ea51859b8.dif

[Lldb-commits] [PATCH] D83327: [lldb/Core] Fix incomplete type variable dereferencing crash.

labath added a comment. Thanks for fixing this. Comment at: lldb/source/Core/ValueObject.cpp:690 - if (!valobj && synthetic_array_member) -valobj = GetSyntheticValue() - ->GetChildAtIndex(synthetic_index, synthetic_array_member) - .get();

[Lldb-commits] [PATCH] D81697: Add support for batch-testing to the LLDB testsuite.

labath added a comment. In D81697#2138024 , @bbli wrote: > F12311388: image.png > > Hi, so I think I got the fix working. Attached is a screenshot of the new > output, with title "Build Command Stdout Ouput". Should I

[Lldb-commits] [lldb] 695b33a - [lldb/API] Overwrite variables with SBLaunchInfo::SetEnvironment(append=true)

Author: Pavel Labath Date: 2020-07-08T13:35:31+02:00 New Revision: 695b33a56919af8873eecb47cb83fa17a271e99f URL: https://github.com/llvm/llvm-project/commit/695b33a56919af8873eecb47cb83fa17a271e99f DIFF: https://github.com/llvm/llvm-project/commit/695b33a56919af8873eecb47cb83fa17a271e99f.diff

[Lldb-commits] [PATCH] D83306: [lldb/API] Overwrite variables with SBLaunchInfo::SetEnvironment(append=true)

This revision was automatically updated to reflect the committed changes. Closed by commit rG695b33a56919: [lldb/API] Overwrite variables with SBLaunchInfo::SetEnvironment(append=true) (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[Lldb-commits] [lldb] 88c8247 - [lldb/Utility] Simplify Scalar float accessors

Author: Pavel Labath Date: 2020-07-08T13:57:32+02:00 New Revision: 88c82474d2ef92d0cda7d902206d90a73eed9c9d URL: https://github.com/llvm/llvm-project/commit/88c82474d2ef92d0cda7d902206d90a73eed9c9d DIFF: https://github.com/llvm/llvm-project/commit/88c82474d2ef92d0cda7d902206d90a73eed9c9d.diff

[Lldb-commits] [lldb] 9c31da8 - [lldb/Core] Update comment to make it more explicit (NFC)

Author: Med Ismail Bennani Date: 2020-07-08T14:03:59+02:00 New Revision: 9c31da853855eb952bbad98b99978df8c515e9b2 URL: https://github.com/llvm/llvm-project/commit/9c31da853855eb952bbad98b99978df8c515e9b2 DIFF: https://github.com/llvm/llvm-project/commit/9c31da853855eb952bbad98b99978df8c515e9b2.

[Lldb-commits] [PATCH] D83008: Fix ItaniumRecordLayoutBuilder so that is grabs the correct bases class offsets from the external source

shafik added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:2197 // least as many of them as possible). return RD->isTrivial() && RD->isCXX11StandardLayout(); } teemperor wrote: > See here for the POD check that we might get wrong

[Lldb-commits] [PATCH] D83008: Fix ItaniumRecordLayoutBuilder so that is grabs the correct bases class offsets from the external source

shafik updated this revision to Diff 276407. shafik added a comment. Moved from shell test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83008/new/ https://reviews.llvm.org/D83008 Files: clang/lib/AST/RecordLayoutBuilder.cpp lldb/test/API/lang/cpp/alignas_base_class/Makefile lldb

[Lldb-commits] [PATCH] D83008: Fix ItaniumRecordLayoutBuilder so that is grabs the correct bases class offsets from the external source

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks for the patch! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83008/new/ https://reviews.llvm.org/D83008 ___ lldb-comm

[Lldb-commits] [PATCH] D77043: Fix process gdb-remote usage of value_regs/invalidate_regs

labath added a comment. The idea seems ok (though could use a test), but I am wondering if it wouldn't be better to do this conversion during (or immediately after) parsing. If I remember the previous discussions correctly, we've established that the value/invalidate_regs fields in the Register

[Lldb-commits] [lldb] 7fd2969 - [lldb] Modernize/clean up ValueObject::GetChildMemberWithName

Author: Pavel Labath Date: 2020-07-08T17:42:47+02:00 New Revision: 7fd29699d6042af674c4f4ad185c91f82cb73b52 URL: https://github.com/llvm/llvm-project/commit/7fd29699d6042af674c4f4ad185c91f82cb73b52 DIFF: https://github.com/llvm/llvm-project/commit/7fd29699d6042af674c4f4ad185c91f82cb73b52.diff

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

gedatsu217 updated this revision to Diff 276468. gedatsu217 added a comment. I fixed the code according to your advice. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81001/new/ https://reviews.llvm.org/D81001 Files: lldb/include/lldb/Core/Debugger.h lldb/include/lldb/Core/IOHandler

[Lldb-commits] [lldb] 63b0f8c - [RecordLayout] Fix ItaniumRecordLayoutBuilder so that is grabs the correct bases class offsets from the external source

Author: shafik Date: 2020-07-08T10:07:15-07:00 New Revision: 63b0f8c788d8c6978feb099fd6db8fe219c4d166 URL: https://github.com/llvm/llvm-project/commit/63b0f8c788d8c6978feb099fd6db8fe219c4d166 DIFF: https://github.com/llvm/llvm-project/commit/63b0f8c788d8c6978feb099fd6db8fe219c4d166.diff LOG: [

[Lldb-commits] [PATCH] D83008: Fix ItaniumRecordLayoutBuilder so that is grabs the correct bases class offsets from the external source

This revision was automatically updated to reflect the committed changes. Closed by commit rG63b0f8c788d8: [RecordLayout] Fix ItaniumRecordLayoutBuilder so that is grabs the correct… (authored by shafik). Herald added projects: clang, LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[Lldb-commits] [PATCH] D82477: [lldb-vscode] Add Support for Module Event

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82477/new/ https://reviews.llvm.org/D82477

[Lldb-commits] [PATCH] D83072: [lldb-vscode] Add Compile Unit List to Modules View

aelitashen updated this revision to Diff 276515. aelitashen added a comment. Recover Messy Diff History Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83072/new/ https://reviews.llvm.org/D83072 Files: lldb/packages/Python/lldbsuite/test/tools/lld

[Lldb-commits] [lldb] 27d52cd - Revert "[lldb/API] Overwrite variables with SBLaunchInfo::SetEnvironment(append=true)"

Author: Davide Italiano Date: 2020-07-08T13:09:24-07:00 New Revision: 27d52cd86a2cf82214b71519dffd450c54cf87ae URL: https://github.com/llvm/llvm-project/commit/27d52cd86a2cf82214b71519dffd450c54cf87ae DIFF: https://github.com/llvm/llvm-project/commit/27d52cd86a2cf82214b71519dffd450c54cf87ae.dif

[Lldb-commits] [PATCH] D83306: [lldb/API] Overwrite variables with SBLaunchInfo::SetEnvironment(append=true)

davide added a comment. This broke macOS: http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/22425/ I reverted it in: commit 27d52cd86a2cf82214b71519dffd450c54cf87ae (HEAD -> master, origin/master, origin/HEAD) Author: Davide Italiano Date: Wed Jul 8 13:00:29 2020 -0700 Re

[Lldb-commits] [PATCH] D83425: [lldb] add printing of stdout compile errors to lldbsuite

bbli created this revision. bbli added a reviewer: labath. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch will add printing of the output of stdout during compile errors, right below output of stderr. Repository: rG LLVM Github Monorepo https://reviews.llvm

[Lldb-commits] [PATCH] D83072: [lldb-vscode] Add Compile Unit List to Modules View

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Just use the SBFileSpec::GetPath(...) and document the compile unit request, args and response, and this will be ready. Comment at: lldb/tools/lldb-vscode/JSON

[Lldb-commits] [PATCH] D83433: Fix how we handle bit-fields for Objective-C when creating an AST

shafik created this revision. shafik added reviewers: teemperor, jingham, aprantl. Currently expressions dealing with bit-fields in Objective-C objects is pretty broken. When generating debug-info for Objective-C bit-fields we don't generate offsets because the Objective-C runtime is supposed to

[Lldb-commits] [PATCH] D83433: Fix how we handle bit-fields for Objective-C when creating an AST

aprantl added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:2612 -if ((this_field_info.bit_offset >= parent_bit_size) || -(last_field_info.IsBitfield() && - !last_field_info.NextBitfieldOffs

[Lldb-commits] [lldb] 3728133 - Unify the ExecutionContextScope computation in Materializer.

Author: Adrian Prantl Date: 2020-07-08T15:18:21-07:00 New Revision: 3728133d3f124c4c6972b118b0265de48ba89db1 URL: https://github.com/llvm/llvm-project/commit/3728133d3f124c4c6972b118b0265de48ba89db1 DIFF: https://github.com/llvm/llvm-project/commit/3728133d3f124c4c6972b118b0265de48ba89db1.diff

[Lldb-commits] [lldb] 9726dc4 - Updated the list of supported platforms in LLDB to include Apple silicon.

Author: Adrian Prantl Date: 2020-07-08T15:33:00-07:00 New Revision: 9726dc4d072376f71c40024804e3bf1193ba5dd8 URL: https://github.com/llvm/llvm-project/commit/9726dc4d072376f71c40024804e3bf1193ba5dd8 DIFF: https://github.com/llvm/llvm-project/commit/9726dc4d072376f71c40024804e3bf1193ba5dd8.diff

[Lldb-commits] [PATCH] D83359: [Function] Lock the function when parsing call site info

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Looks plausible. Comment at: lldb/include/lldb/Symbol/Function.h:661 + std::mutex + m_call_edges_lock; ///< Exclusive lock that controls read/write +

[Lldb-commits] [PATCH] D83425: [lldb] add printing of stdout compile errors to lldbsuite

bbli updated this revision to Diff 276590. bbli added a comment. Changed back to original function signature, as this method gets called once outside the class. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83425/new/ https://reviews.llvm.org/D834

[Lldb-commits] [PATCH] D83441: [ldb/Reproducers] Add YamlRecorder and MultiProvider

JDevlieghere created this revision. JDevlieghere added reviewers: labath, teemperor. This patch does several things that are all closely related: - It introduces a new `YamlRecorder` as a counterpart to the existing `DataRecorder`. As the name suggests the former serializes data as yaml while t

[Lldb-commits] [PATCH] D83072: [lldb-vscode] Add Compile Unit List to Modules View

aelitashen updated this revision to Diff 276596. aelitashen added a comment. Fix Path and Add Documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83072/new/ https://reviews.llvm.org/D83072 Files: lldb/packages/Python/lldbsuite/test/tools

[Lldb-commits] [PATCH] D83441: [ldb/Reproducers] Add YamlRecorder and MultiProvider

JDevlieghere updated this revision to Diff 276597. JDevlieghere added a comment. Use `ScopeExit` to cleanup reproducer after test completes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83441/new/ https://reviews.llvm.org/D83441 Files: lldb/include/lldb/Utility/Reproducer.h lldb/s

[Lldb-commits] [PATCH] D83443: Fix debugserver reporting of deployment target

aprantl created this revision. aprantl added reviewers: jasonmolenda, friss. This patch fixes debugserver incorrectly returning the SDK version instead of the minimum deployment target version. rdar://problem/65001691 https://reviews.llvm.org/D83443 Files: lldb/test/API/macosx/simulator/Tes

[Lldb-commits] [PATCH] D83443: Fix debugserver reporting of deployment target

aprantl updated this revision to Diff 276605. aprantl added a comment. delete a redundant statement CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83443/new/ https://reviews.llvm.org/D83443 Files: lldb/test/API/macosx/simulator/TestSimulatorPlatform.py lldb/tools/debugserver/source/

[Lldb-commits] [PATCH] D83443: Fix debugserver reporting of deployment target

friss accepted this revision. friss added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/test/API/macosx/simulator/TestSimulatorPlatform.py:30 +dylib_info = None +reponse = False +response = False typo?

[Lldb-commits] [PATCH] D83443: Fix debugserver reporting of deployment target

aprantl marked 2 inline comments as done. aprantl added inline comments. Comment at: lldb/test/API/macosx/simulator/TestSimulatorPlatform.py:47 +if image['pathname'].endswith('a.out'): +aout_info = image +self.assertTrue(aout_info)

[Lldb-commits] [lldb] 15149e4 - Fix debugserver reporting of deployment target

Author: Adrian Prantl Date: 2020-07-08T17:21:43-07:00 New Revision: 15149e406486092a3665791545ab9474471c0f14 URL: https://github.com/llvm/llvm-project/commit/15149e406486092a3665791545ab9474471c0f14 DIFF: https://github.com/llvm/llvm-project/commit/15149e406486092a3665791545ab9474471c0f14.diff

[Lldb-commits] [PATCH] D83443: Fix debugserver reporting of deployment target

This revision was automatically updated to reflect the committed changes. Closed by commit rG15149e406486: Fix debugserver reporting of deployment target (authored by aprantl). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D83443?vs=276605&id=276608#toc Reposi

[Lldb-commits] [PATCH] D81697: Add support for batch-testing to the LLDB testsuite.

bbli added a comment. Hi Pavel, so I submitted the new patch(which I added you as a reviewer of) but it looks like the remote build failed. I ran `ninja check-lldb` locally and it works fine. How would I go about debugging this? I tried clicking on the links to the failed build, but couldn't re

[Lldb-commits] [PATCH] D83446: [WIP][lldb/Reproducers] Synchronize the command interpreter with asynchronous events

JDevlieghere created this revision. JDevlieghere added reviewers: labath, friss. Herald added a subscriber: abidh. Add synchronization for asynchronous events. This fixes an un expected packet during replay when an asynchronous event triggers a GDB packet. Consider the following example: $ ./

[Lldb-commits] [PATCH] D83450: Delegate UpdateChildrenPointerType to the Root ValueObject

jingham created this revision. jingham added a reviewer: labath. Herald added subscribers: lldb-commits, JDevlieghere. Herald added a project: LLDB. This is a refinement on 96601ec28b7efe5abf3479a1aa91bcedb235bbbd. The intent of that change was to do the same work for the computation of the loca

[Lldb-commits] [PATCH] D83454: [CMake] Make `intrinsics_gen` dependency unconditional.

michele.scandale created this revision. michele.scandale added reviewers: chandlerc, beanz, zturner. Herald added subscribers: lldb-commits, cfe-commits, MaskRay, aheejin, arichardson, sbc100, mgorny, emaste. Herald added a reviewer: espindola. Herald added a reviewer: MaskRay. Herald added projec