clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Just use the SBFileSpec::GetPath(...) and document the compile unit request,
args and response, and this will be ready.
================
Comment at: lldb/tools/lldb-vscode/JSONUtils.cpp:942-943
+ llvm::json::Object object;
+ std::string path = std::string(unit.GetFileSpec().GetDirectory()) + "/" +
+ std::string(unit.GetFileSpec().GetFilename());
+ object.try_emplace("compileUnitPath", path);
----------------
Let LLDB handle the '/' like we did using SBFileSpec::GetPath(...) here.
================
Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:1177
+void request_getCompileUnits(const llvm::json::Object &request) {
+ llvm::json::Object response;
----------------
We need to document the packet format like ""InitializeRequest" on lines
1202-1277.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83072/new/
https://reviews.llvm.org/D83072
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
