teemperor added inline comments.
================ Comment at: lldb/include/lldb/API/SBBreakpoint.h:142 + + lldb::BreakpointSP GetSP() const; + ---------------- I assume this is WIP code and we already told you that, but we can't expose the internal `lldb_private::*` classes (or their `lldb::*SP` typedef). So this needs to be replaced with SB API patches. ================ Comment at: lldb/include/lldb/API/SBTarget.h:69 + bool IsProcessValid() const; + ---------------- This should rather be a `IsAlive` function in SBProcess. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82732/new/ https://reviews.llvm.org/D82732 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
