[Lldb-commits] [PATCH] D70886: [lldb-vscode] capture the debuggers file handles before lldbinit runs

labath added a comment. In D70886#1767654 , @aadsm wrote: > > Maybe you could do something similar to LocalLLDBInit.test ? > > That test uses the `lldb` `-S` (and others) flags that `lldb-vscode` doesn't > support :(. These flags should really be added to

[Lldb-commits] [PATCH] D70883: [vscode.py] Make read_packet only return None when EOF

labath added a comment. This patch seems really weird to me... We may be able to work around random lldb output in the test this way, but that won't help any other DAP client who ends up talking to lldb-vscode (or do they have similar workarounds already?). In fact it might make things worse --

[Lldb-commits] [lldb] c4c464f - [lldb][NFC] Migrate to raw_ostream in Module::GetDescription

Author: Raphael Isemann Date: 2019-12-04T09:35:50+01:00 New Revision: c4c464f8a5025ad59733723e1ba1900837760078 URL: https://github.com/llvm/llvm-project/commit/c4c464f8a5025ad59733723e1ba1900837760078 DIFF: https://github.com/llvm/llvm-project/commit/c4c464f8a5025ad59733723e1ba1900837760078.dif

[Lldb-commits] [lldb] 4d37f18 - [lldb][NFC] Extract single member parsing out of DWARFASTParserClang::ParseChildMembers

Author: Raphael Isemann Date: 2019-12-04T10:05:40+01:00 New Revision: 4d37f18b29cc3fd1abd336ec10baca17694d035f URL: https://github.com/llvm/llvm-project/commit/4d37f18b29cc3fd1abd336ec10baca17694d035f DIFF: https://github.com/llvm/llvm-project/commit/4d37f18b29cc3fd1abd336ec10baca17694d035f.dif

[Lldb-commits] [lldb] 817d618 - [lldb/Editline] Fix a -Wreturn-type warning with gcc

Author: Pavel Labath Date: 2019-12-04T10:44:12+01:00 New Revision: 817d6184e75db5eefca907a296e8379d8f570e7e URL: https://github.com/llvm/llvm-project/commit/817d6184e75db5eefca907a296e8379d8f570e7e DIFF: https://github.com/llvm/llvm-project/commit/817d6184e75db5eefca907a296e8379d8f570e7e.diff

[Lldb-commits] [lldb] 532290e - [lldb] s/FileSpec::Equal/FileSpec::Match

Author: Pavel Labath Date: 2019-12-04T10:42:32+01:00 New Revision: 532290e69fcb0e1f2005853241bc2cac6941e0f7 URL: https://github.com/llvm/llvm-project/commit/532290e69fcb0e1f2005853241bc2cac6941e0f7 DIFF: https://github.com/llvm/llvm-project/commit/532290e69fcb0e1f2005853241bc2cac6941e0f7.diff

[Lldb-commits] [PATCH] D70851: [lldb] s/FileSpec::Equal/FileSpec::Match

This revision was automatically updated to reflect the committed changes. labath marked 2 inline comments as done. Closed by commit rG532290e69fcb: [lldb] s/FileSpec::Equal/FileSpec::Match (authored by labath). Changed prior to commit: https://reviews.llvm.org/D70851?vs=231522&id=232057#toc Re

[Lldb-commits] [lldb] 28e4942 - [lldb] Remove FileSpec(FileSpec*) constructor

Author: Pavel Labath Date: 2019-12-04T10:49:25+01:00 New Revision: 28e4942b2c3b8961b91b362b4b76b9ca0f735cc2 URL: https://github.com/llvm/llvm-project/commit/28e4942b2c3b8961b91b362b4b76b9ca0f735cc2 DIFF: https://github.com/llvm/llvm-project/commit/28e4942b2c3b8961b91b362b4b76b9ca0f735cc2.diff

[Lldb-commits] [lldb] 1351672 - [lldb] s/assertTrue/assertEqual in TestStepTarget.py

Author: Pavel Labath Date: 2019-12-04T10:56:38+01:00 New Revision: 1351672eedbf9716def4fc789d9046c481c7cd25 URL: https://github.com/llvm/llvm-project/commit/1351672eedbf9716def4fc789d9046c481c7cd25 DIFF: https://github.com/llvm/llvm-project/commit/1351672eedbf9716def4fc789d9046c481c7cd25.diff

[Lldb-commits] [lldb] 150c8dd - [lldb] Remove some (almost) unused Stream::operator<<'s

Author: Pavel Labath Date: 2019-12-04T11:07:46+01:00 New Revision: 150c8dd13be4a9d9a9f631a507871359117871ca URL: https://github.com/llvm/llvm-project/commit/150c8dd13be4a9d9a9f631a507871359117871ca DIFF: https://github.com/llvm/llvm-project/commit/150c8dd13be4a9d9a9f631a507871359117871ca.diff

[Lldb-commits] [PATCH] D70155: [LLDB] Avoid triple corruption while merging core info from platform and target triples

omjavaid added a comment. Ping @jasonmolenda Any comments or LGTM? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70155/new/ https://reviews.llvm.org/D70155 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cg

[Lldb-commits] [PATCH] D68209: [LiveDebugValues] Introduce entry values of unmodified params

djtodoro marked an inline comment as done. djtodoro added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/functionalities/param_entry_vals/basic_entry_values_x86_64/main.cpp:159 // FUNC11-BT: func11_tailcalled{{.*}} // FUNC11-BT-NEXT: func12{{.*}} [artific

[Lldb-commits] [PATCH] D71003: [lldb/DWARF] Switch to llvm location list parser

labath created this revision. labath added reviewers: JDevlieghere, aprantl, clayborg. Herald added a project: LLDB. labath added a parent revision: D70532: [lldb] Improve/fix base address selection in location lists. This patch deletes the lldb location list parser and teaches the DWARFExpressio

[Lldb-commits] [PATCH] D71003: [lldb/DWARF] Switch to llvm location list parser

dblaikie added inline comments. Comment at: lldb/source/Expression/DWARFExpression.cpp:72 + } + llvm_unreachable("Fully covered switch!"); +} I think usually the unreachable comment that's used in this sort of case is "Invalid LocationListFormat!" or similar,

[Lldb-commits] [PATCH] D70848: [LLDB] Set the right address size on output DataExtractors from ObjectFile

labath added a comment. I just realized I didn't press "sumbit" yesterday... Comment at: lldb/source/Symbol/ObjectFile.cpp:480-486 + size_t ret = data.SetData(m_data, offset, length); + // DataExtractor::SetData copies the address byte size from m_data, but + // m_data's add

[Lldb-commits] [lldb] 5e71356 - [lldb] Fix macOS build by replacing nullptr with FileSpec()

Author: Raphael Isemann Date: 2019-12-04T14:37:10+01:00 New Revision: 5e713563934eadb48b4830ad019bdb91f1d89150 URL: https://github.com/llvm/llvm-project/commit/5e713563934eadb48b4830ad019bdb91f1d89150 DIFF: https://github.com/llvm/llvm-project/commit/5e713563934eadb48b4830ad019bdb91f1d89150.dif

[Lldb-commits] [PATCH] D70848: [LLDB] Set the right address size on output DataExtractors from ObjectFile

labath added a comment. BTW, I don't know if you've noticed, but the new test is failing on windows: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/11217. It looks like a path separator problem. We actually already have code which tries to guess the path style of a compile unit

[Lldb-commits] [PATCH] D71003: [lldb/DWARF] Switch to llvm location list parser

labath marked an inline comment as done. labath added inline comments. Comment at: lldb/source/Expression/DWARFExpression.cpp:2829 +if (!loc) + LLDB_LOG_ERROR(log, loc.takeError(), "{0}"); +if (loc->Range) { dblaikie wrote: > Does LLDB_LOG_ERROR stop

[Lldb-commits] [PATCH] D71003: [lldb/DWARF] Switch to llvm location list parser

labath updated this revision to Diff 232106. labath marked 4 inline comments as done. labath added a comment. Feedback @dblaikie. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71003/new/ https://reviews.llvm.org/D71003 Files: lldb/include/lldb/E

[Lldb-commits] [PATCH] D71003: [lldb/DWARF] Switch to llvm location list parser

labath added inline comments. Comment at: lldb/source/Expression/DWARFExpression.cpp:2829 +if (!loc) + LLDB_LOG_ERROR(log, loc.takeError(), "{0}"); +if (loc->Range) { labath wrote: > dblaikie wrote: > > Does LLDB_LOG_ERROR stop the program? If not, t

[Lldb-commits] [lldb] 95b2e51 - Change Target::FindBreakpointsByName to return Expected

Author: Joseph Tremoulet Date: 2019-12-04T09:57:15-05:00 New Revision: 95b2e516bd3e4587953e44bf062054ff84f2b057 URL: https://github.com/llvm/llvm-project/commit/95b2e516bd3e4587953e44bf062054ff84f2b057 DIFF: https://github.com/llvm/llvm-project/commit/95b2e516bd3e4587953e44bf062054ff84f2b057.di

[Lldb-commits] [PATCH] D70907: Change Target::FindBreakpointsByName to return Expected

This revision was automatically updated to reflect the committed changes. JosephTremoulet marked an inline comment as done. Closed by commit rG95b2e516bd3e: Change Target::FindBreakpointsByName to return Expected (authored by JosephTremoulet). Repository: rG LLVM Github Monorepo CHANGE

[Lldb-commits] [lldb] 92cd68f - [lldb] Simplify debug_{rnglists, ranges}.s tests

Author: Pavel Labath Date: 2019-12-04T17:08:23+01:00 New Revision: 92cd68f48ed14c6ee90b3ad830af3c2d7879428a URL: https://github.com/llvm/llvm-project/commit/92cd68f48ed14c6ee90b3ad830af3c2d7879428a DIFF: https://github.com/llvm/llvm-project/commit/92cd68f48ed14c6ee90b3ad830af3c2d7879428a.diff

[Lldb-commits] [PATCH] D71021: [lldb/DWARF] Switch to llvm debug_rnglists parser

labath created this revision. labath added reviewers: JDevlieghere, aprantl, clayborg. Herald added a project: LLDB. Our rnglist support was working only for the trivial cases (one CU), because we only ever parsed one contribution out of the debug_rnglists section. This means we were never able to

[Lldb-commits] [PATCH] D70721: [lldb/cpluspluslanguage] Add constructor substitutor

labath added a comment. Thanks for taking a look at this. Comment at: lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp:327 + bool trySubstitute(llvm::StringRef From, llvm::StringRef To) { +if (!llvm::StringRef(this->First, this->numLeft()).startswith(From)) -

[Lldb-commits] [PATCH] D70721: [lldb/cpluspluslanguage] Add constructor substitutor

labath updated this revision to Diff 232148. labath marked 3 inline comments as done. labath added a comment. Remove unused return value Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70721/new/ https://reviews.llvm.org/D70721 Files: lldb/source/

[Lldb-commits] [PATCH] D71022: [lldb] NFC: less nesting in SearchFilter.cpp

kwk created this revision. Herald added a reviewer: jdoerfert. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. kwk edited the summary of this revision. I was working on SearchFilter.cpp and felt it a bit too complex in some cases in terms of nesting and logic flow. Reposi

[Lldb-commits] [PATCH] D71003: [lldb/DWARF] Switch to llvm location list parser

dblaikie added inline comments. Comment at: lldb/source/Expression/DWARFExpression.cpp:2829 +if (!loc) + LLDB_LOG_ERROR(log, loc.takeError(), "{0}"); +if (loc->Range) { labath wrote: > labath wrote: > > dblaikie wrote: > > > Does LLDB_LOG_ERROR stop

[Lldb-commits] [PATCH] D71003: [lldb/DWARF] Switch to llvm location list parser

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Expression/DWARFExpression.h:260 - bool GetLocation(lldb::addr_t func_load_addr, lldb::addr_t pc, - lldb::offset_t &offset, lldb::offset_t &len); + void RelocateLowHighPC(lldb::addr_t load_fun

[Lldb-commits] [PATCH] D70721: [lldb/cpluspluslanguage] Add constructor substitutor

shafik accepted this revision. shafik added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp:352 + void appendUnchangedInput() { +Result += llvm::StringRef(Written, this->First - Writte

[Lldb-commits] [PATCH] D71021: [lldb/DWARF] Switch to llvm debug_rnglists parser

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Nice! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71021/new/ https://reviews.llvm.org/D71021 __

[Lldb-commits] [PATCH] D70992: Replacing to use of ul suffix in GetMaxU64Bitfield since it not guarenteed to be 64 bit

teemperor accepted this revision. teemperor added a comment. LGTM minus a small nitpick. Thanks! Comment at: lldb/source/Utility/DataExtractor.cpp:595 + (bitfield_bit_size == 64 + ? -static_cast(1) + : ((static_cast(1) << bitfield_bit_size) - 1)); -

[Lldb-commits] [PATCH] D71022: [lldb] NFC: less nesting in SearchFilter.cpp

JDevlieghere accepted this revision. JDevlieghere added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Core/SearchFilter.cpp:625 modules_array); FileSpecList modules; + if (!success)

[Lldb-commits] [PATCH] D70848: [LLDB] Set the right address size on output DataExtractors from ObjectFile

mstorsjo marked an inline comment as done. mstorsjo added a comment. In D70848#1768730 , @labath wrote: > BTW, I don't know if you've noticed, but the new test is failing on windows: > http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/11217.

[Lldb-commits] [PATCH] D71022: [lldb] NFC: less nesting in SearchFilter.cpp

teemperor accepted this revision. teemperor added a comment. I have one minor request (see inline comments), but otherwise LGTM, thanks! Comment at: lldb/source/Core/SearchFilter.cpp:777 lldb::ModuleSP module_sp = target_images.GetModuleAtIndexUnlocked(i); -if (no_modu

[Lldb-commits] [PATCH] D70155: [LLDB] Avoid triple corruption while merging core info from platform and target triples

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Thanks for the ping, yes this looks good to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70155/new/ https://reviews.llvm.org/D70155 ___

[Lldb-commits] [PATCH] D70848: [LLDB] Set the right address size on output DataExtractors from ObjectFile

mstorsjo marked an inline comment as done. mstorsjo added inline comments. Comment at: lldb/source/Symbol/ObjectFile.cpp:480-486 + size_t ret = data.SetData(m_data, offset, length); + // DataExtractor::SetData copies the address byte size from m_data, but + // m_data's address

[Lldb-commits] [PATCH] D70846: Expression eval lookup speedup by not returning methods in ManualDWARFIndex::GetFunctions

shafik added a comment. In D70846#1767455 , @labath wrote: > I guess you were building darwin binaries, right? If that's the case, then > you weren't using this code at all, as apple uses AppleIndex by default. The > test in question uses all three index

[Lldb-commits] [PATCH] D69589: [lldb] Refactor all POST_BUILD commands into targets

sgraenitz added a comment. I'd recommend to be careful when making a change of this size. There are a lot of possible configurations. If you split it up into a few smaller and more dedicated commits, you will make your life easier. Otherwise someone might just revert everything if this happens

[Lldb-commits] [PATCH] D70644: [DebugInfo] Support for DW_OP_implicit_pointer (llvm.dbg_derefval)

StephenTozer added inline comments. Comment at: llvm/docs/SourceLevelDebugging.rst:270 + +An `llvm.dbg.derefval` intrinsic is usefull when location which the variable +points to is optimized out, but the dereferenced value is known. Correct usefull -> useful Re

[Lldb-commits] [PATCH] D70764: build: reduce CMake handling for zlib

labath added a comment. `/usr/lib/x86_64-linux-gnu/libz.so` is definitely better than `-l/usr/lib/x86_64-linux-gnu/libz.so`, as it's at least a valid link line. It's not completely equivalent, and may not work in all cases -- last time I accidentally changed this, I got about a dozen emails fro

[Lldb-commits] [PATCH] D70764: build: reduce CMake handling for zlib

beanz added a comment. @labath sorry for not replying on-list. I've actually been discussing offline with @compnerd. If `llvm-config` is printing an absolute path, I'm concerned about how that will interact with binary package distributions for the llvm-dev packages. Not sure if @tstellar has a

[Lldb-commits] [PATCH] D70764: build: reduce CMake handling for zlib

JDevlieghere added a comment. In D70764#1767413 , @compnerd wrote: > In D70764#1767395 , @JDevlieghere > wrote: > > > Having one canonical variable controlling zlib support seems indeed > > desirable. > > > > In D

[Lldb-commits] [PATCH] D70992: Replacing to use of ul suffix in GetMaxU64Bitfield since it not guarenteed to be 64 bit

shafik updated this revision to Diff 232218. shafik marked 2 inline comments as done. shafik added a comment. Changing `-static_cast(1)` to `std::numeric_limits::max()` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70992/new/ https://reviews.llvm.org/D70992 Files: lldb/source/Utilit

[Lldb-commits] [PATCH] D70992: Replacing to use of ul suffix in GetMaxU64Bitfield since it not guarenteed to be 64 bit

shafik added inline comments. Comment at: lldb/source/Utility/DataExtractor.cpp:595 + (bitfield_bit_size == 64 + ? -static_cast(1) + : ((static_cast(1) << bitfield_bit_size) - 1)); teemperor wrote: > How about `std::numeric_limits::max()`

[Lldb-commits] [lldb] e11df58 - Upstream debugserver arm64e support.

Author: Jason Molenda Date: 2019-12-04T15:20:56-08:00 New Revision: e11df585800596df2052a475f6191673b8f1a5c1 URL: https://github.com/llvm/llvm-project/commit/e11df585800596df2052a475f6191673b8f1a5c1 DIFF: https://github.com/llvm/llvm-project/commit/e11df585800596df2052a475f6191673b8f1a5c1.diff

[Lldb-commits] [PATCH] D70277: [Signal] Allow llvm clients to opt into one-shot SIGPIPE handling

aganea added inline comments. Comment at: llvm/lib/Support/Unix/Signals.inc:369 - // Send a special return code that drivers can check for, from sysexits.h. if (Sig == SIGPIPE) +if (auto OldOneShotPipeFunction = @vsk Question question: `SIG

[Lldb-commits] [lldb] e001bf6 - Add help text for parray and poarray aliases.

Author: Jason Molenda Date: 2019-12-04T15:33:54-08:00 New Revision: e001bf6330bb0e935b17c8a619e71bbded67e2eb URL: https://github.com/llvm/llvm-project/commit/e001bf6330bb0e935b17c8a619e71bbded67e2eb DIFF: https://github.com/llvm/llvm-project/commit/e001bf6330bb0e935b17c8a619e71bbded67e2eb.diff

[Lldb-commits] [lldb] e1a7d04 - Add parray example for lldb, vrs. *ptr@count gdb cmd.

Author: Jason Molenda Date: 2019-12-04T15:44:15-08:00 New Revision: e1a7d042c36509a385668ee04ddb3dad3241f503 URL: https://github.com/llvm/llvm-project/commit/e1a7d042c36509a385668ee04ddb3dad3241f503 DIFF: https://github.com/llvm/llvm-project/commit/e1a7d042c36509a385668ee04ddb3dad3241f503.diff

[Lldb-commits] [PATCH] D71003: [lldb/DWARF] Switch to llvm location list parser

aprantl added a comment. Nice! Comment at: lldb/source/Expression/DWARFExpression.cpp:57 + +static std::unique_ptr +GetLocationTable(DWARFExpression::LocationListFormat format, const DataExtractor &data) { Doxygen comment? Comment at: lldb/s

[Lldb-commits] [lldb] acda2bc - [lldb/Reproducers] Propagate LLDB_CAPTURE_REPRODUCER to the test suite

Author: Jonas Devlieghere Date: 2019-12-04T16:49:11-08:00 New Revision: acda2bc0adf62d9e54bf6d284f91e6cfa5b3cc6e URL: https://github.com/llvm/llvm-project/commit/acda2bc0adf62d9e54bf6d284f91e6cfa5b3cc6e DIFF: https://github.com/llvm/llvm-project/commit/acda2bc0adf62d9e54bf6d284f91e6cfa5b3cc6e.d

[Lldb-commits] [lldb] dfe9a79 - [lldb/Reproducers] Override capture with LLDB_CAPTURE_REPRODUCER env var

Author: Jonas Devlieghere Date: 2019-12-04T16:49:11-08:00 New Revision: dfe9a7943bf7a926e51b319a2c2f73e4b4b4cf43 URL: https://github.com/llvm/llvm-project/commit/dfe9a7943bf7a926e51b319a2c2f73e4b4b4cf43 DIFF: https://github.com/llvm/llvm-project/commit/dfe9a7943bf7a926e51b319a2c2f73e4b4b4cf43.d

[Lldb-commits] [lldb] fe5ab6d - [lldb/Reproducers] Add missing instrumentation for SBFile

Author: Jonas Devlieghere Date: 2019-12-04T17:37:21-08:00 New Revision: fe5ab6d2cba1ddeb78567ac7c897cd30593ad366 URL: https://github.com/llvm/llvm-project/commit/fe5ab6d2cba1ddeb78567ac7c897cd30593ad366 DIFF: https://github.com/llvm/llvm-project/commit/fe5ab6d2cba1ddeb78567ac7c897cd30593ad366.d

[Lldb-commits] [lldb] 3151d7a - Clear out the python class name in OptionParsingStarted for the OptionGroupPythonClassWithDict

Author: Jim Ingham Date: 2019-12-04T17:40:57-08:00 New Revision: 3151d7af72bee375c06318195870942d4bc12002 URL: https://github.com/llvm/llvm-project/commit/3151d7af72bee375c06318195870942d4bc12002 DIFF: https://github.com/llvm/llvm-project/commit/3151d7af72bee375c06318195870942d4bc12002.diff LO

[Lldb-commits] [lldb] 6ee96dd - [lldb/Reproducers] Add missing instrumentation for SBFile (2/2)

Author: Jonas Devlieghere Date: 2019-12-04T18:20:20-08:00 New Revision: 6ee96ddec89774a534ec93de7266a0bf38de07e8 URL: https://github.com/llvm/llvm-project/commit/6ee96ddec89774a534ec93de7266a0bf38de07e8 DIFF: https://github.com/llvm/llvm-project/commit/6ee96ddec89774a534ec93de7266a0bf38de07e8.d

[Lldb-commits] [lldb] 039d4b3 - [lldb/Reproducers] Don't instrument SBFileSpec::GetPath

Author: Jonas Devlieghere Date: 2019-12-04T18:20:20-08:00 New Revision: 039d4b3aa20a8f36ad058f2b9692b73c6909c612 URL: https://github.com/llvm/llvm-project/commit/039d4b3aa20a8f36ad058f2b9692b73c6909c612 DIFF: https://github.com/llvm/llvm-project/commit/039d4b3aa20a8f36ad058f2b9692b73c6909c612.d

[Lldb-commits] [PATCH] D70277: [Signal] Allow llvm clients to opt into one-shot SIGPIPE handling

vsk marked an inline comment as done. vsk added inline comments. Comment at: llvm/lib/Support/Unix/Signals.inc:369 - // Send a special return code that drivers can check for, from sysexits.h. if (Sig == SIGPIPE) +if (auto OldOneShotPipeFunction = --

[Lldb-commits] [lldb] 5312139 - Add a default copy-assignment or copy-constructor for -Wdeprecated-copy warnings.

Author: Eric Christopher Date: 2019-12-04T20:35:32-08:00 New Revision: 5312139f779f9f18cc5fa1c4ce5e5c5c1e854e90 URL: https://github.com/llvm/llvm-project/commit/5312139f779f9f18cc5fa1c4ce5e5c5c1e854e90 DIFF: https://github.com/llvm/llvm-project/commit/5312139f779f9f18cc5fa1c4ce5e5c5c1e854e90.di

[Lldb-commits] [PATCH] D68209: [LiveDebugValues] Introduce entry values of unmodified params

vsk added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/functionalities/param_entry_vals/basic_entry_values_x86_64/main.cpp:159 // FUNC11-BT: func11_tailcalled{{.*}} // FUNC11-BT-NEXT: func12{{.*}} [artificial] use(x); djtodoro wrote:

[Lldb-commits] [PATCH] D70764: build: reduce CMake handling for zlib

beanz added a comment. I conferred off-list with @compnerd. He and I talked through my concerns, and I believe this patch is fine as-is, so LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70764/new/ https://reviews.llvm.org/D70764 _