JDevlieghere accepted this revision.
JDevlieghere added inline comments.
This revision is now accepted and ready to land.
================
Comment at: lldb/source/Core/SearchFilter.cpp:625
modules_array);
FileSpecList modules;
+ if (!success)
----------------
I'd move this down and use
```
if (!success)
return
std::make_shared<SearchFilterByModuleList>(target.shared_from_this(),{});
```
to make it clear the list of modules is empty.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71022/new/
https://reviews.llvm.org/D71022
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
