labath marked an inline comment as done.
labath added inline comments.
================
Comment at: lldb/source/Expression/DWARFExpression.cpp:2829
+ if (!loc)
+ LLDB_LOG_ERROR(log, loc.takeError(), "{0}");
+ if (loc->Range) {
----------------
dblaikie wrote:
> Does LLDB_LOG_ERROR stop the program? If not, then the next line ("if
> (loc->Range)" will invoke UB when it tries to dereference the "loc" when it
> is unset.
It doesn't. You're right, there should be a return here, just let me see if I
can tickle this into exploding.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71003/new/
https://reviews.llvm.org/D71003
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
