[Lldb-commits] [PATCH] D67776: Use UnixSignals::ShouldSuppress to filter out signals a process expects

labath added a comment. This is an interesting problem. As Jim suspects, breakpoint int3s come out as stop reason = breakpoint in lldb, and non-breakpoint int3 as SIGTRAP. So, in theory, it should be possible to change the SIGTRAP behavior so that it does not impact SIGTRAPs from lldb-generated

[Lldb-commits] [lldb] r372549 - [lldb] Fix that importing decls in a TagDecl end up in wrong declaration context (partly reverts D61333)

Author: teemperor Date: Mon Sep 23 00:27:14 2019 New Revision: 372549 URL: http://llvm.org/viewvc/llvm-project?rev=372549&view=rev Log: [lldb] Fix that importing decls in a TagDecl end up in wrong declaration context (partly reverts D61333) Summary: In D61333 we dropped some code from ClangASTSo

[Lldb-commits] [PATCH] D67803: [lldb] Fix that importing decls in a TagDecl end up in wrong declaration context (partly reverts D61333)

This revision was automatically updated to reflect the committed changes. Closed by commit rL372549: [lldb] Fix that importing decls in a TagDecl end up in wrong declaration… (authored by teemperor, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed pri

[Lldb-commits] [PATCH] D65942: Disallow implicit conversion from pointers to bool in llvm::toStringRef

labath added inline comments. Comment at: lldb/source/Symbol/TypeSystem.cpp:331 "TypeSystem for language " + - llvm::toStringRef(Language::GetNameForLanguageType(language)) + + llvm::StringRef(Language::GetNameForLanguageType(language)) +

[Lldb-commits] [PATCH] D67583: Fix swig python package path

labath added a comment. In D67583#1677141 , @hhb wrote: > In D67583#1676531 , @labath wrote: > > > Since I'm already complaining about python paths, I'll add that the way we > > currently compute the python path is

[Lldb-commits] [PATCH] D67789: bugfix: File::GetWaitableHandle() should call fileno()

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Thanks for adding the test. LGTM, modulo some nits inline. Comment at: lldb/unittests/Host/CMakeLists.txt:14 TaskPoolTest.cpp + FileTest.cpp ) Please ke

[Lldb-commits] [PATCH] D61240: Implement GetSystemIncludeDirectories for macOS

teemperor abandoned this revision. teemperor added a comment. Herald added a subscriber: JDevlieghere. This is no longer necessary as we abandon the "reimplement include directories" approach (we now look at the support files or require -gmodules which both provide the same information in a more

[Lldb-commits] [PATCH] D67583: Fix swig python package path

mgorny added a comment. In D67583#1678505 , @labath wrote: > This will work for the python-in-lldb case. However, the idea is lldb can > also be used as python package, from any python application (by just typing > `import lldb`). For that to work, we ne

[Lldb-commits] [lldb] r372556 - [lldb] Reduce some dangerous boilerplate with CompletionRequest::ShiftArguments

Author: teemperor Date: Mon Sep 23 01:16:19 2019 New Revision: 372556 URL: http://llvm.org/viewvc/llvm-project?rev=372556&view=rev Log: [lldb] Reduce some dangerous boilerplate with CompletionRequest::ShiftArguments We should in general not allow external code to fiddle with the internals of Comp

[Lldb-commits] [lldb] r372561 - [lldb][NFC] Remove argument prefix checking boilerplate when adding completions

Author: teemperor Date: Mon Sep 23 01:59:21 2019 New Revision: 372561 URL: http://llvm.org/viewvc/llvm-project?rev=372561&view=rev Log: [lldb][NFC] Remove argument prefix checking boilerplate when adding completions Modified: lldb/trunk/include/lldb/Utility/CompletionRequest.h lldb/trunk/

[Lldb-commits] [lldb] r372566 - [lldb] Make cursor index in CompletionRequest unsigned

Author: teemperor Date: Mon Sep 23 02:46:17 2019 New Revision: 372566 URL: http://llvm.org/viewvc/llvm-project?rev=372566&view=rev Log: [lldb] Make cursor index in CompletionRequest unsigned The fact that index==-1 means "no arguments" is not obvious and only used in one place from what I can tel

[Lldb-commits] [PATCH] D67861: [LLDB] Check for the __MINGW32__ define instead of __MINGW64

labath added a reviewer: amccarth. labath added a comment. Judging by the microsoft docs , `vsnprintf` is avaliable at least since VS 2017 (the lowest version su

[Lldb-commits] [lldb] r372568 - [lldb][NFC] Make cursor char position unsigned in CompletionRequest

Author: teemperor Date: Mon Sep 23 02:51:36 2019 New Revision: 372568 URL: http://llvm.org/viewvc/llvm-project?rev=372568&view=rev Log: [lldb][NFC] Make cursor char position unsigned in CompletionRequest This was only an 'int' because to fit into the old API which is gone by now. Modified: l

[Lldb-commits] [lldb] r372569 - [lldb][NFC] Fix documentation of CompletionRequest::AddCompletion

Author: teemperor Date: Mon Sep 23 02:53:33 2019 New Revision: 372569 URL: http://llvm.org/viewvc/llvm-project?rev=372569&view=rev Log: [lldb][NFC] Fix documentation of CompletionRequest::AddCompletion Modified: lldb/trunk/include/lldb/Utility/CompletionRequest.h Modified: lldb/trunk/include

[Lldb-commits] [lldb] r372572 - [lldb][NFC] Remove dead code in Options::HandleOptionArgumentCompletion

Author: teemperor Date: Mon Sep 23 02:56:53 2019 New Revision: 372572 URL: http://llvm.org/viewvc/llvm-project?rev=372572&view=rev Log: [lldb][NFC] Remove dead code in Options::HandleOptionArgumentCompletion Modified: lldb/trunk/source/Interpreter/Options.cpp Modified: lldb/trunk/source/Inte

[Lldb-commits] [PATCH] D67885: [LLDB] Add a missing specification of linking against dbghelp

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. LGTM. It might be nice to add a comment that this is for saving of minidump files (I assume that's the only reason). The reason for that is the object file plugins are generally expected to wo

[Lldb-commits] [lldb] r372574 - [lldb][NFC] Remove unused variable in Options::HandleOptionArgumentCompletion

Author: teemperor Date: Mon Sep 23 03:02:26 2019 New Revision: 372574 URL: http://llvm.org/viewvc/llvm-project?rev=372574&view=rev Log: [lldb][NFC] Remove unused variable in Options::HandleOptionArgumentCompletion Modified: lldb/trunk/source/Interpreter/Options.cpp Modified: lldb/trunk/sourc

[Lldb-commits] [PATCH] D67861: [LLDB] Check for the __MINGW32__ define instead of __MINGW64

mstorsjo added a comment. In D67861#1678618 , @labath wrote: > Judging by the microsoft docs > , > `vsnprintf` is avali

[Lldb-commits] [PATCH] D67861: [LLDB] Remove a now redundant windows specific workaround

mstorsjo updated this revision to Diff 221276. mstorsjo retitled this revision from "[LLDB] Check for the __MINGW32__ define instead of __MINGW64" to "[LLDB] Remove a now redundant windows specific workaround". mstorsjo edited the summary of this revision. mstorsjo added a comment. Updated the p

[Lldb-commits] [PATCH] D67903: [lldb] Add completion support for log enable/disable/list

teemperor created this revision. teemperor added a reviewer: LLDB. Herald added subscribers: lldb-commits, JDevlieghere. Herald added a project: LLDB. Repository: rLLDB LLDB https://reviews.llvm.org/D67903 Files: lldb/include/lldb/Utility/Log.h lldb/packages/Python/lldbsuite/test/function

[Lldb-commits] [PATCH] D67861: [LLDB] Remove a now redundant windows specific workaround

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Awesome. Let's give that a spin. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67861/new/ https://reviews.llvm.org/D67861 ___ lldb-commi

[Lldb-commits] [PATCH] D67896: [LLDB] Add a void* cast when passing object pointers to printf %p

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. This looks fine. When you see a pattern like `if(log) { LLDB_LOGF(...) }`, feel free to delete the surrounding `if(log)`. It is no longer necessary, and the reason it is still there is simply

[Lldb-commits] [PATCH] D67894: [LLDB] Rework a MinGW build fix from D65691

labath added a comment. Let's wait for @hhb to give this a spin to avoid twiddling this back and forth. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67894/new/ https://reviews.llvm.org/D67894 ___ lldb-commits mail

[Lldb-commits] [PATCH] D67885: [LLDB] Add a missing specification of linking against dbghelp

MyDeveloperDay added a comment. Just as a drive by comment, there is code in DebugInfo/Symbolize/Symbolize.cpp that loads dbghelp via #pragma comment(lib... trick There is also code to load dbghelp dynamically in lib\Support\Windows\Signal.inc including loading MiniDumpWriteDump Repository:

[Lldb-commits] [PATCH] D67885: [LLDB] Add a missing specification of linking against dbghelp

mstorsjo added a comment. In D67885#1678701 , @MyDeveloperDay wrote: > Just as a drive by comment, there is code in > DebugInfo/Symbolize/Symbolize.cpp that loads dbghelp via #pragma > comment(lib... trick Yes, but as I mentioned in the patch descrip

[Lldb-commits] [PATCH] D67906: [lldb] Provide tab completion for target select/delete

teemperor created this revision. teemperor added a reviewer: LLDB. Herald added subscribers: lldb-commits, JDevlieghere, abidh. Herald added a project: LLDB. Select and delete are similar enough to implement/test this in one batch. Completion looks like this: (lldb) target select Available

[Lldb-commits] [PATCH] D67890: [lldb] [cmake] Fix installing Python modules on systems using /usr/lib

labath accepted this revision. labath added a subscriber: ZeGentzy. labath added a comment. This revision is now accepted and ready to land. This looks like a good idea to me, but given how fiddly this code seems to be, lets give some time for @hhb and @ZeGentzy to try this out. The logical next

[Lldb-commits] [PATCH] D67890: [lldb] [cmake] Fix installing Python modules on systems using /usr/lib

mgorny marked an inline comment as done. mgorny added a comment. I think it will be also nice to eliminate get_relative_lib_dir.py long term. Comment at: lldb/scripts/CMakeLists.txt:45-50 + execute_process( +COMMAND ${PYTHON_EXECUTABLE} +-c "import distutils.syscon

[Lldb-commits] [lldb] r372587 - [LLDB] Add a missing specification of linking against dbghelp

Author: mstorsjo Date: Mon Sep 23 05:03:08 2019 New Revision: 372587 URL: http://llvm.org/viewvc/llvm-project?rev=372587&view=rev Log: [LLDB] Add a missing specification of linking against dbghelp The PECOFF object file plugin uses the dbghelp API, but doesn't specify that it has to be linked in

[Lldb-commits] [lldb] r372586 - [LLDB] Use the Windows SOCKET type on all windows targets, not only MSVC

Author: mstorsjo Date: Mon Sep 23 05:02:59 2019 New Revision: 372586 URL: http://llvm.org/viewvc/llvm-project?rev=372586&view=rev Log: [LLDB] Use the Windows SOCKET type on all windows targets, not only MSVC Differential Revision: https://reviews.llvm.org/D67859 Modified: lldb/trunk/include/

[Lldb-commits] [lldb] r372589 - [LLDB] Avoid a warning about an unused static variable

Author: mstorsjo Date: Mon Sep 23 05:03:21 2019 New Revision: 372589 URL: http://llvm.org/viewvc/llvm-project?rev=372589&view=rev Log: [LLDB] Avoid a warning about an unused static variable The variable is unused on windows. Differential Revision: https://reviews.llvm.org/D67895 Modified: l

[Lldb-commits] [lldb] r372590 - [LLDB] Add a void* cast when passing object pointers to printf %p

Author: mstorsjo Date: Mon Sep 23 05:03:28 2019 New Revision: 372590 URL: http://llvm.org/viewvc/llvm-project?rev=372590&view=rev Log: [LLDB] Add a void* cast when passing object pointers to printf %p This fixes build warnings in MinGW mode. Also remove leftover if (log) {} around the log macro.

[Lldb-commits] [lldb] r372588 - [LLDB] Remove a stray semicolon. NFC.

Author: mstorsjo Date: Mon Sep 23 05:03:14 2019 New Revision: 372588 URL: http://llvm.org/viewvc/llvm-project?rev=372588&view=rev Log: [LLDB] Remove a stray semicolon. NFC. This fixes build warnings with at least GCC. Modified: lldb/trunk/source/Utility/Scalar.cpp Modified: lldb/trunk/sourc

[Lldb-commits] [lldb] r372591 - [LLDB] Remove a now redundant windows specific workaround

Author: mstorsjo Date: Mon Sep 23 05:03:33 2019 New Revision: 372591 URL: http://llvm.org/viewvc/llvm-project?rev=372591&view=rev Log: [LLDB] Remove a now redundant windows specific workaround vsnprintf(NULL, 0, ...) works for measuring the needed string size on all supported Windows variants; it

[Lldb-commits] [lldb] r372592 - [LLDB] Check for _WIN32 instead of _MSC_VER for code specific to windows in general

Author: mstorsjo Date: Mon Sep 23 05:03:56 2019 New Revision: 372592 URL: http://llvm.org/viewvc/llvm-project?rev=372592&view=rev Log: [LLDB] Check for _WIN32 instead of _MSC_VER for code specific to windows in general These ifdefs contain code that isn't specific to MSVC but useful for any wind

[Lldb-commits] [PATCH] D67859: [LLDB] Use the Windows SOCKET type on all windows targets, not only MSVC

This revision was automatically updated to reflect the committed changes. Closed by commit rL372586: [LLDB] Use the Windows SOCKET type on all windows targets, not only MSVC (authored by mstorsjo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[Lldb-commits] [PATCH] D67895: [LLDB] Avoid a warning about an unused static variable

This revision was automatically updated to reflect the committed changes. Closed by commit rL372589: [LLDB] Avoid a warning about an unused static variable (authored by mstorsjo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: http

[Lldb-commits] [PATCH] D67885: [LLDB] Add a missing specification of linking against dbghelp

This revision was automatically updated to reflect the committed changes. Closed by commit rL372587: [LLDB] Add a missing specification of linking against dbghelp (authored by mstorsjo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D67861: [LLDB] Remove a now redundant windows specific workaround

This revision was automatically updated to reflect the committed changes. Closed by commit rL372591: [LLDB] Remove a now redundant windows specific workaround (authored by mstorsjo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: h

[Lldb-commits] [PATCH] D67896: [LLDB] Add a void* cast when passing object pointers to printf %p

This revision was automatically updated to reflect the committed changes. Closed by commit rL372590: [LLDB] Add a void* cast when passing object pointers to printf %p (authored by mstorsjo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to com

[Lldb-commits] [PATCH] D67893: [LLDB] Check for _WIN32 instead of _MSC_VER for code specific to windows in general

This revision was automatically updated to reflect the committed changes. Closed by commit rL372592: [LLDB] Check for _WIN32 instead of _MSC_VER for code specific to windows in… (authored by mstorsjo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed p

[Lldb-commits] [PATCH] D67792: File::SetDescriptor() should require options

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. This looks much better to me, but maybe you could add some unit tests for the use cases this fixes (I guess that's the use case of creating a `File` object with an fd, and the writing(?) to it

[Lldb-commits] [PATCH] D67910: [LLDB] Avoid warnings about redefining posix mode defines on MinGW

mstorsjo created this revision. mstorsjo added reviewers: hhb, amccarth, labath. Herald added subscribers: JDevlieghere, abidh. Herald added a project: LLDB. Since these defines were added in LLVM SVN r189364 in 2013, mingw-w64 got defines for S_I?GRP, S_IRWXG, S_I?OTH and S_IRWXO in 2015. Repo

[Lldb-commits] [PATCH] D67911: [LLDB] [Windows] Add missing ifdefs to fix building for non-x86 architectures

mstorsjo created this revision. mstorsjo added reviewers: amccarth, labath, hhb, compnerd, asmith. Herald added subscribers: JDevlieghere, abidh. Herald added a project: LLDB. While debugging on those architectures might not be supported yet, the generic code should still be buildable. This file

[Lldb-commits] [PATCH] D67912: [LLDB] [PECOFF] Recognize arm64 executables

mstorsjo created this revision. mstorsjo added reviewers: amccarth, compnerd, hhb, labath, asmith. Herald added subscribers: JDevlieghere, kristof.beyls. Herald added a project: LLDB. Repository: rLLDB LLDB https://reviews.llvm.org/D67912 Files: lldb/source/Plugins/ObjectFile/PECOFF/ObjectFi

[Lldb-commits] [PATCH] D67913: [LLDB] [Windows] Map COFF ARM machine ids to the right triplet architectures

mstorsjo created this revision. mstorsjo added reviewers: amccarth, compnerd, hhb, labath, asmith. Herald added subscribers: JDevlieghere, kristof.beyls. Herald added a project: LLDB. Repository: rLLDB LLDB https://reviews.llvm.org/D67913 Files: lldb/source/Host/windows/Host.cpp Index: lld

[Lldb-commits] [PATCH] D67760: [lldb] Decouple importing the std C++ module from the way the program is compiled

teemperor updated this revision to Diff 221307. teemperor added a comment. - Addressed feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67760/new/ https://reviews.llvm.org/D67760 Files: lldb/include/lldb/Symbol/CompileUnit.h lldb/include/lldb/Symbol/SymbolFile.h lldb/inclu

[Lldb-commits] [PATCH] D67760: [lldb] Decouple importing the std C++ module from the way the program is compiled

teemperor marked 6 inline comments as done. teemperor added a comment. Thanks for the quick review! Comment at: lldb/include/lldb/Symbol/CompileUnit.h:228 + /// Apply a lambda to each external module referenced by this compilation + /// unit. Recursively also descends into

[Lldb-commits] [PATCH] D67891: remove File::SetStream(), make new files instead.

labath added a comment. While I am fully in favour of removing the SetXXX methods, and it does seem like some amount of shared_ptrs will be needed at the (though I don't fully understand your vission yet), I don't really like this proliferation of shared_ptrs everywhere (there's way too many of

[Lldb-commits] [PATCH] D67793: new api class: SBFile

labath added a comment. In D67793#1678259 , @lawrence_danna wrote: > @labath > > I wrote a patch for the shared_ptr approach. It's simple, but it touches a > lot of lines. > > https://reviews.llvm.org/D67891 > > Now that I've gone and done it, I kind o

[Lldb-commits] [PATCH] D67866: [lldb] Unify python site-packages path

labath requested changes to this revision. labath added a comment. Like I said in the other patch, I think we're stuck with having to match how the python layouts differ between operating systems (though there is definitely a lot of room for improvement in the way that it is done now). Reposit

[Lldb-commits] [PATCH] D67890: [lldb] [cmake] Fix installing Python modules on systems using /usr/lib

labath added inline comments. Comment at: lldb/scripts/CMakeLists.txt:45-50 + execute_process( +COMMAND ${PYTHON_EXECUTABLE} +-c "import distutils.sysconfig, sys; print(distutils.sysconfig.get_python_lib(True, False, sys.argv[1]))" +${CMAKE_BINARY_DIR} +

[Lldb-commits] [PATCH] D67890: [lldb] [cmake] Fix installing Python modules on systems using /usr/lib

mgorny marked an inline comment as done. mgorny added inline comments. Comment at: lldb/scripts/CMakeLists.txt:45-50 + execute_process( +COMMAND ${PYTHON_EXECUTABLE} +-c "import distutils.sysconfig, sys; print(distutils.sysconfig.get_python_lib(True, False, sys.argv

[Lldb-commits] [PATCH] D67915: [LLDB] Fix logically dead code

jankratochvil added a comment. Personally I would check GIT history for some reasons it was written this way. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67915/new/ https://reviews.llvm.org/D67915 __

[Lldb-commits] [PATCH] D67915: [LLDB] Fix logically dead code

kwk created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. kwk added a reviewer: jankratochvil. kwk edited the summary of this revision. jankratochvil added a comment. Personally I would check GIT history for some reasons it was written this way. The indica

[Lldb-commits] [PATCH] D67915: [LLDB] Fix logically dead code

jankratochvil added a comment. FYI the link does not work for me: https://scan3.coverity.com/reports.htm#v39507/p12195/fileInstanceId=27614986&defectInstanceId=8037484&mergedDefectId=221581 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67915/new/

[Lldb-commits] [PATCH] D67890: [lldb] [cmake] Fix installing Python modules on systems using /usr/lib

labath added inline comments. Comment at: lldb/scripts/CMakeLists.txt:45-50 + execute_process( +COMMAND ${PYTHON_EXECUTABLE} +-c "import distutils.sysconfig, sys; print(distutils.sysconfig.get_python_lib(True, False, sys.argv[1]))" +${CMAKE_BINARY_DIR} +

[Lldb-commits] [PATCH] D67915: [LLDB] Fix logically dead code

kwk added a comment. @jankratochvil the file only has two revisions: https://github.com/llvm/llvm-project/commits/b9c1b51e45b845debb76d8658edabca70ca56079/lldb/include/lldb/Core/LoadedModuleInfoList.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6

[Lldb-commits] [lldb] r372608 - [LLDB] Fix logically dead code

Author: kwk Date: Mon Sep 23 07:05:51 2019 New Revision: 372608 URL: http://llvm.org/viewvc/llvm-project?rev=372608&view=rev Log: [LLDB] Fix logically dead code Summary: The indicated dead code may have performed some action; that action will never occur. In lldb_private::LoadedModuleInfoList::

[Lldb-commits] [PATCH] D67890: [lldb] [cmake] Fix installing Python modules on systems using /usr/lib

mgorny marked an inline comment as done. mgorny added inline comments. Comment at: lldb/scripts/CMakeLists.txt:45-50 + execute_process( +COMMAND ${PYTHON_EXECUTABLE} +-c "import distutils.sysconfig, sys; print(distutils.sysconfig.get_python_lib(True, False, sys.argv

[Lldb-commits] [PATCH] D67915: [LLDB] Fix logically dead code

jankratochvil accepted this revision. jankratochvil added a comment. This revision is now accepted and ready to land. In D67915#1679030 , @kwk wrote: > @jankratochvil the file only has two revisions: > https://github.com/llvm/llvm-project/commits/b9c1b51e

[Lldb-commits] [PATCH] D67915: [LLDB] Fix logically dead code

This revision was automatically updated to reflect the committed changes. Closed by commit rL372608: [LLDB] Fix logically dead code (authored by kwk, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D67915?v

[Lldb-commits] [PATCH] D66398: 2/2: Fix `TestDataFormatterStdList` regression

labath added a comment. In D66398#1677414 , @jankratochvil wrote: > "jankratochvil added a reverting change" - that is not true, Differential got > somehow confused by the commit text there talking about this patch. Good to know, but assuming that the

[Lldb-commits] [PATCH] D66398: 2/2: Fix `TestDataFormatterStdList` regression

jankratochvil added a comment. In D66398#1679071 , @labath wrote: > Good to know, but assuming that the above patch sticks, the plan *is* to > revert this, right? D66654 is already checked-in, I have considered it as d

[Lldb-commits] [PATCH] D66638: Unwind: Add a stack scanning mechanism to support win32 unwinding

labath added a comment. Thanks for the review and sorry for the delay (I was OOO). The idea to use `Process::GetLoadAddressPermissions` makes sense, both from consistency and correctness perspectives. Unfortunately it does not work "out of the box" because minidump core files (my primary use ca

[Lldb-commits] [PATCH] D67912: [LLDB] [PECOFF] Recognize arm64 executables

compnerd accepted this revision. compnerd added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:202 + case MachineArm64: +spec.SetTriple("aarch64-pc-windows"); +specs.Append(module_s

[Lldb-commits] [PATCH] D67911: [LLDB] [Windows] Add missing ifdefs to fix building for non-x86 architectures

compnerd added a comment. What do you think of adding some sort of notification that hardware breakpoints are currently unsupported and that we are falling back to software breakpoints for the `#else` case? Comment at: lldb/source/Plugins/Process/Windows/Common/RegisterConte

[Lldb-commits] [PATCH] D67913: [LLDB] [Windows] Map COFF ARM machine ids to the right triplet architectures

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. Nit: `triple`, not `triplet`. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67913/new/ https://reviews.llvm.org/D67913 ___

[Lldb-commits] [PATCH] D65942: Disallow implicit conversion from pointers to bool in llvm::toStringRef

dblaikie added inline comments. Comment at: lldb/source/Symbol/TypeSystem.cpp:331 "TypeSystem for language " + - llvm::toStringRef(Language::GetNameForLanguageType(language)) + + llvm::StringRef(Language::GetNameForLanguageType(language)) +

[Lldb-commits] [PATCH] D67903: [lldb] Add completion support for log enable/disable/list

JDevlieghere accepted this revision as: JDevlieghere. JDevlieghere added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Utility/Log.cpp:49 + +void Log::ListCategories(llvm::raw_ostream &stream, + const ChannelMap:

[Lldb-commits] [PATCH] D67906: [lldb] Provide tab completion for target select/delete

JDevlieghere added inline comments. Comment at: lldb/source/Commands/CommandObjectTarget.cpp:63 const char *prefix_cstr, - bool show_stopped_process_status, Stream &strm) { + bool show_stopped_process

[Lldb-commits] [PATCH] D67890: [lldb] [cmake] Fix installing Python modules on systems using /usr/lib

JDevlieghere added a comment. +1 on passing this information to the Python script. Personally I'd like to move more of that logic into CMake so we can properly track dependencies and don't have to have dummy targets that are always out of date. This would be a step in the right direction. CHA

[Lldb-commits] [PATCH] D67890: [lldb] [cmake] Fix installing Python modules on systems using /usr/lib

hhb added inline comments. Comment at: lldb/scripts/CMakeLists.txt:45-50 + execute_process( +COMMAND ${PYTHON_EXECUTABLE} +-c "import distutils.sysconfig, sys; print(distutils.sysconfig.get_python_lib(True, False, sys.argv[1]))" +${CMAKE_BINARY_DIR} +OUT

[Lldb-commits] [PATCH] D67890: [lldb] [cmake] Fix installing Python modules on systems using /usr/lib

hhb added a comment. And thanks for this and it is definitely an improvement! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67890/new/ https://reviews.llvm.org/D67890 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.l

[Lldb-commits] [PATCH] D67869: [ABISysV] Fix regression for Simulator and MacABI

aprantl accepted this revision. aprantl added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/ABI/SysV-x86_64/ABISysV_x86_64.cpp:233 + case llvm::Triple::EnvironmentType::Simulator: + case llvm::Triple::Environme

[Lldb-commits] [PATCH] D67890: [lldb] [cmake] Fix installing Python modules on systems using /usr/lib

mgorny added a reviewer: ZeGentzy. mgorny marked an inline comment as done. mgorny added inline comments. Comment at: lldb/scripts/get_relative_lib_dir.py:26 split_libdir = arch_specific_libdir.split(os.sep) -lib_re = re.compile(r"^lib.+$") +lib_re = re.compile(r"^li

[Lldb-commits] [PATCH] D67869: [ABISysV] Fix regression for Simulator and MacABI

aprantl added a comment. What does `x86_64-apple-darwin` canonicalize to? Do we need an extra case for that? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67869/new/ https://reviews.llvm.org/D67869 ___ lldb-commit

[Lldb-commits] [PATCH] D67869: [ABISysV] Fix regression for Simulator and MacABI

aprantl added inline comments. Comment at: lldb/source/Plugins/ABI/SysV-x86_64/ABISysV_x86_64.cpp:231 + case llvm::Triple::OSType::WatchOS: +switch(os_env) { + case llvm::Triple::EnvironmentType::Simulator: clang-format? Repository: rLLD

[Lldb-commits] [PATCH] D67890: [lldb] [cmake] Fix installing Python modules on systems using /usr/lib

hhb added inline comments. Comment at: lldb/scripts/get_relative_lib_dir.py:26 split_libdir = arch_specific_libdir.split(os.sep) -lib_re = re.compile(r"^lib.+$") +lib_re = re.compile(r"^lib.*$") mgorny wrote: > hhb wrote: > > If we go this way, sho

[Lldb-commits] [PATCH] D67890: [lldb] [cmake] Fix installing Python modules on systems using /usr/lib

mgorny marked an inline comment as done. mgorny added inline comments. Comment at: lldb/scripts/get_relative_lib_dir.py:26 split_libdir = arch_specific_libdir.split(os.sep) -lib_re = re.compile(r"^lib.+$") +lib_re = re.compile(r"^lib.*$") hhb wrote

[Lldb-commits] [PATCH] D67890: [lldb] [cmake] Fix installing Python modules on systems using /usr/lib

hhb added inline comments. Comment at: lldb/scripts/get_relative_lib_dir.py:26 split_libdir = arch_specific_libdir.split(os.sep) -lib_re = re.compile(r"^lib.+$") +lib_re = re.compile(r"^lib.*$") mgorny wrote: > hhb wrote: > > mgorny wrote: > > > hh

[Lldb-commits] [lldb] r372634 - [lldb-suite] TestCallOverriddenMethod.py is now passing on Windows

Author: stella.stamenova Date: Mon Sep 23 10:51:27 2019 New Revision: 372634 URL: http://llvm.org/viewvc/llvm-project?rev=372634&view=rev Log: [lldb-suite] TestCallOverriddenMethod.py is now passing on Windows The test is now passing, so remove the expected failure. No other tests associated wit

[Lldb-commits] [PATCH] D66638: Unwind: Add a stack scanning mechanism to support win32 unwinding

clayborg added a comment. In D66638#1679195 , @labath wrote: > Thanks for the review and sorry for the delay (I was OOO). The idea to use > `Process::GetLoadAddressPermissions` makes sense, both from consistency and > correctness perspectives. Unfortunat

[Lldb-commits] [PATCH] D67890: [lldb] [cmake] Fix installing Python modules on systems using /usr/lib

mgorny marked an inline comment as done. mgorny added inline comments. Comment at: lldb/scripts/get_relative_lib_dir.py:26 split_libdir = arch_specific_libdir.split(os.sep) -lib_re = re.compile(r"^lib.+$") +lib_re = re.compile(r"^lib.*$") hhb wrote

[Lldb-commits] [PATCH] D67890: [lldb] [cmake] Fix installing Python modules on systems using /usr/lib

hhb added inline comments. Comment at: lldb/scripts/get_relative_lib_dir.py:26 split_libdir = arch_specific_libdir.split(os.sep) -lib_re = re.compile(r"^lib.+$") +lib_re = re.compile(r"^lib.*$") mgorny wrote: > hhb wrote: > > mgorny wrote: > > > hh

[Lldb-commits] [PATCH] D67890: [lldb] [cmake] Fix installing Python modules on systems using /usr/lib

hhb added inline comments. Comment at: lldb/scripts/get_relative_lib_dir.py:26 split_libdir = arch_specific_libdir.split(os.sep) -lib_re = re.compile(r"^lib.+$") +lib_re = re.compile(r"^lib.*$") hhb wrote: > mgorny wrote: > > hhb wrote: > > > mgorn

[Lldb-commits] [PATCH] D67894: [LLDB] Rework a MinGW build fix from D65691

hhb accepted this revision. hhb added a comment. This revision is now accepted and ready to land. Thanks! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67894/new/ https://reviews.llvm.org/D67894 ___ lldb-commits ma

[Lldb-commits] [PATCH] D67890: [lldb] [cmake] Fix installing Python modules on systems using /usr/lib

mgorny marked an inline comment as done. mgorny added inline comments. Comment at: lldb/scripts/get_relative_lib_dir.py:26 split_libdir = arch_specific_libdir.split(os.sep) -lib_re = re.compile(r"^lib.+$") +lib_re = re.compile(r"^lib.*$") hhb wrote

[Lldb-commits] [lldb] r372642 - [ABISysV] Fix regression for Simulator and MacABI

Author: jdevlieghere Date: Mon Sep 23 12:06:00 2019 New Revision: 372642 URL: http://llvm.org/viewvc/llvm-project?rev=372642&view=rev Log: [ABISysV] Fix regression for Simulator and MacABI The ABISysV ABI was refactored in r364216 to support the Windows ABI for x86_64. In particular it changed AB

[Lldb-commits] [PATCH] D67869: [ABISysV] Fix regression for Simulator and MacABI

This revision was automatically updated to reflect the committed changes. Closed by commit rL372642: [ABISysV] Fix regression for Simulator and MacABI (authored by JDevlieghere, committed by ). Herald added subscribers: llvm-commits, fedor.sergeev. Herald added a project: LLVM. Changed prior to c

[Lldb-commits] [PATCH] D67891: remove File::SetStream(), make new files instead.

lawrence_danna added a comment. In D67891#1678933 , @labath wrote: > The first option would require making the File class movable I don't think making File movable will work. I'll be wanting a PythonFile subclass, which overrides virtual metho

[Lldb-commits] [PATCH] D67911: [LLDB] [Windows] Add missing ifdefs to fix building for non-x86 architectures

mstorsjo marked an inline comment as done. mstorsjo added a comment. In D67911#1679333 , @compnerd wrote: > What do you think of adding some sort of notification that hardware > breakpoints are currently unsupported and that we are falling back to > soft

[Lldb-commits] [PATCH] D67789: bugfix: File::GetWaitableHandle() should call fileno()

lawrence_danna updated this revision to Diff 221383. lawrence_danna added a comment. nits fixed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67789/new/ https://reviews.llvm.org/D67789 Files: lldb/source/Host/common/File.cpp lldb/unittests/Hos

[Lldb-commits] [PATCH] D67789: bugfix: File::GetWaitableHandle() should call fileno()

lawrence_danna marked 2 inline comments as done. lawrence_danna added a comment. nits fixed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67789/new/ https://reviews.llvm.org/D67789 ___ lldb-commits mai

[Lldb-commits] [lldb] r372644 - [Host] File::GetWaitableHandle() should call fileno()

Author: jdevlieghere Date: Mon Sep 23 12:34:26 2019 New Revision: 372644 URL: http://llvm.org/viewvc/llvm-project?rev=372644&view=rev Log: [Host] File::GetWaitableHandle() should call fileno() If the file has m_stream, it may not have a m_descriptor. GetWaitableHandle() should call GetDescriptor(

[Lldb-commits] [PATCH] D67789: bugfix: File::GetWaitableHandle() should call fileno()

This revision was automatically updated to reflect the committed changes. Closed by commit rL372644: [Host] File::GetWaitableHandle() should call fileno() (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: h

[Lldb-commits] [PATCH] D67890: [lldb] [cmake] Unify and correct Python module installation paths

mgorny updated this revision to Diff 221388. mgorny retitled this revision from "[lldb] [cmake] Fix installing Python modules on systems using /usr/lib" to "[lldb] [cmake] Unify and correct Python module installation paths". mgorny edited the summary of this revision. mgorny added a comment. O-k

[Lldb-commits] [PATCH] D67792: File::SetDescriptor() should require options

lawrence_danna updated this revision to Diff 221390. lawrence_danna added a comment. added unit test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67792/new/ https://reviews.llvm.org/D67792 Files: lldb/include/lldb/Host/File.h lldb/source/Core

[Lldb-commits] [PATCH] D67776: Use UnixSignals::ShouldSuppress to filter out signals a process expects

jingham added a comment. First off, note that this becomes complicated because this patch tied the decision of whether a given stop reason should warrant returning control to the user in lldb's "batch mode", and whether the signal should be passed back to the target. That isn't a necessary bin

[Lldb-commits] [PATCH] D67774: [Mangle] Add flag to asm labels to disable global prefixing

vsk updated this revision to Diff 221391. vsk marked 3 inline comments as done. vsk added a comment. - Address latest review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67774/new/ https://reviews.llvm.org/D67774 Files: clang/include/clang/Basic/Attr.td clang/include/cla

  1   2   >