mstorsjo marked an inline comment as done. mstorsjo added a comment. In D67911#1679333 <https://reviews.llvm.org/D67911#1679333>, @compnerd wrote:
> What do you think of adding some sort of notification that hardware > breakpoints are currently unsupported and that we are falling back to > software breakpoints for the `#else` case? I guess it could make sense. What kind of notification do you have in mind? ================ Comment at: lldb/source/Plugins/Process/Windows/Common/RegisterContextWindows.cpp:87 case 4: #if defined(__x86_64__) || defined(_M_AMD64) case 8: ---------------- compnerd wrote: > Should this line not also include `|| defined(__aarch64__) || > defined(_M_ARM64)`? I guess it should. Or this might be one of the few places where checking for just `_WIN64` might be easiest? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67911/new/ https://reviews.llvm.org/D67911 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
