[Lldb-commits] [PATCH] D64112: Add plugin.process.gdb-remote.use-libraries-svr4 option

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Thank you. I don't think tests are necessary right now, since this is effectively NFC for any in-tree server stub. Once we flip the value of the setting to true, it would be nice to add a tes

[Lldb-commits] [lldb] r365038 - [CMake] Avoid libcxxabi dependency when building LLDB from the monorepo on macOS

Author: stefan.graenitz Date: Wed Jul 3 06:21:48 2019 New Revision: 365038 URL: http://llvm.org/viewvc/llvm-project?rev=365038&view=rev Log: [CMake] Avoid libcxxabi dependency when building LLDB from the monorepo on macOS libc++abi became mandatory to link the libc++ binaries. LLDB only needs th

[Lldb-commits] [PATCH] D64118: [lldb_test_suite] Fix lldb test suite targeting remote Android

xiaobai added a reviewer: labath. xiaobai added a subscriber: labath. xiaobai added a comment. This patch looks fine to me overall. I'm unsure if LLDB has a guarantee about which NDK version its compatible with, but I'm alright with staying up to date with the latest release @labath: Maybe you'

[Lldb-commits] [PATCH] D64112: Add plugin.process.gdb-remote.use-libraries-svr4 option

This revision was automatically updated to reflect the committed changes. Closed by commit rL365059: Add plugin.process.gdb-remote.use-libraries-svr4 option (authored by aadsm, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https:

[Lldb-commits] [PATCH] D64118: [lldb_test_suite] Fix lldb test suite targeting remote Android

srhines added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/make/Android.rules:93 -L$(NDK_ROOT)/sources/cxx-stl/llvm-libc++/libs/$(STL_ARCH) \ - $(NDK_ROOT)/sources/cxx-stl/llvm-libc++/libs/$(STL_ARCH)/libc++.a + $(

[Lldb-commits] [PATCH] D64154: [Docs] Unify build instructions

JDevlieghere created this revision. JDevlieghere added reviewers: labath, mgorny, stella.stamenova, teemperor, sgraenitz. JDevlieghere added a project: LLDB. Herald added a subscriber: srhines. The current build instructions are structured according the host platform. Instead of having instructi

[Lldb-commits] [PATCH] D64154: [Docs] Unify build instructions

stella.stamenova added inline comments. Comment at: lldb/docs/resources/build.rst:132 environment variable if it is specified). * ``LLDB_TEST_C_COMPILER`` or ``LLDB_TEST_CXX_COMPILER``: The test suite needs to be able to find a copy of clang.exe that it can use to compile

[Lldb-commits] [PATCH] D64154: [Docs] Unify build instructions

xiaobai added a comment. Thanks for doing this! :D Comment at: lldb/docs/resources/build.rst:145 - cmake -G Ninja -DLLDB_TEST_DEBUG_TEST_CRASHES=1 -DPYTHON_HOME=C:\Python35 -DLLDB_TEST_USE_CUSTOM_C_COMPILER=ON -DLLDB_TEST_C_COMPILER=d:\src\llvmbuild\ninja_release\bin\clang

[Lldb-commits] [PATCH] D64154: [Docs] Unify build instructions

JDevlieghere updated this revision to Diff 207879. JDevlieghere marked an inline comment as done. JDevlieghere added a comment. - Move up custom test compilers - Specify that the CMake options are not Windows specific CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64154/new/ https://revi

[Lldb-commits] [PATCH] D64157: [lldb][doc] Move code signing instructions to website [NFC]

teemperor created this revision. teemperor added a reviewer: JDevlieghere. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. People are more likely to find this if we put it on the website alongside the build instructions. Repository: rLLDB LLDB https://reviews.llvm.org/

[Lldb-commits] [PATCH] D64154: [Docs] Unify build instructions

JDevlieghere updated this revision to Diff 207880. JDevlieghere added a comment. Make Windows invocation look like a Windows invocation CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64154/new/ https://reviews.llvm.org/D64154 Files: lldb/docs/resources/build.rst Index: lldb/docs/reso

[Lldb-commits] [PATCH] D64157: [lldb][doc] Move code signing instructions to website [NFC]

teemperor abandoned this revision. teemperor added a comment. Seems like I got ninja'd by D64154 :( Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64157/new/ https://reviews.llvm.org/D64157 ___

[Lldb-commits] [lldb] r365081 - [Docs] Unify build instructions

Author: jdevlieghere Date: Wed Jul 3 13:45:06 2019 New Revision: 365081 URL: http://llvm.org/viewvc/llvm-project?rev=365081&view=rev Log: [Docs] Unify build instructions The current build instructions are structured according the host platform. Instead of having instructions on how to build with

[Lldb-commits] [lldb] r365083 - [Docs] Update documentation build instructions.

Author: jdevlieghere Date: Wed Jul 3 13:47:49 2019 New Revision: 365083 URL: http://llvm.org/viewvc/llvm-project?rev=365083&view=rev Log: [Docs] Update documentation build instructions. Given that we use Ninja as the build system in the instructions below, we might as well use it to build the do

[Lldb-commits] [lldb] r365082 - Remove code-signing.txt now that it's part of the docs

Author: jdevlieghere Date: Wed Jul 3 13:47:46 2019 New Revision: 365082 URL: http://llvm.org/viewvc/llvm-project?rev=365082&view=rev Log: Remove code-signing.txt now that it's part of the docs The file's content is part of the website: https://lldb.llvm.org/resources/build.html Removed: lld

[Lldb-commits] [PATCH] D64159: [Core] Generalize ValueObject::MaybeCalculateCompleteType

xiaobai created this revision. xiaobai added reviewers: jingham, clayborg, JDevlieghere. Instead of hardcoding ClangASTContext and ObjCLanguageRuntime, we can generalize this by creating the method CalculateCompleteType in LanguageRuntime and moving the current MaybeCalculateCompleteType implement

[Lldb-commits] [PATCH] D64154: [Docs] Unify build instructions

JDevlieghere closed this revision. JDevlieghere added a comment. Landed in rL365081 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64154/new/ https://reviews.llvm.org/D64154 ___ lldb-commits mailing list l

[Lldb-commits] [lldb] r365086 - [Docs] Remove stale builder

Author: jdevlieghere Date: Wed Jul 3 13:53:57 2019 New Revision: 365086 URL: http://llvm.org/viewvc/llvm-project?rev=365086&view=rev Log: [Docs] Remove stale builder Modified: lldb/trunk/docs/resources/bots.rst Modified: lldb/trunk/docs/resources/bots.rst URL: http://llvm.org/viewvc/llvm-p

[Lldb-commits] [PATCH] D64159: [Core] Generalize ValueObject::MaybeCalculateCompleteType

JDevlieghere added inline comments. Comment at: source/Target/ObjCLanguageRuntime.cpp:404 +ObjCLanguageRuntime::CalculateCompleteType(CompilerType base_type) { + CompilerType type_to_return; + I would move this down. Comment at: source/Target/

[Lldb-commits] [PATCH] D64163: Change LaunchThread interface to return an expected.

JDevlieghere created this revision. JDevlieghere added a reviewer: LLDB. Herald added a project: LLDB. Change the interface to return an expected, instead of taking a Status pointer. Repository: rLLDB LLDB https://reviews.llvm.org/D64163 Files: lldb/include/lldb/Host/ThreadLauncher.h lld

[Lldb-commits] [lldb] r365090 - Refactor ObjectFile::GetSDKVersion

Author: teemperor Date: Wed Jul 3 15:21:10 2019 New Revision: 365090 URL: http://llvm.org/viewvc/llvm-project?rev=365090&view=rev Log: Refactor ObjectFile::GetSDKVersion Summary: This patch modernizes the GetSDKVersion API and hopefully prevents problems such as the ones discovered in D61218.

[Lldb-commits] [PATCH] D61233: Refactor ObjectFile::GetSDKVersion

This revision was automatically updated to reflect the committed changes. Closed by commit rL365090: Refactor ObjectFile::GetSDKVersion (authored by teemperor, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.or

[Lldb-commits] [PATCH] D64163: Change LaunchThread interface to return an expected.

jingham added inline comments. Comment at: lldb/source/API/SBHostOS.cpp:110-117 + llvm::Expected thread = + ThreadLauncher::LaunchThread(name, thread_function, thread_arg); + if (!thread) { +llvm::consumeError(thread.takeError()); +return {}; + } + ---

[Lldb-commits] [PATCH] D64159: [Core] Generalize ValueObject::MaybeCalculateCompleteType

clayborg added a comment. The main issue I have with this is the name of the function we are adding to LanguageRuntime. See inlined comments. Comment at: include/lldb/Target/ObjCLanguageRuntime.h:253 + CompilerType CalculateCompleteType(CompilerType base_type) override; + -

[Lldb-commits] [PATCH] D64163: Change LaunchThread interface to return an expected.

JDevlieghere updated this revision to Diff 207929. JDevlieghere added a comment. Address Jim's feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64163/new/ https://reviews.llvm.org/D64163 Files: lldb/include/lldb/Host/ThreadLauncher.h lldb/source/API/SBHostOS.cpp lldb/sourc

[Lldb-commits] [PATCH] D63166: Move common functionality from processwindows into processdebugger

Hui added inline comments. Comment at: source/Plugins/Process/Windows/Common/ProcessDebugger.cpp:169-170 + +Status ProcessDebugger::AttachProcess(lldb::pid_t pid, + const ProcessAttachInfo &attach_info, + D

[Lldb-commits] [PATCH] D64194: [lldb] Fix crash due to dollar character in variable names.

teemperor created this revision. teemperor added reviewers: jingham, JDevlieghere. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. It's possible to have a dollar character in an identifier with Clang. We use that in LLDB to namespace our own variables, but apparently this t