labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

Thank you.

I don't think tests are necessary right now, since this is effectively NFC for 
any in-tree server stub. Once we flip the value of the setting to true, it 
would be nice to add a test or two which loads some libraries with this setting 
explicitly set to false (emulating a no-libxml build). You can probably just 
adapt some tests in TestLoadUnload.py for that purpose.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64112/new/

https://reviews.llvm.org/D64112



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to