JDevlieghere added inline comments.
================
Comment at: source/Target/ObjCLanguageRuntime.cpp:404
+ObjCLanguageRuntime::CalculateCompleteType(CompilerType base_type) {
+ CompilerType type_to_return;
+
----------------
I would move this down.
================
Comment at: source/Target/ObjCLanguageRuntime.cpp:414
+ else
+ return type_to_return;
+
----------------
and do `return {}` here, to make it clear that the object is empty.
================
Comment at: source/Target/ObjCLanguageRuntime.cpp:417
+ if (!class_type)
+ return type_to_return;
+
----------------
Same here.
================
Comment at: source/Target/ObjCLanguageRuntime.cpp:421
+ if (!class_name)
+ return type_to_return;
+
----------------
Maybe even better would be to return an `llvm::Optional`?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64159/new/
https://reviews.llvm.org/D64159
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
