[Lldb-commits] [PATCH] D63667: Support __kernel_rt_sigreturn in frame initialization

jankratochvil added a comment. When I compare the backtrace from GDB and LLDB (on x86_64, I haven't tried aarch64 as x86_64 is much faster=easier to handle): frame #2: 0x00401195 sigtest2`handler(sig=6) at sigtest2.c:9:5 #2 0x00401195 in handler (sig=6) at sigtest2.c:9

[Lldb-commits] [PATCH] D63240: [Core] Generalize ValueObject::IsRuntimeSupportValue

jingham added a comment. This looks good to me. I wonder if the SymbolContextScope -> Language calculation that you do in IsRuntimeSupportValue should really be done in SymbolContextScope? If that's going to be the policy for going from SymbolContextScope, maybe centralize it there? CHANGES

[Lldb-commits] [PATCH] D63240: [Core] Generalize ValueObject::IsRuntimeSupportValue

clayborg added a comment. In D63240#1562527 , @jingham wrote: > This looks good to me. I wonder if the SymbolContextScope -> Language > calculation that you do in IsRuntimeSupportValue should really be done in > SymbolContextScope? If that's going to b

[Lldb-commits] [lldb] r364666 - Make sure the thread list is updated before you set the stop reason

Author: jingham Date: Fri Jun 28 10:57:19 2019 New Revision: 364666 URL: http://llvm.org/viewvc/llvm-project?rev=364666&view=rev Log: Make sure the thread list is updated before you set the stop reason on a thread. When talking to some older gdb-remote stubs, We were getting a stop reason from th

[Lldb-commits] [PATCH] D62887: Update the thread list before setting stop reasons with an OS plugin

This revision was automatically updated to reflect the committed changes. jingham marked an inline comment as done. Closed by commit rL364666: Make sure the thread list is updated before you set the stop reason (authored by jingham, committed by ). Herald added a project: LLVM. Herald added a subs

[Lldb-commits] [lldb] r364669 - [GDBRemote] Remove code that flushes GDB remote packets

Author: jdevlieghere Date: Fri Jun 28 11:14:27 2019 New Revision: 364669 URL: http://llvm.org/viewvc/llvm-project?rev=364669&view=rev Log: [GDBRemote] Remove code that flushes GDB remote packets The arbitrary timeout when flushing GDB remote packets caused non-determinism and flakiness between te

[Lldb-commits] [PATCH] D63914: Make the expression parser work for missing weak symbols

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. A few nits, but nothing structural. Fix those and this will be good to go. Comment at: include/lldb/Symbol/Symbol.h:257

[Lldb-commits] [PATCH] D63914: Make the expression parser work for missing weak symbols

jingham updated this revision to Diff 207146. jingham added a comment. Addressed Greg's comments Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63914/new/ https://reviews.llvm.org/D63914 Files: include/lldb/Expression/IRExecutionUnit.h include/lldb/Symbol/S

[Lldb-commits] [PATCH] D63914: Make the expression parser work for missing weak symbols

jingham marked 8 inline comments as done. jingham added inline comments. Comment at: include/lldb/Symbol/Symbol.h:258 + m_is_weak : 1, m_type : 7; Mangled m_mangled; // uniqued symbol name/mangled name pair clayborg wrote: > change to: > ``

[Lldb-commits] [lldb] r364686 - Get the expression parser to handle missing weak symbols.

Author: jingham Date: Fri Jun 28 14:40:05 2019 New Revision: 364686 URL: http://llvm.org/viewvc/llvm-project?rev=364686&view=rev Log: Get the expression parser to handle missing weak symbols. MachO only for this patch. Differential Revision: https://reviews.llvm.org/D63914 Added: lldb/trun

[Lldb-commits] [PATCH] D63914: Make the expression parser work for missing weak symbols

This revision was automatically updated to reflect the committed changes. jingham marked an inline comment as done. Closed by commit rL364686: Get the expression parser to handle missing weak symbols. (authored by jingham, committed by ). Herald added a project: LLVM. Herald added a subscriber: ll

[Lldb-commits] [lldb] r364702 - Use const auto *

Author: maskray Date: Fri Jun 28 17:55:13 2019 New Revision: 364702 URL: http://llvm.org/viewvc/llvm-project?rev=364702&view=rev Log: Use const auto * Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp lldb/trunk/source/Symbol/Block.cpp Modified: lldb/trunk/sour